HBASE-28107 Limit max count of rows filtered per scan request. by zhuyaogai · Pull Request #5428 · apache/hbase

zhuyaogai · 2023-09-22T02:46:04Z

Detail: https://issues.apache.org/jira/browse/HBASE-28107

zhuyaogai · 2023-09-22T02:52:01Z

@bbeaudreault hi, could you review code and provide some suggestions if you are available? Thanks!

Apache-HBase · 2023-09-22T03:32:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 54s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	checkstyle	0m 31s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
-0 ⚠️	checkstyle	0m 34s	hbase-server: The patch generated 2 new + 5 unchanged - 0 fixed = 7 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 44s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		31m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 98fa188f3b7a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-22T07:07:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	0m 41s	master passed
+1 💚	shadedjars	4m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 19s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	4m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	225m 52s	hbase-server in the patch passed.
		247m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b818360e26c6 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/testReport/
Max. process+thread count	4812 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-22T07:32:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 32s	master passed
+1 💚	compile	1m 5s	master passed
+1 💚	shadedjars	5m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 15s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	shadedjars	6m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	245m 10s	hbase-server in the patch passed.
		272m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 00be32fd79f9 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/testReport/
Max. process+thread count	4504 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-22T08:04:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 32s	master passed
+1 💚	compile	2m 27s	master passed
+1 💚	checkstyle	0m 31s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 21s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	2m 23s	the patch passed
+1 💚	javac	2m 23s	the patch passed
-0 ⚠️	checkstyle	0m 34s	hbase-server: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 29s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		30m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 83757e961f96 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-22T12:09:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	shadedjars	4m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	6m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
-1 ❌	unit	253m 13s	hbase-server in the patch failed.
		275m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 586fb0554c2c 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/testReport/
Max. process+thread count	4782 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-22T12:23:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	0m 48s	master passed
+1 💚	shadedjars	4m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	265m 42s	hbase-server in the patch passed.
		289m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 748164368f76 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/testReport/
Max. process+thread count	4491 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault

Are you sure this is necessary? I agree that heavily filtered scans can cause problems. As of recently, this should be mostly mitigated with the improvements around blockBytesScanned (HBASE-27227, HBASE-27532, HBASE-27558).

So with those jiras, a heavily filtered scan will have a high volume of blockBytesScanned. This will cause those scans to checkpoint more often due to max scan size limits, so they won't hold up RPC handlers. You can then use quotas to limit these scans, so they don't have to be hard failed instead slowed down.

I prefer that approach over this one because in my experience failing a request is an extreme response which can have consequences for users. Fixing the scan requires figuring out why and pushing code to production, which is time consuming and in the meantime the user queries are failing. Another big problem with filtered rows is it doesn't necessarily happen right as you deploy a new scan workload. It may work fine for a while but over time rows get written that dont match your filters, so one day your scan just starts failing due to the limits.

What do you think? Do you want to give the above jiras a try?

Apache9 · 2023-09-23T06:16:25Z

+ public static final String HBASE_SERVER_SCANNER_MAX_ROWS_FILTERED_PER_REQUEST_KEY =
+ "hbase.server.scanner.max.rows.filtered.per.request";
+
+ private static RegionScannerLimiter INSTANCE;


Better not use the singleton pattern here. Just create a RegionScannerLimiter per region server and store it as a field of HRegionServer?

Apache9 · 2023-09-23T06:17:27Z

+ updateLimiterConf(conf, HBASE_SERVER_SCANNER_MAX_ROWS_FILTERED_PER_REQUEST_KEY);
+ }
+
+ private void updateLimiterConf(Configuration conf, String configKey) {


The config key is always HBASE_SERVER_SCANNER_MAX_ROWS_FILTERED_PER_REQUEST_KEY? Do we really need to pass it as a parameter?

zhuyaogai · 2023-09-27T09:52:50Z

Are you sure this is necessary? I agree that heavily filtered scans can cause problems. As of recently, this should be mostly mitigated with the improvements around blockBytesScanned (HBASE-27227, HBASE-27532, HBASE-27558).
So with those jiras, a heavily filtered scan will have a high volume of blockBytesScanned. This will cause those scans to checkpoint more often due to max scan size limits, so they won't hold up RPC handlers. You can then use quotas to limit these scans, so they don't have to be hard failed instead slowed down.
I prefer that approach over this one because in my experience failing a request is an extreme response which can have consequences for users. Fixing the scan requires figuring out why and pushing code to production, which is time consuming and in the meantime the user queries are failing. Another big problem with filtered rows is it doesn't necessarily happen right as you deploy a new scan workload. It may work fine for a while but over time rows get written that dont match your filters, so one day your scan just starts failing due to the limits.
What do you think? Do you want to give the above jiras a try?

@bbeaudreault hi, Thank you very much for your reply. I roughly looked at above jiras, they are indeed very useful. But I found a scenario that seems not to be covered? If the data that needs to be filtered only exists in the memstore, can the user's scan request be restricted? Besides, I think my implementation is relatively simple, maybe it can also be an option for users to quickly kill heavily filtered scan requests? What do you think?
cc @Apache9

Apache-HBase · 2023-09-27T10:17:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 9s	master passed
+1 💚	compile	2m 29s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	2m 23s	the patch passed
+1 💚	javac	2m 23s	the patch passed
-0 ⚠️	checkstyle	0m 32s	hbase-server: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 31s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		31m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 418a6fb9063e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6cb15b1`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault · 2023-09-27T12:38:44Z

Are you sure this is necessary? I agree that heavily filtered scans can cause problems. As of recently, this should be mostly mitigated with the improvements around blockBytesScanned (HBASE-27227, HBASE-27532, HBASE-27558).
So with those jiras, a heavily filtered scan will have a high volume of blockBytesScanned. This will cause those scans to checkpoint more often due to max scan size limits, so they won't hold up RPC handlers. You can then use quotas to limit these scans, so they don't have to be hard failed instead slowed down.
I prefer that approach over this one because in my experience failing a request is an extreme response which can have consequences for users. Fixing the scan requires figuring out why and pushing code to production, which is time consuming and in the meantime the user queries are failing. Another big problem with filtered rows is it doesn't necessarily happen right as you deploy a new scan workload. It may work fine for a while but over time rows get written that dont match your filters, so one day your scan just starts failing due to the limits.
What do you think? Do you want to give the above jiras a try?
@bbeaudreault hi, Thank you very much for your reply. I roughly looked at above jiras, they are indeed very useful. But I found a scenario that seems not to be covered? If the data that needs to be filtered only exists in the memstore, can the user's scan request be restricted? Besides, I think my implementation is relatively simple, maybe it can also be an option for users to quickly kill heavily filtered scan requests? What do you think? cc @Apache9

Yea currently it doesn't handle the memstore, but we are hoping to add that in the future. Since this feature here is optional, I don't have a problem with adding it. I just think in general hard failures like this are hard to react to in production, so hopefully disabled by default.

Apache-HBase · 2023-09-27T13:46:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 21s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	shadedjars	4m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	4m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	219m 56s	hbase-server in the patch passed.
		240m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 078d5b249ed3 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6cb15b1`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/testReport/
Max. process+thread count	4687 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-27T13:57:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	0m 48s	master passed
+1 💚	shadedjars	4m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	4m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	228m 45s	hbase-server in the patch failed.
		251m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bfa4dd5f0876 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6cb15b1`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/testReport/
Max. process+thread count	4452 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

zhuyaogai · 2023-09-27T13:57:28Z

Are you sure this is necessary? I agree that heavily filtered scans can cause problems. As of recently, this should be mostly mitigated with the improvements around blockBytesScanned (HBASE-27227, HBASE-27532, HBASE-27558).
So with those jiras, a heavily filtered scan will have a high volume of blockBytesScanned. This will cause those scans to checkpoint more often due to max scan size limits, so they won't hold up RPC handlers. You can then use quotas to limit these scans, so they don't have to be hard failed instead slowed down.
I prefer that approach over this one because in my experience failing a request is an extreme response which can have consequences for users. Fixing the scan requires figuring out why and pushing code to production, which is time consuming and in the meantime the user queries are failing. Another big problem with filtered rows is it doesn't necessarily happen right as you deploy a new scan workload. It may work fine for a while but over time rows get written that dont match your filters, so one day your scan just starts failing due to the limits.
What do you think? Do you want to give the above jiras a try?
@bbeaudreault hi, Thank you very much for your reply. I roughly looked at above jiras, they are indeed very useful. But I found a scenario that seems not to be covered? If the data that needs to be filtered only exists in the memstore, can the user's scan request be restricted? Besides, I think my implementation is relatively simple, maybe it can also be an option for users to quickly kill heavily filtered scan requests? What do you think? cc @Apache9
Yea currently it doesn't handle the memstore, but we are hoping to add that in the future. Since this feature here is optional, I don't have a problem with adding it. I just think in general hard failures like this are hard to react to in production, so hopefully disabled by default.

Thank you very much for your suggestion, I have added it to the RegionScannerLimiter doc comments.

Apache-HBase · 2023-09-27T14:29:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 24s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		30m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 70eec6198e76 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6cb15b1`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-27T18:05:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	4m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
-1 ❌	unit	224m 34s	hbase-server in the patch failed.
		246m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3be84eb2b32f 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6cb15b1`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/testReport/
Max. process+thread count	4498 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-27T18:22:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	compile	1m 4s	master passed
+1 💚	shadedjars	6m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 25s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	6m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	234m 33s	hbase-server in the patch passed.
		263m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 85a6e70e9ef4 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6cb15b1`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/testReport/
Max. process+thread count	4358 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

zhuyaogai · 2023-10-08T08:15:12Z

@Apache9 @bbeaudreault hi, I have changed code a bit, with the limitation of the maximum filtered rows for each scan request, and allowing users to optionally kill the scan request. Could you review code for me if you are available? Thanks!

Apache-HBase · 2023-10-08T08:34:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 17s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	4m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 8s	root in the patch failed.
-1 ❌	compile	0m 15s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 15s	hbase-server in the patch failed.
-1 ❌	shadedjars	3m 18s	patch has 10 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 16s	hbase-server in the patch failed.
		14m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b1e2f13ac0d2 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/testReport/
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-08T08:35:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 56s	master passed
+1 💚	compile	2m 23s	master passed
+1 💚	checkstyle	0m 33s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 22s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 13s	root in the patch failed.
-1 ❌	compile	0m 13s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 13s	hbase-server in the patch failed.
-0 ⚠️	checkstyle	0m 32s	hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	1m 16s	The patch causes 10 errors with Hadoop v3.2.4.
-1 ❌	hadoopcheck	2m 32s	The patch causes 10 errors with Hadoop v3.3.6.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 13s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		14m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 49ae71e3873a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-08T08:37:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 19s	root in the patch failed.
-1 ❌	compile	0m 15s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 15s	hbase-server in the patch failed.
-1 ❌	shadedjars	3m 18s	patch has 10 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 17s	hbase-server in the patch failed.
		16m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bebb648f1aae 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/testReport/
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-08T09:04:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 14s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	shadedjars	4m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 9s	root in the patch failed.
-1 ❌	compile	0m 15s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 15s	hbase-server in the patch failed.
-1 ❌	shadedjars	3m 16s	patch has 10 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 15s	hbase-server in the patch failed.
		14m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 05b8eb127ce7 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/testReport/
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-08T09:05:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	checkstyle	0m 33s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 24s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 14s	root in the patch failed.
-1 ❌	compile	0m 13s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 13s	hbase-server in the patch failed.
+1 💚	checkstyle	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	1m 14s	The patch causes 10 errors with Hadoop v3.2.4.
-1 ❌	hadoopcheck	2m 30s	The patch causes 10 errors with Hadoop v3.3.6.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 13s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		14m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 352f7c0d7c51 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-08T09:06:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	4m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 19s	root in the patch failed.
-1 ❌	compile	0m 17s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 17s	hbase-server in the patch failed.
-1 ❌	shadedjars	3m 19s	patch has 10 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 16s	hbase-server in the patch failed.
		15m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 271b3d38aa45 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/testReport/
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-08T09:51:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 35s	master passed
+1 💚	compile	2m 22s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	2m 21s	the patch passed
+1 💚	javac	2m 21s	the patch passed
+1 💚	checkstyle	0m 32s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 28s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	1m 32s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		30m 53s

Reason	Tests
FindBugs	module:hbase-server
	org.apache.hadoop.hbase.regionserver.RegionScannerLimiter.lambda$onConfigurationChange$1(Configuration, String) has Boolean return type and returns explicit null At RegionScannerLimiter.java:type and returns explicit null At RegionScannerLimiter.java:[line 123]

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux afe4fdaa3bd6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Eclipse Adoptium-11.0.17+8
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-08T10:11:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 13s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	4m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 15s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	4m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
-1 ❌	unit	33m 31s	hbase-server in the patch failed.
		51m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 89adc864e5c2 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/testReport/
Max. process+thread count	1679 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-08T10:17:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 12s	master passed
+1 💚	compile	0m 48s	master passed
+1 💚	shadedjars	4m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	4m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	37m 11s	hbase-server in the patch failed.
		57m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7633d49e6509 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `865a595`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/testReport/
Max. process+thread count	1976 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

zhuyaogai · 2023-11-06T10:04:46Z

Gentle ping @Apache9 If u have time, could u help review this? Thanks!

Apache9 · 2023-11-08T14:14:38Z

+ return false;
+ }
+
+ long countOfRowsFiltered = scannerContext.getMetrics().countOfRowsFiltered.incrementAndGet();


We'd better not mix things up with metrics? Metrics is not a critical thing usually.

Apache9 · 2023-11-08T14:33:50Z

 MORE_VALUES(true, false),
 NO_MORE_VALUES(false, false),
 SIZE_LIMIT_REACHED(true, true),
+ FILTERED_ROWS_LIMIT_REACHED(true, true),


Why not store the limit value in ScannerContext?

zhuyaogai · 2023-12-21T10:07:37Z

@Apache9 @bbeaudreault hi, I have made some code modifications, could you review code and provide some suggestions if you are available? Thanks!

Apache-HBase · 2023-12-21T10:50:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	3m 19s	master passed
+1 💚	checkstyle	0m 46s	master passed
+1 💚	spotless	0m 55s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 9s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 18s	the patch passed
+1 💚	compile	2m 58s	the patch passed
+1 💚	javac	2m 58s	the patch passed
+1 💚	checkstyle	0m 48s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 16s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 52s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	1m 52s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		39m 40s

Reason	Tests
FindBugs	module:hbase-server
	org.apache.hadoop.hbase.regionserver.RegionScannerLimiter.lambda$onConfigurationChange$1(Configuration, String) has Boolean return type and returns explicit null At RegionScannerLimiter.java:type and returns explicit null At RegionScannerLimiter.java:[line 123]

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c59bf33ab64c 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c07847`
Default Java	Eclipse Adoptium-11.0.17+8
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-21T11:06:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 37s	master passed
+1 💚	compile	0m 37s	master passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	shadedjars	5m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
-1 ❌	unit	36m 9s	hbase-server in the patch failed.
		55m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 39404c26428c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c07847`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/testReport/
Max. process+thread count	1942 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-21T11:17:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 32s	master passed
+1 💚	compile	0m 57s	master passed
+1 💚	shadedjars	6m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 30s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	shadedjars	6m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
-1 ❌	unit	41m 21s	hbase-server in the patch failed.
		65m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5428
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e9a37ca90de8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c07847`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/testReport/
Max. process+thread count	1974 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5428/8/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Limit max count of rows filtered per scan request.
4f1cca2

zhuyaogai force-pushed the issue-28107 branch from 1b49f38 to 4f1cca2Compare September 22, 2023 03:18

bbeaudreault reviewed Sep 22, 2023
View reviewed changes

Apache9 reviewed Sep 23, 2023
View reviewed changes

Limit max count of rows filtered per scan request.
40b60de

zhuyaogai requested review from Apache9 and bbeaudreault September 27, 2023 09:37

Limit max count of rows filtered per scan request.
8ac11d8

Limit max count of rows filtered per scan request.
8fa5678

Limit max count of rows filtered per scan request.
3f96c27

Limit max count of rows filtered per scan request.
d445f69

Apache9 reviewed Nov 8, 2023
View reviewed changes

Limit max count of rows filtered per scan request.
05afeae

zhuyaogai requested a review from Apache9 December 21, 2023 10:07

Uh oh!

Conversation

zhuyaogai commented Sep 22, 2023

Uh oh!

zhuyaogai commented Sep 22, 2023

Uh oh!

Apache-HBase commented Sep 22, 2023

Uh oh!

Apache-HBase commented Sep 22, 2023

Uh oh!

Apache-HBase commented Sep 22, 2023

Uh oh!

Apache-HBase commented Sep 22, 2023

Uh oh!

Apache-HBase commented Sep 22, 2023

Uh oh!

Apache-HBase commented Sep 22, 2023

Uh oh!

bbeaudreault left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9Sep 23, 2023

Choose a reason for hiding this comment

Uh oh!

zhuyaogaiSep 27, 2023

Choose a reason for hiding this comment

Uh oh!

Apache9Sep 23, 2023

Choose a reason for hiding this comment

Uh oh!

zhuyaogaiSep 27, 2023

Choose a reason for hiding this comment

Uh oh!

zhuyaogai commented Sep 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Sep 27, 2023

Uh oh!

bbeaudreault commented Sep 27, 2023

Uh oh!

Apache-HBase commented Sep 27, 2023

Uh oh!

Apache-HBase commented Sep 27, 2023

Uh oh!

zhuyaogai commented Sep 27, 2023

Uh oh!

Apache-HBase commented Sep 27, 2023

Uh oh!

Apache-HBase commented Sep 27, 2023

Uh oh!

Apache-HBase commented Sep 27, 2023

Uh oh!

zhuyaogai commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

Apache-HBase commented Oct 8, 2023

Uh oh!

zhuyaogai commented Nov 6, 2023

Uh oh!

Apache9Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

Apache9Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

zhuyaogai commented Sep 27, 2023•
edited
Loading