Uh oh!
There was an error while loading. Please reload this page.
HBASE-28101 Addendum do not throw EOFException out directly - #5431
Conversation
Apache-HBase
commented
Sep 23, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2023
🎊 +1 overall
This message was automatically generated. |
| Message.Builder builder = call.responseDefaultType.newBuilderForType(); | ||
| if (!builder.mergeDelimitedFrom(in)) { | ||
| // The javadoc of mergeDelimitedFrom says returning false means the stream reaches EOF | ||
| // before reading any bytes out, so here we need to manually throw the EOFException out |
There was a problem hiding this comment.
nit: now since we are not immediately throwing EOFException, maybe we should update this comment here as well
Apache-HBase
commented
Sep 23, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2023
💔 -1 overall
This message was automatically generated. |
260f9aa to
f2461c8CompareApache9
commented
Sep 24, 2023
The failed UTs are not related, all timeout and the failure UTs for jdk8 and jdk11 are different. Will merge once the last pre commit result is OK. Thanks @NihalJain for the quick reviewing~ |
Apache-HBase
commented
Sep 24, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 24, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 24, 2023
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 4b76a95)
Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 4b76a95)
Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 4b76a95)
Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 4b76a95)
No description provided.