Skip to content

HBASE-28135 Specify -Xms for tests - #5451

Merged
petersomogyi merged 3 commits into
apache:masterfrom
stoty:HBASE-28135
Oct 12, 2023
Merged

HBASE-28135 Specify -Xms for tests#5451
petersomogyi merged 3 commits into
apache:masterfrom
stoty:HBASE-28135

Conversation

@stoty

@stotystoty commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Change-Id: I45a17ac34b12aa00a04341413ac01dc70e5f328b

@stoty
HBASE-28135 Specify -Xms for tests
2c67cac
Change-Id: I45a17ac34b12aa00a04341413ac01dc70e5f328b
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache9

Apache9 commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Can we use surefire.Xms instead of a hard coded one?

@stoty
use property for Xms size
0a3ab27
Change-Id: Ie62e21432978ead6efd4100160f6faed8356ff17
@stoty

stoty commented Oct 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Sure, I have added the property.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

Apache-HBase commented Oct 6, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 46smaster passed
+1 💚compile6m 10smaster passed
+1 💚spotless0m 54sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 16sthe patch passed
+1 💚compile6m 9sthe patch passed
+1 💚javac6m 9sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚hadoopcheck13m 8sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 56spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
42m 48s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5451
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 3ff29a0e75e2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / eb24001
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 10, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 59smaster passed
+1 💚compile4m 44smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 40sthe patch passed
+1 💚compile4m 51sthe patch passed
+1 💚javac4m 51sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck9m 39sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
32m 32s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5451
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 02502ba0800b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f15ff5b
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count75 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi

petersomogyi commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

The pre-commit checks timed out for the second and third builds. Only the general checks completed which do not trigger unit tests.

@stoty
fix syntax error
38efda4
Change-Id: I0721e66493869aa597152c9eeeac96b9275b0485
@stoty

stoty commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

You are right, the variable substitutions were missing the dollar sign.

@Apache-HBase

Apache-HBase commented Oct 11, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 30smaster passed
+1 💚compile4m 39smaster passed
+1 💚spotless0m 39sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 32sthe patch passed
+1 💚compile4m 39sthe patch passed
+1 💚javac4m 39sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck9m 23sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
31m 32s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5451
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 14117978624f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d15d03
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count73 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 11, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 14smaster passed
+1 💚compile2m 40smaster passed
+1 💚shadedjars6m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 26smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 37sthe patch passed
+1 💚compile1m 57sthe patch passed
+1 💚javac1m 57sthe patch passed
+1 💚shadedjars4m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 54sthe patch passed
_ Other Tests _
+1 💚unit278m 13sroot in the patch passed.
311m 27s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5451
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b71757942341 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d15d03
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/testReport/
Max. process+thread count8094 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 11, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 14smaster passed
+1 💚compile1m 30smaster passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 16sthe patch passed
+1 💚compile1m 30sthe patch passed
+1 💚javac1m 30sthe patch passed
+1 💚shadedjars5m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21sthe patch passed
_ Other Tests _
+1 💚unit405m 38sroot in the patch passed.
432m 22s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5451
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ce8f2231d446 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0d15d03
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/testReport/
Max. process+thread count8444 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5451/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi
petersomogyi merged commit 2568222 into apache:masterOct 12, 2023
petersomogyi pushed a commit that referenced this pull request Oct 12, 2023
@stoty@petersomogyi
HBASE-28135Specify -Xms for tests (#5451)
e915e1c
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
petersomogyi pushed a commit that referenced this pull request Oct 12, 2023
@stoty@petersomogyi
HBASE-28135Specify -Xms for tests (#5451)
abdc8cf
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
petersomogyi pushed a commit that referenced this pull request Oct 12, 2023
@stoty@petersomogyi
HBASE-28135Specify -Xms for tests (#5451)
6a4a0b7
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
petersomogyi pushed a commit that referenced this pull request Oct 12, 2023
@stoty@petersomogyi
HBASE-28135Specify -Xms for tests (#5451)
212c7cb
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Nov 2, 2023
@stoty@wchevreuil
HBASE-28135 Specify -Xms for tests (apache#5451)
19187a3
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@stoty@petersomogyi
HBASE-28135 Specify -Xms for tests (apache#5451)
e1ffb6b
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit abdc8cf)
Change-Id: Ia2445bfb15fb37973e57bbcbbf74e16937dfc855
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyipetersomogyipetersomogyi approved these changes
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stoty@Apache-HBase@Apache9@petersomogyi