HBASE-28064:Implement truncate_region command by vaijosh · Pull Request #5462 · apache/hbase

vaijosh · 2023-10-16T12:03:36Z

HBASE-28064:Implement truncate_region command to truncate region directly from FS

Implemented truncate_region command and added unit/system tests.

Apache-HBase · 2023-10-16T13:00:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	4m 36s	master passed
+1 💚	checkstyle	1m 35s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 22s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	4m 35s	the patch passed
+1 💚	cc	4m 35s	the patch passed
+1 💚	javac	4m 35s	the patch passed
-0 ⚠️	checkstyle	0m 16s	hbase-client: The patch generated 8 new + 4 unchanged - 0 fixed = 12 total (was 4)
-0 ⚠️	checkstyle	0m 35s	hbase-server: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)
-0 ⚠️	rubocop	0m 10s	The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 13s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 55s	the patch passed
-1 ❌	spotless	0m 19s	patch has 63 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	5m 57s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 48s	The patch does not generate ASF License warnings.
		49m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 74972bea0cfb 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-16T16:30:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 27s	master passed
+1 💚	compile	1m 46s	master passed
+1 💚	shadedjars	5m 12s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	1m 44s	the patch passed
+1 💚	javac	1m 44s	the patch passed
+1 💚	shadedjars	5m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 26s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 20s	hbase-client in the patch passed.
-1 ❌	unit	217m 23s	hbase-server in the patch failed.
+1 💚	unit	6m 45s	hbase-thrift in the patch passed.
+1 💚	unit	7m 41s	hbase-shell in the patch passed.
		260m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6f953eec680d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/testReport/
Max. process+thread count	4603 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-16T16:42:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	shadedjars	4m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	shadedjars	4m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 29s	hbase-client in the patch passed.
-1 ❌	unit	225m 2s	hbase-server in the patch failed.
+1 💚	unit	8m 46s	hbase-thrift in the patch passed.
+1 💚	unit	7m 4s	hbase-shell in the patch passed.
		272m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4de732e8260b 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/testReport/
Max. process+thread count	4271 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-16T17:34:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 41s	master passed
+1 💚	compile	4m 34s	master passed
+1 💚	checkstyle	1m 34s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 22s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	4m 35s	the patch passed
+1 💚	cc	4m 35s	the patch passed
+1 💚	javac	4m 35s	the patch passed
+1 💚	checkstyle	1m 33s	the patch passed
-0 ⚠️	rubocop	0m 11s	The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 8s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 54s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		49m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux ecff407a0924 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-16T21:04:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 14s	master passed
+1 💚	compile	1m 47s	master passed
+1 💚	shadedjars	5m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	1m 47s	the patch passed
+1 💚	javac	1m 47s	the patch passed
+1 💚	shadedjars	5m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 25s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
-1 ❌	unit	217m 47s	hbase-server in the patch failed.
+1 💚	unit	6m 33s	hbase-thrift in the patch passed.
+1 💚	unit	7m 42s	hbase-shell in the patch passed.
		260m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5128cba3b006 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/testReport/
Max. process+thread count	4595 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-16T21:17:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 48s	master passed
+1 💚	compile	2m 25s	master passed
+1 💚	shadedjars	4m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	4m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 33s	hbase-client in the patch passed.
-1 ❌	unit	224m 18s	hbase-server in the patch failed.
+1 💚	unit	8m 30s	hbase-thrift in the patch passed.
+1 💚	unit	7m 44s	hbase-shell in the patch passed.
		272m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f5705fc5cb1b 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/testReport/
Max. process+thread count	4594 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-17T03:08:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 52s	master passed
+1 💚	compile	5m 36s	master passed
+1 💚	checkstyle	1m 32s	master passed
+1 💚	spotless	0m 56s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 13s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 5s	the patch passed
+1 💚	compile	7m 46s	the patch passed
+1 💚	cc	7m 46s	the patch passed
+1 💚	javac	7m 46s	the patch passed
+1 💚	checkstyle	2m 30s	the patch passed
-0 ⚠️	rubocop	0m 18s	The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 16s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	3m 3s	the patch passed
+1 💚	spotless	1m 17s	patch has no errors when running spotless:check.
+1 💚	spotbugs	9m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 59s	The patch does not generate ASF License warnings.
		72m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux a6ba8bf3d82b 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-17T06:20:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 37s	master passed
+1 💚	compile	2m 23s	master passed
+1 💚	shadedjars	4m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	shadedjars	4m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 29s	hbase-client in the patch passed.
-1 ❌	unit	218m 43s	hbase-server in the patch failed.
+1 💚	unit	8m 34s	hbase-thrift in the patch passed.
+1 💚	unit	7m 4s	hbase-shell in the patch passed.
		265m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1b5f3089cbd8 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/testReport/
Max. process+thread count	4248 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-17T06:27:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 43s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	shadedjars	6m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 40s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 44s	the patch passed
+1 💚	compile	2m 13s	the patch passed
+1 💚	javac	2m 13s	the patch passed
+1 💚	shadedjars	5m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 27s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 28s	hbase-client in the patch passed.
-1 ❌	unit	223m 21s	hbase-server in the patch failed.
+1 💚	unit	6m 37s	hbase-thrift in the patch passed.
+1 💚	unit	7m 41s	hbase-shell in the patch passed.
		271m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6d9597def5b8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/testReport/
Max. process+thread count	4632 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

vaijosh · 2023-10-17T08:51:13Z

recheck

vaijosh · 2023-10-17T13:04:00Z

retest

vaijosh · 2023-10-17T13:05:21Z

The failed tests is not looking related to my changes. Not sure if its a transient issue.

wchevreuil · 2023-10-17T10:51:47Z

+ final MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();
+ final Path tableDir = CommonFSUtils.getTableDir(mfs.getRootDir(), getTableName());
+ final Configuration conf = env.getMasterConfiguration();
+ HRegionFileSystem.deleteRegionFromFileSystem(conf, mfs.getFileSystem(), tableDir, region);


This would delete the region dir entirely. I don't see where we recreate the region dir, later. Isn't this a problem?

This would delete the region dir entirely. I don't see where we recreate the region dir, later. Isn't this a problem?
While developing feature, I observed that subsequent task "TRUNCATE_REGION_MAKE_ONLINE" creates directory for region. So not added logic to create the directory explicitely.

Thanks for pointing that. Yeah, that should be ok. Just one extra comment on the rollback: I see you are considering it only if we are in TRUNCATE_REGION_PRE_OPERATION. Couldn't we rollback from TRUNCATE_REGION_MAKE_OFFLINE too?

Thanks for pointing that. Yeah, that should be ok. Just one extra comment on the rollback: I see you are considering it only if we are in TRUNCATE_REGION_PRE_OPERATION. Couldn't we rollback from TRUNCATE_REGION_MAKE_OFFLINE too?
Thanks @wchevreuil. This is valid concern. I this its already handled here

Thanks for pointing it out!

wchevreuil · 2023-10-17T13:21:37Z

Thanks for submitting this PR, looks like a great idea. I have a few questions/comments after an initial review. Please reply on those so that we can get this progressing. Thanks, Wellington.

vaijosh · 2023-10-18T12:07:56Z

Thanks for submitting this PR, looks like a great idea. I have a few questions/comments after an initial review. Please reply on those so that we can get this progressing. Thanks, Wellington.

Thanks @wchevreuil for reviewing this. I have incorporated most of the review comments and answered the questions inline. Can you please check?

Apache-HBase · 2023-10-18T12:44:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	4m 35s	master passed
+1 💚	checkstyle	1m 31s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	4m 35s	the patch passed
+1 💚	cc	4m 35s	the patch passed
+1 💚	javac	4m 35s	the patch passed
+1 💚	checkstyle	1m 27s	the patch passed
-0 ⚠️	rubocop	0m 11s	The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 6s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 54s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 54s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		49m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux b9e338718004 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-18T16:26:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	2m 24s	master passed
+1 💚	shadedjars	4m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	shadedjars	4m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 31s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 39s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 28s	hbase-client in the patch passed.
-1 ❌	unit	224m 43s	hbase-server in the patch failed.
+1 💚	unit	8m 35s	hbase-thrift in the patch passed.
+1 💚	unit	7m 5s	hbase-shell in the patch passed.
		271m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d76a42a61e05 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/testReport/
Max. process+thread count	4226 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-18T17:25:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 24s	master passed
+1 💚	compile	2m 46s	master passed
+1 💚	shadedjars	7m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 14s	the patch passed
+1 💚	compile	2m 40s	the patch passed
+1 💚	javac	2m 40s	the patch passed
+1 💚	shadedjars	7m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 43s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 51s	hbase-client in the patch passed.
-1 ❌	unit	276m 59s	hbase-server in the patch failed.
+1 💚	unit	7m 2s	hbase-thrift in the patch passed.
+1 💚	unit	7m 44s	hbase-shell in the patch passed.
		329m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6da886e71ad5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `391dfda`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/testReport/
Max. process+thread count	4619 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil

LGTM, +1. The UT failures looks unrelated.

NihalJain · 2023-10-19T21:56:39Z

Thanks @vaijosh for working on this. Sorry for late review. I have added a few comments/suggestions. Please check.

vaijosh · 2023-10-20T06:52:38Z

Thanks @vaijosh for working on this. Sorry for late review. I have added a few comments/suggestions. Please check.
Thanks @NihalJain for the suggestions.
Yes I will address your few review comments in the next commit. I have replied to some of the review comments, which I felt are not addressable. Can you please take a look and let me know if I am missing some thing?

…ctly from FS Implemented truncate_region command.

Apache-HBase · 2023-10-20T08:59:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 28s	master passed
+1 💚	compile	6m 58s	master passed
+1 💚	checkstyle	1m 49s	master passed
+1 💚	spotless	0m 48s	branch has no errors when running spotless:check.
+1 💚	spotbugs	6m 46s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	6m 11s	the patch passed
+1 💚	cc	6m 11s	the patch passed
+1 💚	javac	6m 11s	the patch passed
-0 ⚠️	checkstyle	0m 43s	hbase-server: The patch generated 10 new + 8 unchanged - 0 fixed = 18 total (was 8)
-0 ⚠️	rubocop	0m 15s	The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 26s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	2m 7s	the patch passed
-1 ❌	spotless	0m 44s	patch has 63 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	7m 24s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 41s	The patch does not generate ASF License warnings.
		64m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 418b9a22cf39 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dde504c`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2023-10-20T10:04:49Z

Skimmed latest push and updated comments. Looks fine high level.

Also one suggestion, please avoid force push and keep just 1 commit. It's very hard to review what all changed. We anyways squash and merge, so should be fine to have several commits.

Apache-HBase · 2023-10-20T12:49:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 38s	master passed
+1 💚	compile	2m 49s	master passed
+1 💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	3m 2s	the patch passed
+1 💚	javac	3m 2s	the patch passed
+1 💚	shadedjars	6m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 56s	hbase-client in the patch passed.
-1 ❌	unit	242m 57s	hbase-server in the patch failed.
+1 💚	unit	6m 59s	hbase-thrift in the patch passed.
+1 💚	unit	9m 19s	hbase-shell in the patch passed.
		293m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 17d1141db998 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dde504c`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/testReport/
Max. process+thread count	4706 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-20T12:51:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	2m 18s	master passed
+1 💚	shadedjars	6m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	1m 52s	the patch passed
+1 💚	javac	1m 52s	the patch passed
+1 💚	shadedjars	6m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 38s	hbase-client in the patch passed.
-1 ❌	unit	248m 24s	hbase-server in the patch failed.
+1 💚	unit	7m 5s	hbase-thrift in the patch passed.
+1 💚	unit	8m 9s	hbase-shell in the patch passed.
		295m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a9827d1d7e0e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dde504c`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/testReport/
Max. process+thread count	4492 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-20T13:52:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 28s	master passed
+1 💚	compile	5m 24s	master passed
+1 💚	checkstyle	1m 46s	master passed
+1 💚	spotless	0m 53s	branch has no errors when running spotless:check.
+1 💚	spotbugs	6m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	5m 41s	the patch passed
+1 💚	cc	5m 41s	the patch passed
+1 💚	javac	5m 41s	the patch passed
+1 💚	checkstyle	1m 38s	the patch passed
-0 ⚠️	rubocop	0m 15s	The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 18s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	2m 7s	the patch passed
+1 💚	spotless	0m 52s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 20s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		58m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 733700d6b4c7 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dde504c`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	87 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-20T17:37:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	shadedjars	5m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	2m 14s	the patch passed
+1 💚	javac	2m 14s	the patch passed
+1 💚	shadedjars	6m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 39s	hbase-client in the patch passed.
-1 ❌	unit	235m 56s	hbase-server in the patch failed.
+1 💚	unit	7m 6s	hbase-thrift in the patch passed.
+1 💚	unit	7m 48s	hbase-shell in the patch passed.
		284m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7ddefd07bc91 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dde504c`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/testReport/
Max. process+thread count	4510 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-20T17:45:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 2s	master passed
+1 💚	compile	2m 37s	master passed
+1 💚	shadedjars	5m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 11s	the patch passed
+1 💚	compile	2m 30s	the patch passed
+1 💚	javac	2m 30s	the patch passed
+1 💚	shadedjars	5m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 41s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 55s	hbase-client in the patch passed.
+1 💚	unit	243m 8s	hbase-server in the patch passed.
+1 💚	unit	6m 45s	hbase-thrift in the patch passed.
+1 💚	unit	7m 53s	hbase-shell in the patch passed.
		292m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b4bc7777d386 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dde504c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/testReport/
Max. process+thread count	4715 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

vaijosh · 2023-10-21T04:51:12Z

Skimmed latest push and updated comments. Looks fine high level.
Also one suggestion, please avoid force push and keep just 1 commit. It's very hard to review what all changed. We anyways squash and merge, so should be fine to have several commits.

Thanks @NihalJain for the suggestion.
I was more following "amend commit" workflow (similar to Gerrit). I was under impression that recent changes can be checked using compare link next to commit e.g. this.

But if this is not convenient, next time onwards I can do separate commits, and we can squash commits in the end.

NihalJain · 2023-10-21T05:17:35Z

But if this is not convenient, next time onwards I can do separate commits, and we can squash commits in the end.

Yes it is a little inconvenient to compare across previous commits. And thanks for considering this.

I have approved the PR. Looks good to me, please check once on users field comment before commit.

vaijosh · 2023-10-21T06:18:57Z

Hi @NihalJain
Thanks a lot for approving the PR.

please check once on users field comment before commit.

Yes this was valid concern. But I have simulated and tested crash scenario and checked that we don't get NPE.
1.Started Hbase in debug mode
2.Kept breakpoint in TRUNCATE_REGION_MAKE_OFFLINE block.
3.Executed truncate_region command.
4.When breakpoint was hit, killed the hbase processes using kill -9 command.
5.Kept break points in AbstractStateMachineRegionProcedure.deserializeStateData and AbstractStateMachineTableProcedure constructor.
6.Started hbase in debugger mode and attached debugger. Verified that breakpoints were hit and "region" and "user" fields were populated correctly. Also verified that truncate operation was resumed from the state and eventually it was successful.

NihalJain · 2023-10-21T06:37:27Z

Awesome thanks for the due diligence and again thanks for working on this one. :)

…ctly from FS Implemented review comment.

Apache-HBase · 2023-10-21T09:30:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 39s	master passed
+1 💚	compile	4m 35s	master passed
+1 💚	checkstyle	1m 36s	master passed
-1 ❌	spotless	0m 42s	branch has 1 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	5m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	4m 37s	the patch passed
+1 💚	cc	4m 37s	the patch passed
+1 💚	javac	4m 37s	the patch passed
+1 💚	checkstyle	1m 32s	the patch passed
-0 ⚠️	rubocop	0m 11s	The patch generated 8 new + 766 unchanged - 0 fixed = 774 total (was 766)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 13s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 55s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 57s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 44s	The patch does not generate ASF License warnings.
		50m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux d91bc9c9f138 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4b70e59`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-general-check/output/branch-spotless.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-21T13:04:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	1m 47s	master passed
+1 💚	shadedjars	5m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s	the patch passed
+1 💚	compile	1m 47s	the patch passed
+1 💚	javac	1m 47s	the patch passed
+1 💚	shadedjars	5m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 25s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
-1 ❌	unit	221m 11s	hbase-server in the patch failed.
+1 💚	unit	6m 52s	hbase-thrift in the patch passed.
+1 💚	unit	7m 43s	hbase-shell in the patch passed.
		264m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fd2daff02679 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4b70e59`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/testReport/
Max. process+thread count	4611 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-10-21T13:50:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	shadedjars	4m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	2m 22s	the patch passed
+1 💚	javac	2m 22s	the patch passed
+1 💚	shadedjars	5m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 44s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	2m 11s	hbase-client in the patch passed.
+1 💚	unit	261m 5s	hbase-server in the patch passed.
+1 💚	unit	8m 50s	hbase-thrift in the patch passed.
+1 💚	unit	7m 17s	hbase-shell in the patch passed.
		310m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5462
JIRA Issue	HBASE-28064
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7c7fdad00c13 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4b70e59`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/testReport/
Max. process+thread count	4293 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5462/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

vaijosh force-pushed the HBASE-28064TruncateRegionCommand branch from 0d2c228 to 3bc82c7Compare October 16, 2023 13:37

ankitsinghal requested review from ankitsinghal, meszibalu, petersomogyi and wchevreuil October 16, 2023 20:11

vaijosh force-pushed the HBASE-28064TruncateRegionCommand branch from 3bc82c7 to 2a6ae93Compare October 17, 2023 01:53

wchevreuil requested changes Oct 17, 2023
View reviewed changes

vaijosh force-pushed the HBASE-28064TruncateRegionCommand branch from 2a6ae93 to 523e4f9Compare October 18, 2023 11:54

vaijosh requested a review from wchevreuil October 18, 2023 12:08

wchevreuil approved these changes Oct 19, 2023
View reviewed changes

NihalJain requested changes Oct 19, 2023
View reviewed changes

vaijosh force-pushed the HBASE-28064TruncateRegionCommand branch from 523e4f9 to 3366b2aCompare October 20, 2023 07:50

HBASE-28064:Implement truncate_region command to truncate region dire…
07c871e
…ctly from FS Implemented truncate_region command.

vaijosh force-pushed the HBASE-28064TruncateRegionCommand branch from 3366b2a to 07c871eCompare October 20, 2023 08:39

NihalJain reviewed Oct 20, 2023
View reviewed changes

Comment thread...e-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateRegionProcedure.java

vaijosh requested a review from NihalJain October 21, 2023 05:06

NihalJain approved these changes Oct 21, 2023
View reviewed changes

HBASE-28064:Implement truncate_region command to truncate region dire…
3cde2fc
…ctly from FS Implemented review comment.

NihalJain approved these changes Oct 21, 2023
View reviewed changes

wchevreuil merged commit 91ac8ab into apache:masterOct 23, 2023

wchevreuil pushed a commit that referenced this pull request Oct 23, 2023
HBASE-28064:Implement truncate_region command (#5462)
32cddea
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

vaijosh added a commit to vaijosh/hbase that referenced this pull request Oct 26, 2023
HBASE-28064:Implement truncate_region command (apache#5462)
f3c8c04
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

vaijosh added a commit to vaijosh/hbase that referenced this pull request Oct 26, 2023
HBASE-28064:Implement truncate_region command (apache#5462)
e2a0784
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

nikita15p pushed a commit to nikita15p/hbase that referenced this pull request Oct 29, 2023
HBASE-28064:Implement truncate_region command (apache#5462)
72ca3ec
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Nov 2, 2023
HBASE-28064:Implement truncate_region command (apache#5462)
ed4e3d3
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

Uh oh!

Conversation

vaijosh commented Oct 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Oct 16, 2023

Uh oh!

Apache-HBase commented Oct 16, 2023

Uh oh!

Apache-HBase commented Oct 16, 2023

Uh oh!

Apache-HBase commented Oct 16, 2023

Uh oh!

Apache-HBase commented Oct 16, 2023

Uh oh!

Apache-HBase commented Oct 16, 2023

Uh oh!

Apache-HBase commented Oct 17, 2023

Uh oh!

Apache-HBase commented Oct 17, 2023

Uh oh!

Apache-HBase commented Oct 17, 2023

Uh oh!

vaijosh commented Oct 17, 2023

Uh oh!

vaijosh commented Oct 17, 2023

Uh oh!

vaijosh commented Oct 17, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wchevreuilOct 17, 2023

Choose a reason for hiding this comment

Uh oh!

vaijoshOct 18, 2023

Choose a reason for hiding this comment

Uh oh!

wchevreuilOct 19, 2023

Choose a reason for hiding this comment

Uh oh!

vaijoshOct 19, 2023

Choose a reason for hiding this comment

Uh oh!

wchevreuilOct 19, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wchevreuil commented Oct 17, 2023

Uh oh!

vaijosh commented Oct 18, 2023

Uh oh!

Apache-HBase commented Oct 18, 2023

Uh oh!

Apache-HBase commented Oct 18, 2023

Uh oh!

Apache-HBase commented Oct 18, 2023

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NihalJain commented Oct 19, 2023

Uh oh!

vaijosh commented Oct 20, 2023

Uh oh!

Apache-HBase commented Oct 20, 2023

vaijosh commented Oct 16, 2023•
edited
Loading

NihalJain commented Oct 21, 2023•
edited
Loading

vaijosh commented Oct 21, 2023•
edited
Loading