Skip to content

HBASE-28120 Switch that allows avoiding reopening all regions when altering table - #5482

Closed
gourabtaparia wants to merge 4 commits into
apache:branch-2from
gourabtaparia:branch-2-reopenRegion
Closed

HBASE-28120 Switch that allows avoiding reopening all regions when altering table#5482
gourabtaparia wants to merge 4 commits into
apache:branch-2from
gourabtaparia:branch-2-reopenRegion

Conversation

@gourabtaparia

@gourabtapariagourabtaparia commented Oct 27, 2023

Copy link
Copy Markdown
  • This is to prevent RIT storms.
  • The changes have been made in both alter and alter sync commands.

@Apache-HBase

Apache-HBase commented Oct 27, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for branch
+1 💚mvninstall3m 12sbranch-2 passed
+1 💚compile5m 52sbranch-2 passed
+1 💚checkstyle1m 49sbranch-2 passed
+1 💚spotless0m 52sbranch has no errors when running spotless:check.
+1 💚spotbugs6m 15sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 14sthe patch passed
+1 💚compile5m 4sthe patch passed
+1 💚cc5m 4sthe patch passed
+1 💚javac5m 4sthe patch passed
-0 ⚠️checkstyle0m 20shbase-client: The patch generated 3 new + 11 unchanged - 0 fixed = 14 total (was 11)
-0 ⚠️checkstyle0m 40shbase-server: The patch generated 3 new + 9 unchanged - 0 fixed = 12 total (was 9)
-0 ⚠️rubocop0m 12sThe patch generated 9 new + 419 unchanged - 5 fixed = 428 total (was 424)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 31sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚hbaseprotoc2m 36sthe patch passed
-1 ❌spotless0m 23spatch has 65 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs7m 46sthe patch passed
_ Other Tests _
+1 💚asflicense0m 54sThe patch does not generate ASF License warnings.
59m 16s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5482
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 0e1a673f6d6c 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 27, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 27sbranch-2 passed
+1 💚compile1m 44sbranch-2 passed
+1 💚shadedjars4m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 8sthe patch passed
+1 💚compile1m 47sthe patch passed
+1 💚javac1m 47sthe patch passed
+1 💚shadedjars4m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9sthe patch passed
_ Other Tests _
+1 💚unit0m 23shbase-protocol-shaded in the patch passed.
+1 💚unit7m 48shbase-client in the patch passed.
+1 💚unit205m 18shbase-server in the patch passed.
+1 💚unit6m 54shbase-thrift in the patch passed.
+1 💚unit7m 39shbase-shell in the patch passed.
254m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5482
Optional Testsjavac javadoc unit shadedjars compile
unameLinux dfbd08ad8056 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/testReport/
Max. process+thread count4591 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 27, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 15sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 46sbranch-2 passed
+1 💚compile2m 23sbranch-2 passed
+1 💚shadedjars4m 54sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 36sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile2m 22sthe patch passed
+1 💚javac2m 22sthe patch passed
+1 💚shadedjars4m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 32sthe patch passed
_ Other Tests _
+1 💚unit0m 35shbase-protocol-shaded in the patch passed.
+1 💚unit8m 25shbase-client in the patch passed.
+1 💚unit210m 28shbase-server in the patch passed.
+1 💚unit7m 7shbase-thrift in the patch passed.
+1 💚unit9m 25shbase-shell in the patch passed.
265m 1s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5482
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 504b62217693 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/testReport/
Max. process+thread count4526 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 30, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 50sbranch-2 passed
+1 💚compile4m 43sbranch-2 passed
+1 💚checkstyle1m 39sbranch-2 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 18sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 36sthe patch passed
+1 💚compile4m 43sthe patch passed
+1 💚cc4m 43sthe patch passed
+1 💚javac4m 43sthe patch passed
-0 ⚠️checkstyle0m 36shbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️rubocop0m 10sThe patch generated 10 new + 419 unchanged - 5 fixed = 429 total (was 424)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 29sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚hbaseprotoc1m 53sthe patch passed
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs5m 49sthe patch passed
_ Other Tests _
+1 💚asflicense0m 50sThe patch does not generate ASF License warnings.
50m 31s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5482
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux ad92df725f4d 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Oct 30, 2023
View reviewed changes
Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java Outdated
Comment on lines +1532 to +1539
@Deprecated
default void modifyTable(TableName tableName, TableDescriptor td, boolean reopenRegions)
throws IOException {
if (!tableName.equals(td.getTableName())) {
throw new IllegalArgumentException("the specified table name '" + tableName
+ "' doesn't match with the HTD one: " + td.getTableName());
}
modifyTable(td, reopenRegions);

@wchevreuilwchevreuilOct 30, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add a new method already marked as deprecated?

@gourabtapariagourabtapariaOct 31, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wchevreuil The existing deprecated method needs to be passed an extra argument from, hence added this - but I see that i can reuse the logic in the existing method, and just call that from this method.

Btw, in my local refactoring, i now am not even calling this method - and directly making use of the "modifyTableAsync(TableDescriptor td, boolean reopenRegions)" method - so i can remove this altogether.

let me make that change. Thanks

@Apache-HBase

Apache-HBase commented Oct 30, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 39sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 24sbranch-2 passed
+1 💚compile2m 3sbranch-2 passed
+1 💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 12sthe patch passed
+1 💚compile2m 3sthe patch passed
+1 💚javac2m 3sthe patch passed
+1 💚shadedjars4m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21sthe patch passed
_ Other Tests _
+1 💚unit0m 28shbase-protocol-shaded in the patch passed.
+1 💚unit7m 57shbase-client in the patch passed.
+1 💚unit220m 11shbase-server in the patch passed.
+1 💚unit7m 45shbase-thrift in the patch passed.
+1 💚unit7m 1shbase-shell in the patch passed.
273m 23s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5482
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a7318fbf6d51 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/testReport/
Max. process+thread count4853 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 30, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 49sbranch-2 passed
+1 💚compile2m 21sbranch-2 passed
+1 💚shadedjars4m 56sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 36sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 39sthe patch passed
+1 💚compile2m 23sthe patch passed
+1 💚javac2m 23sthe patch passed
+1 💚shadedjars4m 56spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-protocol-shaded in the patch passed.
+1 💚unit7m 28shbase-client in the patch passed.
+1 💚unit221m 24shbase-server in the patch passed.
+1 💚unit8m 45shbase-thrift in the patch passed.
+1 💚unit7m 7shbase-shell in the patch passed.
274m 42s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5482
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 643e14923839 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/testReport/
Max. process+thread count4767 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 31, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 34sbranch-2 passed
+1 💚compile4m 47sbranch-2 passed
+1 💚checkstyle1m 35sbranch-2 passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 13sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 37sthe patch passed
+1 💚compile4m 43sthe patch passed
+1 💚cc4m 43sthe patch passed
+1 💚javac4m 43sthe patch passed
-0 ⚠️checkstyle0m 37shbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️rubocop0m 8sThe patch generated 10 new + 419 unchanged - 5 fixed = 429 total (was 424)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 21sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚hbaseprotoc1m 53sthe patch passed
+1 💚spotless0m 43spatch has no errors when running spotless:check.
+1 💚spotbugs5m 54sthe patch passed
_ Other Tests _
+1 💚asflicense0m 49sThe patch does not generate ASF License warnings.
49m 52s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5482
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux f701707aa208 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 31, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 29sbranch-2 passed
+1 💚compile1m 47sbranch-2 passed
+1 💚shadedjars5m 4sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 13sthe patch passed
+1 💚compile1m 52sthe patch passed
+1 💚javac1m 52sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 24shbase-protocol-shaded in the patch passed.
+1 💚unit7m 54shbase-client in the patch passed.
+1 💚unit211m 38shbase-server in the patch passed.
+1 💚unit6m 42shbase-thrift in the patch passed.
+1 💚unit7m 47shbase-shell in the patch passed.
261m 7s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5482
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b87c318ee715 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/testReport/
Max. process+thread count4520 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 31, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 16sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 53sbranch-2 passed
+1 💚compile2m 22sbranch-2 passed
+1 💚shadedjars4m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall2m 35sthe patch passed
+1 💚compile2m 22sthe patch passed
+1 💚javac2m 22sthe patch passed
+1 💚shadedjars4m 55spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35sthe patch passed
_ Other Tests _
+1 💚unit0m 35shbase-protocol-shaded in the patch passed.
+1 💚unit8m 26shbase-client in the patch passed.
+1 💚unit208m 54shbase-server in the patch passed.
+1 💚unit7m 10shbase-thrift in the patch passed.
+1 💚unit9m 16shbase-shell in the patch passed.
263m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5482
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 11df3c444e7f 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f3e63e
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/testReport/
Max. process+thread count4407 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil

wchevreuil commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Closing this, as it was decided to cherry-pick HBASE-25549 into branch-2.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gourabtaparia@Apache-HBase@wchevreuil