Uh oh!
There was an error while loading. Please reload this page.
HBASE-28182 Create ref files using threadpool as part of merge - #5487
Open
gvprathyusha6 wants to merge 1 commit into
Open
HBASE-28182 Create ref files using threadpool as part of merge#5487gvprathyusha6 wants to merge 1 commit into
gvprathyusha6 wants to merge 1 commit into
Conversation
Apache-HBase
commented
Oct 31, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 31, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 31, 2023
🎊 +1 overall
This message was automatically generated. |
wchevreuil
left a comment
Contributor
There was a problem hiding this comment.
Please target changes on master branch first.
Comment on lines
+591
to
+638
| Configuration conf = env.getMasterConfiguration(); | ||
| int numOfThreads = conf.getInt(HConstants.REGION_SPLIT_THREADS_MAX, | ||
| conf.getInt(HStore.BLOCKING_STOREFILES_KEY, HStore.DEFAULT_BLOCKING_STOREFILE_COUNT)); | ||
| List<Path> mergedFiles = new ArrayList<Path>(); | ||
| final ExecutorService threadPool = Executors.newFixedThreadPool(numOfThreads, | ||
| new ThreadFactoryBuilder().setNameFormat("StoreFileMerge-pool-%d").setDaemon(true) | ||
| .setUncaughtExceptionHandler(Threads.LOGGING_EXCEPTION_HANDLER).build()); | ||
| final List<Future<Path>> futures = new ArrayList<Future<Path>>(); | ||
| for (RegionInfo ri : this.regionsToMerge) { | ||
| HRegionFileSystem regionFs = HRegionFileSystem | ||
| .openRegionFromFileSystem(env.getMasterConfiguration(), fs, tableDir, ri, false); | ||
| mergedFiles.addAll(mergeStoreFiles(env, regionFs, mergeRegionFs, mergedRegion)); | ||
| mergeStoreFiles(env, regionFs, mergeRegionFs, mergedRegion, threadPool, futures); | ||
| } | ||
| // Shutdown the pool | ||
| threadPool.shutdown(); | ||
| // Wait for all the tasks to finish. | ||
| // When splits ran on the RegionServer, how-long-to-wait-configuration was named | ||
| // hbase.regionserver.fileSplitTimeout. If set, use its value. | ||
| long fileSplitTimeout = conf.getLong("hbase.master.fileSplitTimeout", | ||
| conf.getLong("hbase.regionserver.fileSplitTimeout", 600000)); | ||
| try { | ||
| boolean stillRunning = !threadPool.awaitTermination(fileSplitTimeout, TimeUnit.MILLISECONDS); | ||
| if (stillRunning) { | ||
| threadPool.shutdownNow(); | ||
| // wait for the thread to shutdown completely. | ||
| while (!threadPool.isTerminated()) { | ||
| Thread.sleep(50); | ||
| } | ||
| throw new IOException( | ||
| "Took too long to merge the" + " files and create the references, aborting merge"); | ||
| } | ||
| } catch (InterruptedException e) { | ||
| throw (InterruptedIOException) new InterruptedIOException().initCause(e); | ||
| } | ||
| for (Future<Path> future : futures) { | ||
| try { | ||
| Path path = future.get(); | ||
| if (path != null) { | ||
| mergedFiles.add(path); | ||
| } | ||
| } catch (InterruptedException e) { | ||
| throw (InterruptedIOException) new InterruptedIOException().initCause(e); | ||
| } catch (ExecutionException e) { | ||
| throw new IOException(e); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This whole block shows lots of duplication with SplitTableRegionProcedure. We should put what's reusable in a common method.
ContributorAuthor
There was a problem hiding this comment.
@wchevreuil
Moved common code to a Util file, will it be better to move that to hbase-common module instead of hbase-server?, there is one ThreadUtil class in hadoop-common, should I be using that instead? thoughts?
gvprathyusha6force-pushed
the
HBASE-28182
branch
from
December 28, 2023 06:30
2c881f6 to
85cf598Comparegvprathyusha6
marked this pull request as ready for review
December 28, 2023 06:31
Apache-HBase
commented
Dec 28, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 28, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 28, 2023
💔 -1 overall
This message was automatically generated. |
gvprathyusha6force-pushed
the
HBASE-28182
branch
from
January 1, 2024 12:42
85cf598 to
7cdeadfCompareApache-HBase
commented
Jan 1, 2024
💔 -1 overall
This message was automatically generated. |
gvprathyusha6force-pushed
the
HBASE-28182
branch
from
January 1, 2024 13:36
7cdeadf to
dfbe19cCompareApache-HBase
commented
Jan 1, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 1, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 1, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 1, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 1, 2024
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.