Uh oh!
There was an error while loading. Please reload this page.
HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign - #5493
Conversation
Apache-HBase
commented
Nov 2, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 2, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 2, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 2, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 2, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 2, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 2, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 2, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 2, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 3, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 3, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 3, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 3, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 3, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 3, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 13, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 13, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 13, 2023
💔 -1 overall
This message was automatically generated. |
rahulLiving
commented
Nov 14, 2023
Test failure seems unrealted to the change |
Apache-HBase
commented
Nov 14, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 14, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 14, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 14, 2023
🎊 +1 overall
This message was automatically generated. |
apurtell
left a comment
There was a problem hiding this comment.
I'm not a fan of forceOverride. I would prefer it named something like force and in the javadoc and hbck docs explain it as "force skips any pre flight checks that would otherwise prevent the operation". This is a relatively minor detail and perhaps reasonable people can disagree. Giving my approval for the functional changes. Please do consider the naming update before committing this.
virajjasani
commented
Dec 14, 2023
I wonder if we should make changes the other way around i.e. first make the changes in hbase-operator-tools by adding new option, documenting it and only when operator-tools bumps hbase version, we can commit this change here? |
rahulLiving
commented
Dec 15, 2023
Adding an option in |
virajjasani
commented
Dec 15, 2023
Oh right, that won't work. |
rvaleti
commented
Dec 15, 2023
@rahulLiving This API change would break old operator-tools's hbck2. Please make sure it is backward compatible. |
rvaleti
left a comment
There was a problem hiding this comment.
@rahulLiving This API change would break old operator-tools's hbck2. Please make sure it is backward compatible.
Apache-HBase
commented
Dec 19, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 19, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 19, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 20, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 20, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 20, 2023
🎊 +1 overall
This message was automatically generated. |
rahulLiving
commented
Dec 21, 2023
@rvaleti@virajjasani I have updated the PR to keep backward compatibility i.e default is |
rahulLiving
commented
Jan 19, 2024
@virajjasani@apurtell Can you please help with the merge |
virajjasani
left a comment
There was a problem hiding this comment.
Changes seem good at high level as force is enabled by default, unless there is any objection, let's get this merged sometime next week.
virajjasani
commented
Jan 19, 2024
Though now i am convinced that we usually do need to bypass transit state checks almost majority of the times when we have to use hbck in prod :) |
Jira: HBASE-28151