Skip to content

HBASE-25292 [branch-2.4] Improve InetSocketAddress usage discipline - #5515

Merged
lfrancke merged 1 commit into
apache:branch-2.4from
sbernauer:branch-2.4
Nov 24, 2023
Merged

HBASE-25292 [branch-2.4] Improve InetSocketAddress usage discipline#5515
lfrancke merged 1 commit into
apache:branch-2.4from
sbernauer:branch-2.4

Conversation

@sbernauer

@sbernauersbernauer commented Nov 12, 2023

Copy link
Copy Markdown

Back-port of #2669 to the 2.4 release line.

(cherry picked from commit f813479)
Co-authored-by: Andrew Purtell apurtell@apache.org

@Apache-HBase

Apache-HBase commented Nov 12, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 28sbranch-2.4 passed
+1 💚compile4m 5sbranch-2.4 passed
+1 💚checkstyle1m 23sbranch-2.4 passed
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 27sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile4m 0sthe patch passed
+1 💚javac4m 0sthe patch passed
-0 ⚠️checkstyle0m 17shbase-client: The patch generated 7 new + 6 unchanged - 0 fixed = 13 total (was 6)
-0 ⚠️checkstyle0m 35shbase-server: The patch generated 2 new + 20 unchanged - 0 fixed = 22 total (was 20)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 10sPatch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.6.
-1 ❌spotless0m 13spatch has 21 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs4m 4sthe patch passed
_ Other Tests _
+1 💚asflicense0m 42sThe patch does not generate ASF License warnings.
46m 51s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5515
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux b488d40470c7 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 12, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 30sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 32sbranch-2.4 passed
+1 💚compile1m 32sbranch-2.4 passed
+1 💚shadedjars4m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 24sthe patch passed
+1 💚compile1m 31sthe patch passed
+1 💚javac1m 31sthe patch passed
+1 💚shadedjars4m 35spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7sthe patch passed
_ Other Tests _
+1 💚unit1m 29shbase-common in the patch passed.
+1 💚unit2m 20shbase-client in the patch passed.
+1 💚unit0m 35shbase-zookeeper in the patch passed.
+1 💚unit161m 47shbase-server in the patch passed.
+1 💚unit0m 21shbase-external-blockcache in the patch passed.
193m 18s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5515
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9470f0e117f0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/testReport/
Max. process+thread count4542 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@lfrancke

lfrancke commented Nov 12, 2023

Copy link
Copy Markdown
Member

Thank you. This is looking good to me but since I was involved in creating this patch I'll give @apurtell (or others) a chance to take a look as well.

Thank you @sbernauer!

@Apache-HBase

Apache-HBase commented Nov 12, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 9sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 10sbranch-2.4 passed
+1 💚compile1m 33sbranch-2.4 passed
+1 💚shadedjars3m 56sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 14sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 1sthe patch passed
+1 💚compile1m 33sthe patch passed
+1 💚javac1m 33sthe patch passed
+1 💚shadedjars3m 55spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sthe patch passed
_ Other Tests _
+1 💚unit1m 21shbase-common in the patch passed.
+1 💚unit2m 9shbase-client in the patch passed.
+1 💚unit0m 36shbase-zookeeper in the patch passed.
+1 💚unit173m 6shbase-server in the patch passed.
+1 💚unit0m 24shbase-external-blockcache in the patch passed.
203m 39s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5515
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2bdecb39f840 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/testReport/
Max. process+thread count3869 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 12, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 33sbranch-2.4 passed
+1 💚compile4m 10sbranch-2.4 passed
+1 💚checkstyle1m 22sbranch-2.4 passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 29sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 20sthe patch passed
+1 💚compile4m 13sthe patch passed
+1 💚javac4m 13sthe patch passed
+1 💚checkstyle1m 22sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 35sPatch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.6.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs4m 8sthe patch passed
_ Other Tests _
+1 💚asflicense0m 47sThe patch does not generate ASF License warnings.
45m 45s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5515
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 9bb5c9fead33 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 12, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 21sbranch-2.4 passed
+1 💚compile1m 35sbranch-2.4 passed
+1 💚shadedjars4m 48sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 21sthe patch passed
+1 💚compile1m 35sthe patch passed
+1 💚javac1m 35sthe patch passed
+1 💚shadedjars4m 43spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 8sthe patch passed
_ Other Tests _
+1 💚unit1m 29shbase-common in the patch passed.
+1 💚unit2m 25shbase-client in the patch passed.
+1 💚unit0m 34shbase-zookeeper in the patch passed.
+1 💚unit162m 56shbase-server in the patch passed.
+1 💚unit0m 19shbase-external-blockcache in the patch passed.
192m 42s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5515
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b2ed5df78618 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/2/testReport/
Max. process+thread count4850 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 12, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 12sbranch-2.4 passed
+1 💚compile1m 34sbranch-2.4 passed
+1 💚shadedjars3m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 14sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall1m 58sthe patch passed
+1 💚compile1m 34sthe patch passed
+1 💚javac1m 34sthe patch passed
+1 💚shadedjars3m 54spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 11sthe patch passed
_ Other Tests _
+1 💚unit1m 22shbase-common in the patch passed.
+1 💚unit2m 4shbase-client in the patch passed.
+1 💚unit0m 36shbase-zookeeper in the patch passed.
+1 💚unit172m 53shbase-server in the patch passed.
+1 💚unit0m 25shbase-external-blockcache in the patch passed.
200m 39s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5515
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2e70ebf63040 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/2/testReport/
Max. process+thread count4119 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@sbernauer@apurtell
HBASE-25292 [branch-2.4] Improve InetSocketAddress usage discipline
c4dc0eb
Co-authored-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit f813479)
@Apache-HBase

Apache-HBase commented Nov 13, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 29sbranch-2.4 passed
+1 💚compile4m 5sbranch-2.4 passed
+1 💚checkstyle1m 21sbranch-2.4 passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 25sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile4m 4sthe patch passed
+1 💚javac4m 4sthe patch passed
+1 💚checkstyle1m 19sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 18sPatch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.6.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
+1 💚spotbugs4m 6sthe patch passed
_ Other Tests _
+1 💚asflicense0m 43sThe patch does not generate ASF License warnings.
44m 48s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5515
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 9e4f3a696cb6 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 13, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall2m 19sbranch-2.4 passed
+1 💚compile1m 32sbranch-2.4 passed
+1 💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 8sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 23sthe patch passed
+1 💚compile1m 33sthe patch passed
+1 💚javac1m 33sthe patch passed
+1 💚shadedjars4m 44spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9sthe patch passed
_ Other Tests _
+1 💚unit1m 29shbase-common in the patch passed.
+1 💚unit2m 30shbase-client in the patch passed.
+1 💚unit0m 35shbase-zookeeper in the patch passed.
+1 💚unit160m 57shbase-server in the patch passed.
+1 💚unit0m 17shbase-external-blockcache in the patch passed.
190m 39s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5515
Optional Testsjavac javadoc unit shadedjars compile
unameLinux faa77d5ffed0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/3/testReport/
Max. process+thread count5178 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 13, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall1m 59sbranch-2.4 passed
+1 💚compile1m 32sbranch-2.4 passed
+1 💚shadedjars3m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sbranch-2.4 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall1m 59sthe patch passed
+1 💚compile1m 34sthe patch passed
+1 💚javac1m 34sthe patch passed
+1 💚shadedjars3m 56spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 11sthe patch passed
_ Other Tests _
+1 💚unit1m 21shbase-common in the patch passed.
+1 💚unit2m 3shbase-client in the patch passed.
+1 💚unit0m 37shbase-zookeeper in the patch passed.
+1 💚unit178m 34shbase-server in the patch passed.
+1 💚unit0m 24shbase-external-blockcache in the patch passed.
206m 21s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5515
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b43101c0cd01 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.4 / 62f2383
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/3/testReport/
Max. process+thread count4217 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-zookeeper hbase-server hbase-external-blockcache U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5515/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

@sbernauer Thanks for opening this PR.

So you guys needs this on branch-2.4? The patch here removes a configuration, so typically we do not want to include it in a patch release.

And looking at the discussion on #2669 , there are also some other follow on tasks need to be done before making a release.

Thanks.

@lfrancke

lfrancke commented Nov 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Yep, we find that without it, running 2.4.x on Kubernetes is very unstable across restarts because of DNS issues.

We're also happy to just maintain the patch on our end for the rest of the lifecycle of 2.4 but thought others might benefit from this.

Indeed, it removes a config and at least I didn't think about that when we put this PR up.
The config was introduced as an attempted first fix for the same issue but that didn't really work. Some might call this PR a bugfix :)

Which other follow on tasks are you referring to?

But as I mentioned: We can also close this PR if you're opposed to the change, we don't have very strong feelings about it.

And thanks for taking a look!

@Apache9

Apache9 commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

See HBASE-25335.

I think at least we should also backport HBASE-25336?

@lfrancke

lfrancke commented Nov 21, 2023

Copy link
Copy Markdown
Member

Ah! Yes, sorry.

We have a patch for that as well and can put up a PR as well.

Only makes sense if we agree that this one should go in though I believe. They might even depend on each other, I haven't checked now.
But we can definitely do HBASE-25336 as well!

@Apache9

Apache9 commented Nov 24, 2023

Copy link
Copy Markdown
Contributor

I'm OK with backporting all these issues to 2.4.

@lfrancke

lfrancke commented Nov 24, 2023

Copy link
Copy Markdown
Member

Thank you! I'll merge it then and we'll get the second PR up as well.

@lfrancke
lfrancke merged commit 8707793 into apache:branch-2.4Nov 24, 2023
@sbernauer

sbernauer commented Nov 24, 2023

Copy link
Copy Markdown
Author

Thanks a lot for the quick review!

@sbernauersbernauer mentioned this pull request Nov 24, 2023
Merged
@sbernauer

sbernauer commented Nov 24, 2023

Copy link
Copy Markdown
Author

Created #5537 as a follow-up

vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@sbernauer@apurtell@petersomogyi
HBASE-25292 [branch-2.4] Improve InetSocketAddress usage discipline (a…
c531969
…pache#5515)
Co-authored-by: Andrew Purtell <apurtell@apache.org>
(cherry picked from commit f813479)
(cherry picked from commit 8707793)
Change-Id: Idef951d038f8bda6e74d57d2894323322cae3e86
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbernauer@Apache-HBase@lfrancke@Apache9