Skip to content

HBASE-28186 Rebase CacheAwareBalance related commits into master branch - #5527

Merged
taklwu merged 2 commits into
masterfrom
HBASE-27389-rebase
Nov 21, 2023
Merged

HBASE-28186 Rebase CacheAwareBalance related commits into master branch#5527
taklwu merged 2 commits into
masterfrom
HBASE-27389-rebase

Conversation

@wchevreuil

@wchevreuilwchevreuil commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@ragarkar@wchevreuil
HBASE-27999Implement cache prefetch aware load balancer (#5376)
ddd2565
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@Apache-HBase

Apache-HBase commented Nov 17, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 14sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 52smaster passed
+1 💚compile3m 25smaster passed
+1 💚checkstyle0m 59smaster passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 25smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 40sthe patch passed
+1 💚compile3m 23sthe patch passed
-0 ⚠️javac0m 21shbase-balancer generated 2 new + 14 unchanged - 0 fixed = 16 total (was 14)
-0 ⚠️checkstyle0m 10shbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 22sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs2m 48sthe patch passed
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
37m 39s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5527
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 74bd80e5105e 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9e74cc0
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-balancer.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-common hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 17, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 30smaster passed
+1 💚compile1m 2smaster passed
+1 💚shadedjars5m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 18sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars5m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
+1 💚unit2m 16shbase-common in the patch passed.
+1 💚unit9m 6shbase-balancer in the patch passed.
-1 ❌unit12m 42shbase-server in the patch failed.
45m 55s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5527
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 298e337e01b1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9e74cc0
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/testReport/
Max. process+thread count1636 (vs. ulimit of 30000)
modulesC: hbase-common hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 17, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 32smaster passed
+1 💚compile1m 40smaster passed
+1 💚shadedjars6m 26sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 43sthe patch passed
+1 💚compile1m 28sthe patch passed
+1 💚javac1m 28sthe patch passed
+1 💚shadedjars5m 34spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 55sthe patch passed
_ Other Tests _
+1 💚unit2m 32shbase-common in the patch passed.
+1 💚unit11m 59shbase-balancer in the patch passed.
-1 ❌unit18m 5shbase-server in the patch failed.
60m 54s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5527
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 41ce3a7b972a 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9e74cc0
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/testReport/
Max. process+thread count1732 (vs. ulimit of 30000)
modulesC: hbase-common hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
adding extra check for null/empty string in getFileSize
1fe6be2
Change-Id: I793c8f762116d70e74d186823612c35455357a1e
@Apache-HBase

Apache-HBase commented Nov 20, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 16sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall2m 42smaster passed
+1 💚compile3m 19smaster passed
+1 💚checkstyle1m 0smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 23smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 37sthe patch passed
+1 💚compile3m 19sthe patch passed
-0 ⚠️javac0m 20shbase-balancer generated 2 new + 14 unchanged - 0 fixed = 16 total (was 14)
-0 ⚠️checkstyle0m 10shbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 18sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs2m 46sthe patch passed
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
38m 0s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5527
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux c182c4d2a9ea 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9631af7
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-balancer.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-common hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 20, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 22sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall2m 44smaster passed
+1 💚compile1m 24smaster passed
+1 💚shadedjars4m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 47sthe patch passed
+1 💚compile1m 23sthe patch passed
+1 💚javac1m 23sthe patch passed
+1 💚shadedjars4m 55spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 54sthe patch passed
_ Other Tests _
+1 💚unit2m 19shbase-common in the patch passed.
+1 💚unit11m 22shbase-balancer in the patch passed.
+1 💚unit230m 10shbase-server in the patch passed.
272m 51s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5527
Optional Testsjavac javadoc unit shadedjars compile
unameLinux da04506df1ff 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9631af7
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/testReport/
Max. process+thread count4849 (vs. ulimit of 30000)
modulesC: hbase-common hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 20, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 19sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 28smaster passed
+1 💚compile1m 11smaster passed
+1 💚shadedjars4m 43sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 48smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile1m 10sthe patch passed
+1 💚javac1m 10sthe patch passed
+1 💚shadedjars4m 43spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 50sthe patch passed
_ Other Tests _
+1 💚unit1m 56shbase-common in the patch passed.
+1 💚unit9m 4shbase-balancer in the patch passed.
+1 💚unit273m 52shbase-server in the patch passed.
312m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5527
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ed8ea1328999 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9631af7
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/testReport/
Max. process+thread count4607 (vs. ulimit of 30000)
modulesC: hbase-common hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu
taklwu merged commit e799ee0 into masterNov 21, 2023
wchevreuil added a commit to wchevreuil/hbase that referenced this pull request Nov 22, 2023
@wchevreuil@ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
5bac2d7
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
ragarkar added a commit to ragarkar/hbase that referenced this pull request Nov 27, 2023
@ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
8f5533f
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
(cherry picked from commit e799ee0)
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Nov 29, 2023
@wchevreuil@ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
605014a
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
(cherry picked from commit e799ee0)
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Nov 29, 2023
@wchevreuil@ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
d991af1
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
(cherry picked from commit e799ee0)
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Nov 29, 2023
@wchevreuil@ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
bd6a7fe
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
(cherry picked from commit e799ee0)
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Nov 29, 2023
@wchevreuil@ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
8d4eb9d
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
(cherry picked from commit e799ee0)
wchevreuil added a commit that referenced this pull request Nov 30, 2023
@wchevreuil
HBASE-27999Implement cache prefetch aware load balancer (#5527)
e167714
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
(cherry picked from commit e799ee0)
wchevreuil added a commit that referenced this pull request Nov 30, 2023
@wchevreuil
HBASE-27999Implement cache prefetch aware load balancer (#5527)
b74429a
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
(cherry picked from commit e799ee0)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@wchevreuil@ragarkar
CDPD-64481: Backport HBASE-27997, HBASE-27998 and HBASE-27999
83f5933
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
(cherry picked from commit e799ee0)
Change-Id: I0dcd432d869159fc8e068ecb0ee18aa8f86fa278
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taklwutaklwutaklwu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wchevreuil@Apache-HBase@taklwu@ragarkar