Skip to content

Rebase HBASE-27389 on branch-3 - #5533

Closed
wchevreuil wants to merge 3 commits into
apache:branch-3from
wchevreuil:HBASE-27389-branch-3
Closed

Rebase HBASE-27389 on branch-3#5533
wchevreuil wants to merge 3 commits into
apache:branch-3from
wchevreuil:HBASE-27389-branch-3

Conversation

@wchevreuil

@wchevreuilwchevreuil commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

I'm opening this to make sure precommits pass, before merging the commit in branch-3.

ragarkarand others added 3 commits November 22, 2023 12:10
@ragarkar@wchevreuil
HBASE-27997 Enhance prefetch executor to record region prefetch infor… (
fd177a6
apache#5339)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewew-by: Kota-SH <shanmukhaharipriya@gmail.com>
@ragarkar@wchevreuil
HBASE-27998 Enhance region metrics to include prefetch ratio for each… (
766c935
apache#5342)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@wchevreuil@ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
5bac2d7
this commit is part of the rebase of HBASE-28186
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Co-authored-by: Rahul Agarkar <ragarkar@cloudera.com>
@Apache-HBase

Apache-HBase commented Nov 22, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 52sbranch-3 passed
+1 💚compile2m 2sbranch-3 passed
+1 💚shadedjars5m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9sbranch-3 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall0m 28sroot in the patch failed.
-1 ❌compile0m 7shbase-protocol-shaded in the patch failed.
-1 ❌compile0m 15shbase-client in the patch failed.
-1 ❌compile0m 11shbase-balancer in the patch failed.
-1 ❌compile0m 27shbase-server in the patch failed.
-0 ⚠️javac0m 7shbase-protocol-shaded in the patch failed.
-0 ⚠️javac0m 15shbase-client in the patch failed.
-0 ⚠️javac0m 11shbase-balancer in the patch failed.
-0 ⚠️javac0m 27shbase-server in the patch failed.
-1 ❌shadedjars1m 24spatch has 76 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 6shbase-protocol-shaded in the patch failed.
-0 ⚠️javadoc0m 22shbase-server generated 3 new + 94 unchanged - 1 fixed = 97 total (was 95)
_ Other Tests _
-1 ❌unit0m 7shbase-protocol-shaded in the patch failed.
+1 💚unit2m 16shbase-common in the patch passed.
-1 ❌unit0m 15shbase-client in the patch failed.
-1 ❌unit0m 12shbase-balancer in the patch failed.
-1 ❌unit0m 27shbase-server in the patch failed.
21m 10s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5533
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 43bff4b5be91 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 92f8066
Default JavaEclipse Adoptium-11.0.17+8
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-protocol-shaded.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-balancer.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-protocol-shaded.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-balancer.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-protocol-shaded.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-protocol-shaded.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-balancer.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/testReport/
Max. process+thread count370 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 22, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 59sbranch-3 passed
+1 💚compile2m 11sbranch-3 passed
+1 💚shadedjars5m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16sbranch-3 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall0m 29sroot in the patch failed.
-1 ❌compile0m 8shbase-protocol-shaded in the patch failed.
-1 ❌compile0m 18shbase-client in the patch failed.
-1 ❌compile0m 15shbase-balancer in the patch failed.
-1 ❌compile0m 31shbase-server in the patch failed.
-0 ⚠️javac0m 8shbase-protocol-shaded in the patch failed.
-0 ⚠️javac0m 18shbase-client in the patch failed.
-0 ⚠️javac0m 15shbase-balancer in the patch failed.
-0 ⚠️javac0m 31shbase-server in the patch failed.
-1 ❌shadedjars1m 45spatch has 76 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 7shbase-protocol-shaded in the patch failed.
-0 ⚠️javadoc0m 28shbase-server generated 3 new + 22 unchanged - 0 fixed = 25 total (was 22)
_ Other Tests _
-1 ❌unit0m 8shbase-protocol-shaded in the patch failed.
+1 💚unit2m 42shbase-common in the patch passed.
-1 ❌unit0m 18shbase-client in the patch failed.
-1 ❌unit0m 13shbase-balancer in the patch failed.
-1 ❌unit0m 27shbase-server in the patch failed.
23m 48s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5533
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b95a5c9d4f29 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 92f8066
Default JavaTemurin-1.8.0_352-b08
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-protocol-shaded.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-balancer.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-protocol-shaded.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-balancer.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-protocol-shaded.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-protocol-shaded.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-balancer.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/testReport/
Max. process+thread count374 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 22, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-3 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 47sbranch-3 passed
+1 💚compile4m 37sbranch-3 passed
+1 💚checkstyle1m 21sbranch-3 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 19sbranch-3 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall0m 29sroot in the patch failed.
-1 ❌compile0m 7shbase-protocol-shaded in the patch failed.
-1 ❌compile0m 15shbase-client in the patch failed.
-1 ❌compile0m 12shbase-balancer in the patch failed.
-1 ❌compile0m 28shbase-server in the patch failed.
-0 ⚠️cc0m 7shbase-protocol-shaded in the patch failed.
-0 ⚠️cc0m 15shbase-client in the patch failed.
-0 ⚠️cc0m 12shbase-balancer in the patch failed.
-0 ⚠️cc0m 28shbase-server in the patch failed.
-0 ⚠️javac0m 7shbase-protocol-shaded in the patch failed.
-0 ⚠️javac0m 15shbase-client in the patch failed.
-0 ⚠️javac0m 12shbase-balancer in the patch failed.
-0 ⚠️javac0m 28shbase-server in the patch failed.
-0 ⚠️checkstyle0m 8shbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck0m 9sThe patch causes 76 errors with Hadoop v3.2.4.
-1 ❌hadoopcheck0m 17sThe patch causes 76 errors with Hadoop v3.3.6.
-1 ❌hbaseprotoc0m 7shbase-protocol-shaded in the patch failed.
-1 ❌hbaseprotoc0m 16shbase-client in the patch failed.
-1 ❌hbaseprotoc0m 12shbase-balancer in the patch failed.
-1 ❌hbaseprotoc0m 26shbase-server in the patch failed.
+1 💚spotless0m 38spatch has no errors when running spotless:check.
-1 ❌spotbugs0m 7shbase-protocol-shaded in the patch failed.
-1 ❌spotbugs0m 12shbase-client in the patch failed.
-1 ❌spotbugs0m 12shbase-balancer in the patch failed.
-1 ❌spotbugs0m 26shbase-server in the patch failed.
_ Other Tests _
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
24m 53s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5533
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux 928dee50a2f6 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 92f8066
Default JavaEclipse Adoptium-11.0.17+8
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
cchttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
cchttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
cchttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt
cchttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-protocol-shaded.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-balancer.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-protocol-shaded.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-balancer.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5533/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taklwutaklwuAwaiting requested review from taklwu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wchevreuil@Apache-HBase@ragarkar