Uh oh!
There was an error while loading. Please reload this page.
HBASE-28212 Do not need to maintain rollback step when root procedure… - #5538
Conversation
Apache-HBase
commented
Nov 24, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 24, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 24, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 24, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 24, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 24, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 25, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 25, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 25, 2023
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
| // allows to kill the executor before something is stored to the wal. | ||
| // useful to test the procedure recovery. | ||
| if (testing != null && testing.shouldKillBeforeStoreUpdate()) { |
There was a problem hiding this comment.
We have replaced shouldKillBeforeStoreUpdate here with shouldKillBeforeStoreUpdateInRollback?
There was a problem hiding this comment.
Yes. I split the condition for normal execution and rollback, so in some tests we need to set both, for example, in TestProcedureRecovery.
Apache-HBase
commented
Nov 27, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 27, 2023
🎊 +1 overall
This message was automatically generated. |
… does not support rollback
Apache-HBase
commented
Nov 27, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 27, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 27, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 27, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 27, 2023
🎊 +1 overall
This message was automatically generated. |
Apache9
commented
Nov 28, 2023
Will merge tomorrow if no other concerns~ Thanks @GeorryHuang for reviewing~ |
… does not support rollback (apache#5538) Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 4b015e6) (cherry picked from commit 7d6de8b)
… does not support rollback (apache#5538) Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
… does not support rollback (apache#5538) (apache#5547) Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 4b015e6) (cherry picked from commit b1bef8f) Change-Id: I6758e5ec7c06e38fc10e388b9cf295dc587733d2
… does not support rollback