Skip to content

HBASE-28212 Do not need to maintain rollback step when root procedure… - #5547

Merged
Apache9 merged 1 commit into
apache:branch-2from
Apache9:HBASE-28212-branch-2
Nov 29, 2023
Merged

HBASE-28212 Do not need to maintain rollback step when root procedure…#5547
Apache9 merged 1 commit into
apache:branch-2from
Apache9:HBASE-28212-branch-2

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

… does not support rollback (#5538)

Signed-off-by: GeorryHuang huangzhuoyue@apache.org
(cherry picked from commit 4b015e6) (cherry picked from commit 7d6de8b)

… does not support rollback (apache#5538)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 4b015e6)
(cherry picked from commit 7d6de8b)
@Apache9Apache9 added the backport This PR is a back port of some issue or issues already committed to master label Nov 29, 2023
@Apache9Apache9 self-assigned this Nov 29, 2023
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 14sbranch-2 passed
+1 💚compile3m 24sbranch-2 passed
+1 💚checkstyle0m 50sbranch-2 passed
-1 ❌spotless0m 44sbranch has 1 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs3m 50sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
+1 💚compile3m 23sthe patch passed
+1 💚cc3m 23sthe patch passed
+1 💚javac3m 23sthe patch passed
+1 💚checkstyle0m 48sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 10sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚hbaseprotoc1m 13sthe patch passed
+1 💚spotless0m 46spatch has no errors when running spotless:check.
+1 💚spotbugs4m 14sthe patch passed
_ Other Tests _
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
43m 51s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5547
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux 7a6175b64081 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ea11923
Default JavaEclipse Adoptium-11.0.17+8
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-procedure hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 14sbranch-2 passed
+1 💚compile1m 26sbranch-2 passed
+1 💚shadedjars5m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
+1 💚compile1m 28sthe patch passed
+1 💚javac1m 28sthe patch passed
+1 💚shadedjars5m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41sthe patch passed
_ Other Tests _
+1 💚unit0m 30shbase-protocol-shaded in the patch passed.
+1 💚unit1m 27shbase-procedure in the patch passed.
+1 💚unit207m 47shbase-server in the patch passed.
236m 34s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5547
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 12789fc35368 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ea11923
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/testReport/
Max. process+thread count4759 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-procedure hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 52sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 49sbranch-2 passed
+1 💚compile1m 46sbranch-2 passed
+1 💚shadedjars6m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 53sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile1m 48sthe patch passed
+1 💚javac1m 48sthe patch passed
+1 💚shadedjars6m 27spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 53sthe patch passed
_ Other Tests _
+1 💚unit0m 38shbase-protocol-shaded in the patch passed.
+1 💚unit1m 57shbase-procedure in the patch passed.
+1 💚unit264m 25shbase-server in the patch passed.
299m 1s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5547
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f8d79484a930 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ea11923
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/testReport/
Max. process+thread count4169 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-procedure hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5547/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

The spotless error is not a real style problem...

[ERROR] An internal error occurred during: "Periodic workspace save.".
java.lang.IllegalStateException: Job manager has been shut down.
at org.eclipse.core.internal.jobs.JobManager.schedule (JobManager.java:1295)
at org.eclipse.core.internal.jobs.InternalJob.schedule (InternalJob.java:385)
at org.eclipse.core.runtime.jobs.Job.schedule (Job.java:684)
at org.eclipse.core.internal.events.AutoBuildJob.build (AutoBuildJob.java:110)
at org.eclipse.core.internal.events.BuildManager.endTopLevel (BuildManager.java:604)
at org.eclipse.core.internal.resources.Workspace.endOperation (Workspace.java:1518)
at org.eclipse.core.internal.resources.SaveManager.save (SaveManager.java:1246)
at org.eclipse.core.internal.resources.SaveManager.save (SaveManager.java:1143)
at org.eclipse.core.internal.resources.DelayedSnapshotJob.run (DelayedSnapshotJob.java:55)
at org.eclipse.core.internal.jobs.Worker.run (Worker.java:63)

Let me merge.

@Apache9
Apache9 merged commit 0a8b620 into apache:branch-2Nov 29, 2023
Apache9 added a commit that referenced this pull request Nov 29, 2023
… does not support rollback (#5538) (#5547)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 4b015e6)
Apache9 added a commit that referenced this pull request Nov 29, 2023
… does not support rollback (#5538) (#5547)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 4b015e6)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
… does not support rollback (apache#5538) (apache#5547)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit 4b015e6)
(cherry picked from commit b1bef8f)
Change-Id: I6758e5ec7c06e38fc10e388b9cf295dc587733d2
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Apache9@Apache-HBase