Skip to content

HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A - #5554

Merged
bbeaudreault merged 1 commit into
masterfrom
HBASE-28222
Dec 1, 2023
Merged

HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A#5554
bbeaudreault merged 1 commit into
masterfrom
HBASE-28222

Conversation

@bbeaudreault

@bbeaudreaultbbeaudreault commented Nov 30, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This change reverts HBASE-12819. Please see my reasonings here: https://issues.apache.org/jira/browse/HBASE-28222?focusedCommentId=17791815&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17791815

I tried implementing a few different ways to solve this leak while leaving the above jira in place, but none of them quite work or make sense. We really need caching enabled given how much of our hdfs path code works.

I've tested this in my environment, and it fixes a longstanding leak-to-OOM for us. In the past we worked around it with a custom patch.

@bbeaudreault
HBASE-28222Leak in ExportSnapshot during verifySnapshot on S3A
31dd283
Revert "HBASE-12819 ExportSnapshot doesn't close FileSystem instances"
This reverts commit ee32eeb
@Apache-HBase

Apache-HBase commented Dec 1, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall2m 46smaster passed
+1 💚compile0m 33smaster passed
+1 💚checkstyle0m 12smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
+1 💚spotbugs0m 35smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile0m 30sthe patch passed
+1 💚javac0m 30sthe patch passed
+1 💚checkstyle0m 12sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 28sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs0m 40sthe patch passed
_ Other Tests _
+1 💚asflicense0m 8sThe patch does not generate ASF License warnings.
25m 36s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5554/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5554
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 9384a4a8c923 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 44eb408
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5554/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 1, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 53smaster passed
+1 💚compile0m 19smaster passed
+1 💚shadedjars4m 52sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 17smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 38sthe patch passed
+1 💚compile0m 20sthe patch passed
+1 💚javac0m 20sthe patch passed
+1 💚shadedjars4m 50spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 15sthe patch passed
_ Other Tests _
+1 💚unit16m 55shbase-mapreduce in the patch passed.
34m 49s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5554/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5554
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fc3c3460795f 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 44eb408
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5554/1/testReport/
Max. process+thread count3252 (vs. ulimit of 30000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5554/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 1, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 57smaster passed
+1 💚compile0m 20smaster passed
+1 💚shadedjars5m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 15smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 20sthe patch passed
+1 💚compile0m 22sthe patch passed
+1 💚javac0m 22sthe patch passed
+1 💚shadedjars5m 54spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 15sthe patch passed
_ Other Tests _
+1 💚unit17m 8shbase-mapreduce in the patch passed.
39m 20s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5554/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5554
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f497d2d8738d 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 44eb408
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5554/1/testReport/
Max. process+thread count3162 (vs. ulimit of 30000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5554/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil approved these changes Dec 1, 2023
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
The explanation in the jira makes sense to me, I'm convinced!

@bbeaudreault
bbeaudreault merged commit 02217e1 into masterDec 1, 2023
@bbeaudreault
bbeaudreault deleted the HBASE-28222 branch December 1, 2023 13:23
bbeaudreault added a commit that referenced this pull request Dec 1, 2023
@bbeaudreault
HBASE-28222Leak in ExportSnapshot during verifySnapshot on S3A (#5554)
95694dd
Revert "HBASE-12819 ExportSnapshot doesn't close FileSystem instances"
This reverts commit ee32eeb
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
bbeaudreault added a commit that referenced this pull request Dec 1, 2023
@bbeaudreault
HBASE-28222Leak in ExportSnapshot during verifySnapshot on S3A (#5554)
0f34724
Revert "HBASE-12819 ExportSnapshot doesn't close FileSystem instances"
This reverts commit ee32eeb
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
bbeaudreault added a commit that referenced this pull request Dec 1, 2023
@bbeaudreault
HBASE-28222Leak in ExportSnapshot during verifySnapshot on S3A (#5554)
00af5df
Revert "HBASE-12819 ExportSnapshot doesn't close FileSystem instances"
This reverts commit ee32eeb
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Dec 1, 2023
@bbeaudreault
HubSpot Backport: HBASE-28222 Leak in ExportSnapshot during verifySna…
db21101
…pshot on S3A (apache#5554)
Revert "HBASE-12819 ExportSnapshot doesn't close FileSystem instances"
This reverts commit ee32eeb
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
kadirozde pushed a commit to kadirozde/hbase that referenced this pull request Jan 5, 2024
@bbeaudreault@kadirozde
HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A (apac…
e879a6a
…he#5554)
Revert "HBASE-12819 ExportSnapshot doesn't close FileSystem instances"
This reverts commit ee32eeb
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bbeaudreault@Apache-HBase@wchevreuil