Uh oh!
There was an error while loading. Please reload this page.
HBASE-28204 : Region Canary can take lot more time If any region (except the first region) starts with delete markers - #5675
Merged
Conversation
… first region) starts with delete markers
virajjasani
approved these changes
Feb 10, 2024
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
Left minor nits, +1 otherwise. Really nice improvement!
| // regions in sequence until it can find first available row. | ||
| // | ||
| // This could result in multiple millions of scans based on the size of table and number of | ||
| // empty regions in sequence. In test environment, A table no data and 1000 empty regions, |
| } else { | ||
| scan = new Scan(); | ||
| // In case of first region of the HBase Table, we do not have start-key for the region. | ||
| // For Region Canary, we only need scan a single row/cell in the region to make sure that |
Apache-HBase
commented
Feb 10, 2024
🎊 +1 overall
This message was automatically generated. |
d-c-manning
approved these changes
Feb 10, 2024
Contributor
There was a problem hiding this comment.
At least this change does not change any behavior of the Canary, other than avoiding unnecessary scans for empty tables/regions, and avoiding a Get of a very large deleted row, if it exists. Seems to be a strict improvement in that sense.
If anyone was relying on the RPCs being Gets, by using separate RPC handlers for Gets vs. Scans, this will change that behavior. But that seems like weird behavior to rely on.
+1
| // do canary run for the table. | ||
| // | ||
| // Since First region of the table doesn't have any start key, We should set End Key as | ||
| // stop row and set inclusive=false to limit scan to single region only. |
Contributor
There was a problem hiding this comment.
We could even add a comment that we think this would be the better approach for all regions (not only the first region of the table), but who knows what performance people may expect from the canary, and whether they are counting on most Get requests (now Scans) not returning any data, and therefore performing extra fast (?)
ContributorAuthor
There was a problem hiding this comment.
Added some more comments as well as TODO for future.
Apache-HBase
commented
Feb 10, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 10, 2024
💔 -1 overall
This message was automatically generated. |
ContributorAuthor
@d-c-manning 's suggestion is valid. Should we include this as JIRA release note? So it's documented for every branch that has this JIRA? @virajjasani |
virajjasani
commented
Feb 10, 2024
Contributor
Sounds good, feel free to update release note on the Jira. |
Apache-HBase
commented
Feb 10, 2024
🎊 +1 overall
This message was automatically generated. |
mihir6692
commented
Feb 10, 2024
ContributorAuthor
Updated Release note on the JIRA @virajjasani |
Apache-HBase
commented
Feb 10, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 10, 2024
🎊 +1 overall
This message was automatically generated. |
virajjasani pushed a commit
that referenced
this pull request
Feb 12, 2024
…ept the first region) starts with delete markers (#5675) Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit
that referenced
this pull request
Feb 12, 2024
…ept the first region) starts with delete markers (#5675) Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit
that referenced
this pull request
Feb 12, 2024
…ept the first region) starts with delete markers (#5675) Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit
that referenced
this pull request
Feb 12, 2024
…ept the first region) starts with delete markers (#5675) Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit
that referenced
this pull request
Feb 12, 2024
…ept the first region) starts with delete markers (#5675) Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: HBASE-28204