Skip to content

HBASE-28368 Backport "HBASE-27693 Support for Hadoop's LDAP Authentic… - #5680

Merged
NihalJain merged 2 commits into
apache:branch-2from
NihalJain:HBASE-28368
May 31, 2025
Merged

HBASE-28368 Backport "HBASE-27693 Support for Hadoop's LDAP Authentic…#5680
NihalJain merged 2 commits into
apache:branch-2from
NihalJain:HBASE-28368

Conversation

@NihalJain

Copy link
Copy Markdown
Contributor

…ation mechanism (Web UI only)" to branch-2
Co-authored-by: Yash Dodeja yashdodeja@yahoo.com

@NihalJain

NihalJain commented Feb 14, 2024

Copy link
Copy Markdown
ContributorAuthor

Backports #5144 / #5213

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

The test TestLogLevel fails for hadoop-2, but passes for hadoop-3. Will analyse and fix with next commit.

@Apache-HBase

This comment has been minimized.

@Apache9

Copy link
Copy Markdown
Contributor

The failure for jdk8 hadoop2 is related?

@NihalJain

NihalJain commented Feb 18, 2024

Copy link
Copy Markdown
ContributorAuthor

Yes I have checked the test failures are related. There's more changes needed for hadoop2. In hadoop 2 the version of directory services used is different from what we are importing for hadoop 3 and both versions have somewhat incompatible changes. I will submit a fix to make test run for both.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

The failure precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.http.log.TestLogLevel.(?) is related:

java.lang.NoClassDefFoundError: org/apache/directory/api/ldap/schemaextractor/SchemaLdifExtractor
at org.apache.hadoop.hbase.http.log.TestLogLevel.setupMiniKdc(TestLogLevel.java:116)
at org.apache.hadoop.hbase.http.log.TestLogLevel.setUp(TestLogLevel.java:107)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.ClassNotFoundException: org.apache.directory.api.ldap.schemaextractor.SchemaLdifExtractor
at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
... 16 more

We see this as we have overridden the apacheds version in pom for all hadoop versions but for hadoop 2 it fails to start KDC as the above package does not even exist in apacheds 2.0.0.AM26 while hadoop 2 requires 2.0.0-M15.
Moving to 2.0.0-M15 causes test class to fail as annotations like CreateLdapServer etc are not supported with that version.

So as a fix I propose to skip running LDAP tests fro hadoop2 and also moving all dependency changes to be only for hadoop3.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain
NihalJain requested review from Apache9 and ndimidukMay 21, 2025 11:33
@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Failures are not related, previous build test failure issue is resolved

Comment threadhbase-http/pom.xml
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<!--
Below tests fail with hadoop 2 due to test dependency versioning issues. Hence, skip LDAP tests for Hadoop 2,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is clever but quite unexpected for the average dev and thus a bit scary to me.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Retriggered build!

@Apache-HBase

This comment has been minimized.

NihalJainand others added 2 commits May 27, 2025 17:30
…ation mechanism (Web UI only)" to branch-2
Co-authored-by: Yash Dodeja <yashdodeja@yahoo.com>
… class SchemaLdifExtractor in ApacheDS 2.0.0.AM26. The issue arises from an overridden ApacheDS version incompatible with Hadoop 2. To resolve, skip LDAP tests for Hadoop 2 and apply dependency changes only for Hadoop 3.
@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Rebased PR!

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Failures are not related!

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Failures are not related!

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall4m 45sbranch-2 passed
+1 💚compile7m 54sbranch-2 passed
+1 💚checkstyle1m 23sbranch-2 passed
+1 💚spotbugs10m 53sbranch-2 passed
+1 💚spotless1m 14sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for patch
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile8m 35sthe patch passed
-0 ⚠️javac8m 35s/results-compile-javac-root.txtroot generated 2 new + 1255 unchanged - 0 fixed = 1257 total (was 1255)
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle1m 31s/results-checkstyle-root.txtroot: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚xmllint0m 0sNo new issues.
+1 💚spotbugs9m 59sthe patch passed
+1 💚hadoopcheck23m 48sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 52spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
79m 59s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5680
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
unameLinux 992f611804fc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a644bb0
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count178 (vs. ulimit of 30000)
modulesC: hbase-http . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 56sMaven dependency ordering for branch
+1 💚mvninstall3m 39sbranch-2 passed
+1 💚compile2m 16sbranch-2 passed
+1 💚javadoc2m 1sbranch-2 passed
+1 💚shadedjars6m 38sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 33sthe patch passed
+1 💚compile2m 30sthe patch passed
+1 💚javac2m 30sthe patch passed
+1 💚javadoc3m 2sthe patch passed
+1 💚shadedjars7m 21spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit275m 35sroot in the patch passed.
315m 59s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5680
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6e3bc9232607 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a644bb0
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/testReport/
Max. process+thread count8535 (vs. ulimit of 30000)
modulesC: hbase-http . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 47sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 20sbranch-2 passed
+1 💚compile2m 17sbranch-2 passed
+1 💚javadoc2m 0sbranch-2 passed
+1 💚shadedjars6m 33sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 14sthe patch passed
+1 💚compile2m 14sthe patch passed
+1 💚javac2m 14sthe patch passed
+1 💚javadoc1m 57sthe patch passed
+1 💚shadedjars6m 36spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit294m 51sroot in the patch passed.
331m 31s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5680
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 49db72c2c452 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a644bb0
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/testReport/
Max. process+thread count8437 (vs. ulimit of 30000)
modulesC: hbase-http . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 42sMaven dependency ordering for branch
+1 💚mvninstall2m 49sbranch-2 passed
+1 💚compile1m 48sbranch-2 passed
+1 💚javadoc1m 46sbranch-2 passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile1m 49sthe patch passed
+1 💚javac1m 49sthe patch passed
+1 💚javadoc1m 46sthe patch passed
+1 💚shadedjars5m 32spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit423m 53sroot in the patch passed.
455m 6s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5680
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 737fd4f5168c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a644bb0
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/testReport/
Max. process+thread count8112 (vs. ulimit of 30000)
modulesC: hbase-http . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5680/11/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

Copy link
Copy Markdown
ContributorAuthor

Green build !

@NihalJain
NihalJain merged commit a91d308 into apache:branch-2May 31, 2025
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
…ation mechanism (Web UI only)" to branch-2 (apache#5144) (apache#5680)
* Fix failure in pre-commit checks for Yetus JDK8 Hadoop2 due to missing class SchemaLdifExtractor in ApacheDS 2.0.0.AM26. The issue arises from an overridden ApacheDS version incompatible with Hadoop 2. To resolve, skip LDAP tests for Hadoop 2 and apply dependency changes only for Hadoop 3.
Co-authored-by: Yash Dodeja <yashdodeja@yahoo.com>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@NihalJain@Apache-HBase@Apache9@ndimiduk