HBASE-27693 Support for Hadoop's LDAP Authentication mechanism (Web UI only) by ydodeja365 · Pull Request #5144 · apache/hbase

ydodeja365 · 2023-03-27T06:59:44Z

No description provided.

Apache-HBase · 2023-03-27T08:16:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 30s	master passed
+1 💚	compile	4m 40s	master passed
+1 💚	checkstyle	1m 5s	master passed
+0 🆗	refguide	2m 39s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 31s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 16s	the patch passed
+1 💚	compile	4m 38s	the patch passed
+1 💚	javac	4m 38s	the patch passed
-0 ⚠️	checkstyle	1m 5s	root: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	2m 18s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	15m 40s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 19s	patch has 65 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	8m 41s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		65m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname	Linux e03c10d46065 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `735fb43`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/1/yetus-general-check/output/branch-site/book.html
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/1/yetus-general-check/output/patch-site/book.html
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	178 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-27T13:26:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 57s	master passed
+1 💚	compile	2m 19s	master passed
+1 💚	shadedjars	6m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 50s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 13s	the patch passed
+1 💚	compile	2m 48s	the patch passed
+1 💚	javac	2m 48s	the patch passed
+1 💚	shadedjars	6m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 47s	the patch passed
		_ Other Tests _
-1 ❌	unit	331m 58s	root in the patch failed.
		376m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4dba8fc3a460 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `735fb43`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/testReport/
Max. process+thread count	2687 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-27T13:42:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	1m 35s	master passed
+1 💚	shadedjars	4m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	1m 37s	the patch passed
+1 💚	javac	1m 37s	the patch passed
+1 💚	shadedjars	4m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	the patch passed
		_ Other Tests _
-1 ❌	unit	364m 4s	root in the patch failed.
		391m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1d9f2255ac96 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `735fb43`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/testReport/
Max. process+thread count	2405 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-27T15:26:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 2s	master passed
+1 💚	compile	8m 38s	master passed
+1 💚	checkstyle	1m 28s	master passed
+0 🆗	refguide	2m 58s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 48s	branch has no errors when running spotless:check.
+1 💚	spotbugs	13m 4s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 13s	the patch passed
+1 💚	compile	7m 45s	the patch passed
+1 💚	javac	7m 45s	the patch passed
-0 ⚠️	checkstyle	1m 33s	root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+0 🆗	refguide	3m 25s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	19m 4s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 53s	patch has no errors when running spotless:check.
+1 💚	spotbugs	12m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		97m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide
uname	Linux 6a4c0e5652eb 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a6dad70`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/2/yetus-general-check/output/branch-site/book.html
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/2/yetus-general-check/output/patch-site/book.html
Max. process+thread count	175 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-27T18:55:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 33s	master passed
+1 💚	compile	2m 11s	master passed
+1 💚	shadedjars	5m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	1m 53s	the patch passed
+1 💚	javac	1m 53s	the patch passed
+1 💚	shadedjars	4m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 3s	the patch passed
		_ Other Tests _
+1 💚	unit	272m 39s	root in the patch passed.
		306m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ff058199b4d2 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a6dad70`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/testReport/
Max. process+thread count	4741 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-27T20:12:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 37s	master passed
+1 💚	compile	1m 54s	master passed
+1 💚	shadedjars	5m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 44s	the patch passed
+1 💚	compile	1m 58s	the patch passed
+1 💚	javac	1m 58s	the patch passed
+1 💚	shadedjars	5m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 17s	the patch passed
		_ Other Tests _
-1 ❌	unit	349m 54s	root in the patch failed.
		383m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fc63efb2abf9 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a6dad70`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/testReport/
Max. process+thread count	2361 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-31T11:04:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 51s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 29s	master passed
+1 💚	compile	4m 41s	master passed
+1 💚	checkstyle	1m 1s	master passed
+0 🆗	refguide	2m 42s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
-1 ❌	spotbugs	7m 13s	root in master has 4 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 18s	the patch passed
+1 💚	compile	4m 40s	the patch passed
-0 ⚠️	javac	4m 40s	root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908)
-0 ⚠️	checkstyle	1m 3s	root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+0 🆗	refguide	2m 17s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 4s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌	spotless	0m 8s	patch has 15 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	7m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		64m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide
uname	Linux 2e665f9bb57d 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5620e2`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/3/yetus-general-check/output/branch-site/book.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/3/yetus-general-check/output/patch-site/book.html
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	177 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign in to view

 <description>HTTP functionality for HBase Servers</description>
+ <properties>
+ <!-- Required for testing LDAP integration -->
+ <apacheds.version>2.0.0.AM26</apacheds.version>


ydodeja365 · 2023-04-04T08:54:58Z

Sign in to view

+ * Initializes hadoop-auth AuthenticationFilter which provides support for Kerberos HTTP SPNEGO
+ * authentication.
+ * <p>
+ * It enables anonymous access, simple/pseudo and Kerberos HTTP SPNEGO authentication for Hadoop


Could others please suggest on this?

Apache-HBase · 2023-03-31T15:50:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 6s	master passed
+1 💚	compile	2m 37s	master passed
+1 💚	shadedjars	5m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 5s	the patch passed
+1 💚	compile	2m 29s	the patch passed
+1 💚	javac	2m 29s	the patch passed
+1 💚	shadedjars	5m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 26s	the patch passed
		_ Other Tests _
-1 ❌	unit	310m 36s	root in the patch failed.
		350m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6950b50f468e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5620e2`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/testReport/
Max. process+thread count	2605 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-31T16:51:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	4m 42s	master passed
+1 💚	checkstyle	1m 1s	master passed
+0 🆗	refguide	2m 13s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 26s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 13s	the patch passed
+1 💚	compile	4m 45s	the patch passed
-0 ⚠️	javac	4m 45s	root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908)
-0 ⚠️	checkstyle	1m 6s	root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+0 🆗	refguide	2m 10s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 55s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		60m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide
uname	Linux 8b115e85e78a 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `143e9b4`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/4/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/4/yetus-general-check/output/patch-site/book.html
Max. process+thread count	177 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-31T21:16:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 2s	master passed
+1 💚	compile	2m 19s	master passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 56s	the patch passed
+1 💚	compile	2m 33s	the patch passed
+1 💚	javac	2m 33s	the patch passed
+1 💚	shadedjars	5m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	283m 48s	root in the patch passed.
		324m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux badbf42f615c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `143e9b4`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/testReport/
Max. process+thread count	4566 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-31T22:21:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	1m 36s	master passed
+1 💚	shadedjars	4m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	1m 35s	the patch passed
+1 💚	javac	1m 35s	the patch passed
+1 💚	shadedjars	4m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	356m 38s	root in the patch passed.
		389m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 135f2c31c0f5 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `143e9b4`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/testReport/
Max. process+thread count	4434 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-04T08:02:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 32s	master passed
+1 💚	compile	4m 44s	master passed
+1 💚	checkstyle	1m 5s	master passed
+0 🆗	refguide	2m 45s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	4m 44s	the patch passed
-0 ⚠️	javac	4m 44s	root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908)
-0 ⚠️	checkstyle	1m 4s	root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+0 🆗	refguide	2m 16s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 7s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		61m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide
uname	Linux 4e373f776ae6 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `143e9b4`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/5/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/5/yetus-general-check/output/patch-site/book.html
Max. process+thread count	176 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ydodeja365 · 2023-04-04T09:00:08Z

@jojochuang Could you also please help in reviewing this?

Apache-HBase · 2023-04-04T11:20:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s	master passed
+1 💚	compile	1m 52s	master passed
+1 💚	shadedjars	4m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 4s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 17s	the patch passed
+1 💚	compile	1m 55s	the patch passed
+1 💚	javac	1m 55s	the patch passed
+1 💚	shadedjars	4m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 4s	the patch passed
		_ Other Tests _
-1 ❌	unit	230m 46s	root in the patch failed.
		260m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 508565f94864 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `143e9b4`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/testReport/
Max. process+thread count	2464 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-04T14:09:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 52s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	1m 32s	master passed
+1 💚	shadedjars	4m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	1m 35s	the patch passed
+1 💚	javac	1m 35s	the patch passed
+1 💚	shadedjars	4m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	the patch passed
		_ Other Tests _
-1 ❌	unit	400m 30s	root in the patch failed.
		429m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d5ce456a8e32 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `143e9b4`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/testReport/
Max. process+thread count	4473 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ydodeja365 · 2023-04-06T05:42:30Z

Failures in pipeline are not relevant to this commit.

Apache9 · 2023-04-12T14:20:52Z

This is only for http?

ydodeja365 · 2023-04-13T16:24:00Z

This is only for http?

No, this was tested on different HBase UIs running on both HTTP/HTTPS. It is a layer for HBase UI only.

jojochuang · 2023-04-17T16:07:22Z

 <scope>test</scope>
 </dependency>
+ <dependency>
+ <groupId>org.apache.directory.server</groupId>


Just a comment.
I am a little concerned to include apache directory server. It's a big project with lots of dependencies, and there's been no release over 3 years. Very likely this dependency is going to to introduce transitive dependency versions know to be vulnerable. The apache directory server quarterly report last October mentioned a new release is coming up but nothing happens yet.
I understand this is for test scope only, so this is not a real issue.

jojochuang · 2023-04-17T16:32:23Z

I don't recall how the Hadoop's authentication filter works. But I assume it ultimately uses Hadoop's LdapAuthenticationHandler to implement the core functionality?

ydodeja365 · 2023-04-17T21:22:40Z

I don't recall how the Hadoop's authentication filter works. But I assume it ultimately uses Hadoop's LdapAuthenticationHandler to implement the core functionality?

Yes, it will instantiate AuthenticationFilter which will further use LdapAuthenticationHandler to implement core functionality.

Apache-HBase · 2023-04-19T07:51:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 52s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s	master passed
+1 💚	compile	4m 42s	master passed
+1 💚	checkstyle	1m 2s	master passed
+0 🆗	refguide	2m 21s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	4m 47s	the patch passed
-0 ⚠️	javac	4m 47s	root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908)
-0 ⚠️	checkstyle	1m 5s	root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+0 🆗	refguide	2m 16s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	12m 5s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		60m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide
uname	Linux 22442d061c42 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94a8f31`
Default Java	Eclipse Adoptium-11.0.17+8
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/6/yetus-general-check/output/branch-site/book.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/6/yetus-general-check/output/patch-site/book.html
Max. process+thread count	177 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ydodeja365 · 2023-04-19T11:44:27Z

Addressed all the review comments. Please let me know if this looks good. Thank you @Apache9 @jojochuang @NihalJain for the review.

Apache-HBase · 2023-04-19T12:04:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 48s	master passed
+1 💚	compile	1m 51s	master passed
+1 💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 58s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	1m 51s	the patch passed
+1 💚	javac	1m 51s	the patch passed
+1 💚	shadedjars	4m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	281m 51s	root in the patch passed.
		313m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bbebbe9f231a 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94a8f31`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/testReport/
Max. process+thread count	4679 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-19T13:58:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	1m 35s	master passed
+1 💚	shadedjars	4m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 51s	the patch passed
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
+1 💚	shadedjars	4m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	the patch passed
		_ Other Tests _
-1 ❌	unit	399m 8s	root in the patch failed.
		427m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5144
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b02cca29b610 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `94a8f31`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/testReport/
Max. process+thread count	4447 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-04-27T08:13:44Z

This is only for http?
No, this was tested on different HBase UIs running on both HTTP/HTTPS. It is a layer for HBase UI only.

Sorry I did not make it clear. I mean this is only for http/https, not for rpc, right?

And you have already answered that this is for UI only.

ydodeja365 · 2023-04-27T09:30:30Z

This is only for http?
No, this was tested on different HBase UIs running on both HTTP/HTTPS. It is a layer for HBase UI only.
Sorry I did not make it clear. I mean this is only for http/https, not for rpc, right?
And you have already answered that this is for UI only.

Thank you for your response. Yes, it is not for RPC.
All the review comments are addressed, could we please merge this?

jojochuang

+1 from me

NihalJain · 2023-04-27T16:02:27Z

+1 (non-binding)

NihalJain · 2023-04-27T16:11:43Z

nit: we could update jira description to capture its for web ui to avoid any confusion. Also @ydodeja365 please update release note in jira, once changes are merged.

Apache9 · 2023-04-28T14:41:21Z

I'm not very familiar with this area...

Anyway, you've already gotten a +1 from a committer :)

jojochuang · 2023-04-28T16:05:52Z

@ydodeja365 if you'd like this feature in branch-2 (HBase 2.6.0) can you submit another PR against branch-2? This feature has dependency on Hadoop so I'd like to have it run through precommit to make sure it doesn't break with Hadoop 2 runtime.

ydodeja365 · 2023-05-02T19:43:31Z

@ydodeja365 if you'd like this feature in branch-2 (HBase 2.6.0) can you submit another PR against branch-2? This feature has dependency on Hadoop so I'd like to have it run through precommit to make sure it doesn't break with Hadoop 2 runtime.

@jojochuang Raised PR for the same, there were some conflicts with this exact commit, so raised with similar changes: #5213

…ation mechanism (Web UI only)" to branch-2 (#5144) (#5680) * Fix failure in pre-commit checks for Yetus JDK8 Hadoop2 due to missing class SchemaLdifExtractor in ApacheDS 2.0.0.AM26. The issue arises from an overridden ApacheDS version incompatible with Hadoop 2. To resolve, skip LDAP tests for Hadoop 2 and apply dependency changes only for Hadoop 3. Co-authored-by: Yash Dodeja <yashdodeja@yahoo.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…ation mechanism (Web UI only)" to branch-2 (#5144) (#7021) * Fix failure in pre-commit checks for Yetus JDK8 Hadoop2 due to missing class SchemaLdifExtractor in ApacheDS 2.0.0.AM26. The issue arises from an overridden ApacheDS version incompatible with Hadoop 2. To resolve, skip LDAP tests for Hadoop 2 and apply dependency changes only for Hadoop 3. Co-authored-by: Yash Dodeja <yashdodeja@yahoo.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…ation mechanism (Web UI only)" to branch-2 (#5144) (#7022) * Fix failure in pre-commit checks for Yetus JDK8 Hadoop2 due to missing class SchemaLdifExtractor in ApacheDS 2.0.0.AM26. The issue arises from an overridden ApacheDS version incompatible with Hadoop 2. To resolve, skip LDAP tests for Hadoop 2 and apply dependency changes only for Hadoop 3. Co-authored-by: Yash Dodeja <yashdodeja@yahoo.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…ation mechanism (Web UI only)" to branch-2 (apache#5144) (apache#5680) * Fix failure in pre-commit checks for Yetus JDK8 Hadoop2 due to missing class SchemaLdifExtractor in ApacheDS 2.0.0.AM26. The issue arises from an overridden ApacheDS version incompatible with Hadoop 2. To resolve, skip LDAP tests for Hadoop 2 and apply dependency changes only for Hadoop 3. Co-authored-by: Yash Dodeja <yashdodeja@yahoo.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ydodeja365 force-pushed the HBASE-27693 branch from 74b04ec to 002b3f6Compare March 27, 2023 09:04

ydodeja365 force-pushed the HBASE-27693 branch from 002b3f6 to da39d83Compare March 31, 2023 09:57

chrajeshbabu requested review from Apache9, joshelser and saintstack and removed request for saintstack March 31, 2023 10:05

ydodeja365 force-pushed the HBASE-27693 branch from da39d83 to 42e5affCompare March 31, 2023 11:56

NihalJain reviewed Mar 31, 2023
View reviewed changes

Comment threadhbase-http/pom.xml Outdated
<description>HTTP functionality for HBase Servers</description>
<properties>

<apacheds.version>2.0.0.AM26</apacheds.version>
This comment was marked as resolved.
Sign in to view

NihalJain reviewed Mar 31, 2023
View reviewed changes

Comment threadhbase-http/src/main/java/org/apache/hadoop/hbase/http/lib/AuthenticationFilterInitializer.java

NihalJain reviewed Mar 31, 2023
View reviewed changes

Comment threadhbase-http/src/test/java/org/apache/hadoop/hbase/http/TestLdapHttpServer.java Outdated

ydodeja365 force-pushed the HBASE-27693 branch from 42e5aff to 400a2eeCompare April 4, 2023 06:48

jojochuang reviewed Apr 17, 2023
View reviewed changes

Comment threadhbase-http/src/main/java/org/apache/hadoop/hbase/http/lib/AuthenticationFilterInitializer.java Outdated

HBASE-27693 Support for Hadoop's LDAP Authentication mechanism
be64e40

ydodeja365 force-pushed the HBASE-27693 branch from 400a2ee to be64e40Compare April 19, 2023 06:42

jojochuang approved these changes Apr 27, 2023
View reviewed changes

jojochuang changed the title ~~HBASE-27693 Support for Hadoop's LDAP Authentication mechanism~~HBASE-27693 Support for Hadoop's LDAP Authentication mechanism (Web UI only)Apr 28, 2023

jojochuang merged commit 1f605cc into apache:masterApr 28, 2023

NihalJain mentioned this pull request Feb 14, 2024
HBASE-28368 Backport "HBASE-27693 Support for Hadoop's LDAP Authentic… #5680
Merged

Uh oh!

Conversation

ydodeja365 commented Mar 27, 2023

Uh oh!

Apache-HBase commented Mar 27, 2023

Uh oh!

Apache-HBase commented Mar 27, 2023

Uh oh!

Apache-HBase commented Mar 27, 2023

Uh oh!

Apache-HBase commented Mar 27, 2023

Uh oh!

Apache-HBase commented Mar 27, 2023

Uh oh!

Apache-HBase commented Mar 27, 2023

Uh oh!

Apache-HBase commented Mar 31, 2023

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

ydodeja365Apr 4, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Mar 31, 2023

Uh oh!

Apache-HBase commented Mar 31, 2023

Uh oh!

Apache-HBase commented Mar 31, 2023

Uh oh!

Apache-HBase commented Mar 31, 2023

Uh oh!

Apache-HBase commented Apr 4, 2023

Uh oh!

ydodeja365 commented Apr 4, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Apr 4, 2023

Uh oh!

Apache-HBase commented Apr 4, 2023

Uh oh!

ydodeja365 commented Apr 6, 2023

Uh oh!

Apache9 commented Apr 12, 2023

Uh oh!

ydodeja365 commented Apr 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jojochuangApr 17, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jojochuang commented Apr 17, 2023

Uh oh!

ydodeja365 commented Apr 17, 2023

Uh oh!

Apache-HBase commented Apr 19, 2023

Uh oh!

ydodeja365 commented Apr 19, 2023

Uh oh!

Apache-HBase commented Apr 19, 2023

Uh oh!

Apache-HBase commented Apr 19, 2023

Uh oh!

Apache9 commented Apr 27, 2023

Uh oh!

ydodeja365 commented Apr 27, 2023

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

NihalJain commented Apr 27, 2023

Uh oh!

NihalJain commented Apr 27, 2023

Uh oh!

Apache9 commented Apr 28, 2023

Uh oh!

ydodeja365 commented Apr 4, 2023•
edited
Loading

ydodeja365 commented Apr 13, 2023•
edited
Loading