Skip to content

HBASE-28379 Upgrade thirdparty dep to 4.1.6 - #5693

Merged
ndimiduk merged 3 commits into
apache:masterfrom
ndimiduk:28379-thirdparty-4.1.6
Mar 5, 2024
Merged

HBASE-28379 Upgrade thirdparty dep to 4.1.6#5693
ndimiduk merged 3 commits into
apache:masterfrom
ndimiduk:28379-thirdparty-4.1.6

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

Initial PR is pinned to SNAPSHOT built from apache/hbase-thirdparty#112 .

Comment threadpom.xml Outdated
@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

jdk8 we get,

[INFO] Results:
[INFO] [ERROR] Errors: [ERROR] org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush.null
[ERROR] Run 1: TestHRegionWithInMemoryFlush>TestHRegion.testMutateRowInParallel:7456->Object.wait:-2 » TestTimedOut test timed out after 780 seconds
[ERROR] Run 2: TestHRegionWithInMemoryFlush>TestHRegion.lambda$testMutateRowInParallel$3:7428 » Appears to be stuck in thread Thread-6326
[INFO] [INFO] [ERROR] Tests run: 6937, Failures: 0, Errors: 1, Skipped: 36

jdk11 give us

[INFO] Results:
[INFO] [ERROR] Errors: [ERROR] org.apache.hadoop.hbase.TestAcidGuaranteesWithBasicPolicy.null
[ERROR] Run 1: TestAcidGuaranteesWithBasicPolicy>AcidGuaranteesTestBase.testMobGetAtomicity:122->AcidGuaranteesTestBase.runTestAtomicity:102->Object.wait:-2 » TestTimedOut test timed out after 780 seconds
[ERROR] Run 2: TestAcidGuaranteesWithBasicPolicy » Appears to be stuck in thread MiniHBaseClusterRegionServer-EventLoopGroup-3-1
[INFO] [WARNING] Flakes: [WARNING] org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.testReplicationOfEmptyWALSurroundedNonEmptyWAL
[ERROR] Run 1: TestReplicationEmptyWALRecovery.testReplicationOfEmptyWALSurroundedNonEmptyWAL:313 Replicated entries are not correct expected:<40> but was:<20>
[INFO] Run 2: PASS
[INFO] [WARNING] org.apache.hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL.testInterClusterReplication
[ERROR] Run 1: TestReplicationEndpointWithMultipleAsyncWAL>TestReplicationEndpoint.testInterClusterReplication:244 Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2488
[INFO] Run 2: PASS
[INFO] [INFO] [ERROR] Tests run: 6941, Failures: 0, Errors: 1, Skipped: 36, Flakes: 2

@ndimiduk

ndimiduk commented Feb 21, 2024

Copy link
Copy Markdown
MemberAuthor

In local testing, TestHRegionWithInMemoryFlush is broken on master using both jdk8 and jdk11, with and without this patch. Same failure mode -- hmaster startup timeout -- though in different test methods each time.

https://issues.apache.org/jira/browse/HBASE-28387

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

TestAcidGuaranteesWithBasicPolicy passes for me locally, with and without this patch.

@ndimiduk
ndimiduk marked this pull request as ready for review February 22, 2024 07:15

@NihalJainNihalJain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to non-snapshot before merge.

@ndimiduk
ndimidukforce-pushed the 28379-thirdparty-4.1.6 branch from f795b4b to 57e5347CompareFebruary 23, 2024 08:59
@Apache-HBase

This comment was marked as outdated.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Okay strange. The shade plugin version bump isn't picked up in the yetus build. Its respected locally though...

@ndimiduk
ndimidukforce-pushed the 28379-thirdparty-4.1.6 branch from 6777479 to 80d0be0CompareFebruary 23, 2024 12:48
@ndimiduk

Copy link
Copy Markdown
MemberAuthor

Trying squish the commit history.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 52sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall4m 25smaster passed
+1 💚compile7m 8smaster passed
+1 💚spotless0m 52sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 9sthe patch passed
+1 💚compile6m 47sthe patch passed
+1 💚javac6m 47sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 10sThe patch has no ill-formed XML file.
+1 💚hadoopcheck5m 54sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 51spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
39m 24s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5693
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux cff1a651f05d 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c4a02f7
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall3m 29smaster passed
+1 💚compile1m 56smaster passed
+1 💚shadedjars6m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 11smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile2m 15sthe patch passed
+1 💚javac2m 15sthe patch passed
+1 💚shadedjars5m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 54sthe patch passed
_ Other Tests _
-1 ❌unit389m 15sroot in the patch failed.
423m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3767f763a320 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c4a02f7
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/testReport/
Max. process+thread count5818 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Also bump maven-shade-plugin version to support jackson upgrade and JDK21 bytecode class version
65
@ndimiduk
ndimidukforce-pushed the 28379-thirdparty-4.1.6 branch from e540f7b to 856d3bdCompareMarch 4, 2024 11:34
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall2m 52smaster passed
+1 💚compile4m 54smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile4m 53sthe patch passed
+1 💚javac4m 53sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 5sThe patch has no ill-formed XML file.
+1 💚hadoopcheck4m 48sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 42spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
29m 53s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5693
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 604a976521cc 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ede4ccd
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 1smaster passed
+1 💚compile2m 6smaster passed
+1 💚shadedjars5m 18sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile2m 7sthe patch passed
+1 💚javac2m 7sthe patch passed
+1 💚shadedjars5m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 45sthe patch passed
_ Other Tests _
+1 💚unit285m 17sroot in the patch passed.
319m 18s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e2078314aaa3 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ede4ccd
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/testReport/
Max. process+thread count8615 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall4m 5smaster passed
+1 💚compile2m 47smaster passed
+1 💚shadedjars6m 4sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 43smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall3m 51sthe patch passed
+1 💚compile2m 33sthe patch passed
+1 💚javac2m 33sthe patch passed
+1 💚shadedjars6m 29spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 47sthe patch passed
_ Other Tests _
-1 ❌unit369m 29sroot in the patch failed.
410m 34s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f3d5dbd2a5ce 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ede4ccd
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/testReport/
Max. process+thread count5312 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall3m 40smaster passed
+1 💚compile2m 21smaster passed
+1 💚shadedjars6m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for patch
+1 💚mvninstall3m 24sthe patch passed
+1 💚compile2m 17sthe patch passed
+1 💚javac2m 17sthe patch passed
+1 💚shadedjars6m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 22sthe patch passed
_ Other Tests _
-1 ❌unit456m 48sroot in the patch failed.
494m 5s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 75631bbf4d70 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ede4ccd
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/testReport/
Max. process+thread count6477 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 4f97ece into apache:masterMar 5, 2024
@ndimiduk
ndimiduk deleted the 28379-thirdparty-4.1.6 branch March 5, 2024 08:01
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
ndimiduk added a commit that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
ndimiduk added a commit that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
ndimiduk added a commit that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
stoty pushed a commit to stoty/hbase that referenced this pull request Mar 21, 2025
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
(cherry picked from commit bd06002)
stoty pushed a commit to stoty/hbase that referenced this pull request Mar 24, 2025
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
(cherry picked from commit bd06002)
stoty pushed a commit that referenced this pull request Mar 24, 2025
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
(cherry picked from commit bd06002)
kravii pushed a commit to acceldata-io/hbase that referenced this pull request Feb 25, 2026
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
(cherry picked from commit bd06002)
prabhjyotsingh pushed a commit to acceldata-io/hbase that referenced this pull request Feb 25, 2026
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
(cherry picked from commit bd06002)
odp-ops pushed a commit to acceldata-io/hbase that referenced this pull request May 4, 2026
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
(cherry picked from commit bd06002)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ndimiduk@Apache-HBase@NihalJain@pankaj72981