Skip to content

Backport "HBASE-28379 Upgrade thirdparty dep to 4.1.6 (#5693)" to branch-2.6 - #5710

Merged
ndimiduk merged 1 commit into
apache:branch-2.6from
ndimiduk:28379-thirdparty-4.1.6-branch-2.6
Mar 5, 2024
Merged

Backport "HBASE-28379 Upgrade thirdparty dep to 4.1.6 (#5693)" to branch-2.6#5710
ndimiduk merged 1 commit into
apache:branch-2.6from
ndimiduk:28379-thirdparty-4.1.6-branch-2.6

Conversation

@ndimiduk

@ndimidukndimiduk commented Feb 26, 2024

Copy link
Copy Markdown
Member

Trying out #5693 vs. branch-2.6. In particular, I'm hoping that the unit test suite will be more reliable here. Looks like hbase-examples handled shaded-protobuf slightly differently on this branch.

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Feb 26, 2024
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

Apache-HBase commented Feb 27, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 55sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 26sbranch-2.6 passed
+1 💚compile7m 25sbranch-2.6 passed
+1 💚spotless0m 54sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for patch
+1 💚mvninstall4m 14sthe patch passed
+1 💚compile7m 23sthe patch passed
+1 💚javac7m 23sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 5sThe patch has no ill-formed XML file.
+1 💚hadoopcheck10m 52sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚spotless0m 52spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
40m 5s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5710
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux bcf1077de020 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 9ae26c3
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 27, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 18sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 36sbranch-2.6 passed
+1 💚compile2m 21sbranch-2.6 passed
+1 💚shadedjars6m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 48sbranch-2.6 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall3m 37sthe patch passed
+1 💚compile2m 30sthe patch passed
+1 💚javac2m 30sthe patch passed
+1 💚shadedjars6m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25sthe patch passed
_ Other Tests _
-1 ❌unit275m 5sroot in the patch failed.
310m 47s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5710
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f4881483f777 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 9ae26c3
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/testReport/
Max. process+thread count5420 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 27, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall3m 12sbranch-2.6 passed
+1 💚compile1m 59sbranch-2.6 passed
+1 💚shadedjars5m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 21sbranch-2.6 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for patch
+1 💚mvninstall2m 51sthe patch passed
+1 💚compile2m 4sthe patch passed
+1 💚javac2m 4sthe patch passed
+1 💚shadedjars5m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 20sthe patch passed
_ Other Tests _
-1 ❌unit378m 1sroot in the patch failed.
411m 49s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5710
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 690c56a5623b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / 9ae26c3
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/testReport/
Max. process+thread count4723 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimidukforce-pushed the 28379-thirdparty-4.1.6-branch-2.6 branch from 1dca43a to 6c6d76fCompareMarch 4, 2024 11:35
@Apache-HBase

Apache-HBase commented Mar 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 25sbranch-2.6 passed
+1 💚compile5m 18sbranch-2.6 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile5m 11sthe patch passed
-0 ⚠️javac5m 11sroot generated 1 new + 1075 unchanged - 1 fixed = 1076 total (was 1076)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚hadoopcheck10m 9sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚spotless0m 43spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
31m 51s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5710
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 87c78a8993fd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / ce8f5a3
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count73 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 4, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 15sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall2m 52sbranch-2.6 passed
+1 💚compile2m 3sbranch-2.6 passed
+1 💚shadedjars5m 18sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 19sbranch-2.6 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
+1 💚compile2m 1sthe patch passed
+1 💚javac2m 1sthe patch passed
+1 💚shadedjars5m 18spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 18sthe patch passed
_ Other Tests _
-1 ❌unit230m 46sroot in the patch failed.
262m 5s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5710
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 45db897d1000 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / ce8f5a3
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/testReport/
Max. process+thread count5577 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for branch
+1 💚mvninstall2m 39sbranch-2.6 passed
+1 💚compile1m 36sbranch-2.6 passed
+1 💚shadedjars5m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 45sbranch-2.6 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 19sthe patch passed
+1 💚compile1m 36sthe patch passed
+1 💚javac1m 36sthe patch passed
+1 💚shadedjars5m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 46sthe patch passed
_ Other Tests _
+1 💚unit394m 31sroot in the patch passed.
423m 51s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5710
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f04f9ba4f54f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / ce8f5a3
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/testReport/
Max. process+thread count8034 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-shaded . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5710/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
HBASE-28379 Upgrade thirdparty dep to 4.1.6 (apache#5693)
5ff024b
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Pankaj Kumar < pankajkumar@apache.org>
@ndimiduk
ndimidukforce-pushed the 28379-thirdparty-4.1.6-branch-2.6 branch from 6c6d76f to 5ff024bCompareMarch 5, 2024 08:27
@ndimiduk
ndimiduk merged commit bd06002 into apache:branch-2.6Mar 5, 2024
@ndimiduk
ndimiduk deleted the 28379-thirdparty-4.1.6-branch-2.6 branch March 5, 2024 08:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NihalJainNihalJainNihalJain approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@NihalJain