HBASE-23324 Deprecate clients that connect to Zookeeper by ndimiduk · Pull Request #5745 · apache/hbase

ndimiduk · 2024-03-06T11:02:04Z

Our objective is to remove ZooKeeper from our public interface, remaking it as an internal concern. Connecting to a cluster via ZooKeeper quorum will be considered deprecated starting in 2.6. Our default connection mechanism will switch to via RPC in 3.0 And finally we intend to remove the ZooKeeper connection mechanism from client-facing APIs in 4.0.

ndimiduk · 2024-03-06T11:04:10Z

-
+@Deprecated
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+class ZKConnectionRegistry extends ZKConnectionRegistryInternal {


The diff isn't rendering well, but I renamed the existing ZKConnectionRegistry to ZKConnectionRegistryInternal and then created the new class named ZKConnectionRegistry that subclasses and adds the warning.

The idea is that we can remove this class, but keep the internal one if we want to in 4.0, right ?

Correct. HMaster and RegionServers will continue to use the ZKConnectionRegistry. Once the public version is removed, we can do as we like with the internal version, such as move it to hbase-server.jar.

I think in 3.0.0, HMaster and HRegionServer also uses RpcConnectionRegistry?

I think in 3.0.0, HMaster and HRegionServer also uses RpcConnectionRegistry?
Having read through the details of ShortCircuitConnectionRegistry, I now believe that you are correct. Nice!
So then this rename and Internal stuff is irrelevant -- we can drop the ZKConnectionRegistry entirely. WDYT?

For me I prefer we remove it entirely, in 4.0.0.

ndimiduk · 2024-03-06T14:07:27Z

FYI @stoty

Our objective is to remove ZooKeeper from our public interface, remaking it as an internal concern. Connecting to a cluster via ZooKeeper quorum will be considered deprecated starting in 2.6. Our default connection mechanism will switch to via RPC in 3.0 And finally we intend to remove the ZooKeeper connection mechanism from client-facing APIs in 4.0.

Apache-HBase · 2024-03-07T14:41:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	0m 21s	master passed
+1 💚	shadedjars	5m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	0m 21s	the patch passed
+1 💚	javac	0m 21s	the patch passed
+1 💚	shadedjars	5m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 30s	hbase-client in the patch passed.
		20m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5745
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ad8b232edf16 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `91354a0`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/testReport/
Max. process+thread count	283 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-07T14:50:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 52s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 26s	master passed
+1 💚	compile	0m 31s	master passed
+1 💚	shadedjars	7m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 8s	the patch passed
+1 💚	compile	0m 32s	the patch passed
+1 💚	javac	0m 32s	the patch passed
+1 💚	shadedjars	7m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 18s	hbase-client in the patch passed.
		29m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5745
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0b12765de283 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `91354a0`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/testReport/
Max. process+thread count	317 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-07T14:50:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 34s	master passed
+1 💚	compile	0m 34s	master passed
+1 💚	shadedjars	7m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	compile	0m 30s	the patch passed
+1 💚	javac	0m 30s	the patch passed
+1 💚	shadedjars	8m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-client in the patch passed.
		29m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5745
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a113c6573118 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `91354a0`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/testReport/
Max. process+thread count	298 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-07T14:53:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 48s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 58s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	checkstyle	0m 19s	master passed
+1 💚	spotless	0m 57s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	1m 4s	the patch passed
-0 ⚠️	javac	1m 4s	hbase-client generated 1 new + 34 unchanged - 0 fixed = 35 total (was 34)
+1 💚	checkstyle	0m 24s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 4s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 57s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 24s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		32m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5745
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 3b621e76dfd6 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `91354a0`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5745/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Our objective is to remove ZooKeeper from our public interface, remaking it as an internal concern. Connecting to a cluster via ZooKeeper quorum will be considered deprecated starting in 2.6. Our default connection mechanism will switch to via RPC in 3.0 And finally we intend to remove the ZooKeeper connection mechanism from client-facing APIs in 4.0. Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

ndimiduk commented Mar 6, 2024
View reviewed changes

ndimiduk force-pushed the 23324-deprecate-zkconnectionregistry-master branch from 1e0c9d0 to db8c3fbCompare March 6, 2024 11:11

ndimiduk requested a review from Apache9 March 6, 2024 11:15

This comment was marked as outdated.
Sign in to view

ndimiduk force-pushed the 23324-deprecate-zkconnectionregistry-master branch from db8c3fb to ec6004aCompare March 6, 2024 12:49

This comment was marked as outdated.
Sign in to view

ndimiduk requested review from apurtell, bbeaudreault and virajjasani March 6, 2024 14:05

bbeaudreault reviewed Mar 6, 2024
View reviewed changes

Comment threadhbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java Outdated

ndimiduk force-pushed the 23324-deprecate-zkconnectionregistry-master branch from ec6004a to 9caad86Compare March 7, 2024 09:59

This comment was marked as outdated.
Sign in to view

ndimiduk force-pushed the 23324-deprecate-zkconnectionregistry-master branch from 9caad86 to 1e922ceCompare March 7, 2024 14:07

bbeaudreault approved these changes Mar 7, 2024
View reviewed changes

ndimiduk merged commit 936d267 into apache:masterMar 7, 2024

ndimiduk deleted the 23324-deprecate-zkconnectionregistry-master branch March 7, 2024 17:33

Uh oh!

Conversation

ndimiduk commented Mar 6, 2024

Uh oh!

ndimidukMar 6, 2024

Choose a reason for hiding this comment

Uh oh!

stotyMar 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ndimidukMar 6, 2024

Choose a reason for hiding this comment

Uh oh!

Apache9Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

ndimidukMar 7, 2024

Choose a reason for hiding this comment

Uh oh!

Apache9Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

ndimiduk commented Mar 6, 2024

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Mar 7, 2024

Uh oh!

Apache-HBase commented Mar 7, 2024

Uh oh!

Apache-HBase commented Mar 7, 2024

Uh oh!

Apache-HBase commented Mar 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stotyMar 6, 2024•
edited
Loading