Skip to content

HBASE-28505 Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering - #5809

Merged
wchevreuil merged 4 commits into
apache:HBASE-28463from
vinayakphegde:HBASE-28505
Apr 12, 2024
Merged

HBASE-28505 Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering#5809
wchevreuil merged 4 commits into
apache:HBASE-28463from
vinayakphegde:HBASE-28505

Conversation

@vinayakphegde

@vinayakphegdevinayakphegde commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@vinayakphegde
HBASE-28465 Implementation of framework for time-based priority bucke…
a9d3170
…t-cache (apache#5793)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@Apache-HBase

Apache-HBase commented Apr 9, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 53sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-28463 Compile Tests _
+1 💚mvninstall3m 16sHBASE-28463 passed
+1 💚compile2m 59sHBASE-28463 passed
+1 💚checkstyle0m 37sHBASE-28463 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 33sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile2m 40sthe patch passed
-0 ⚠️javac2m 40shbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚checkstyle0m 49sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 27sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 51spatch has no errors when running spotless:check.
+1 💚spotbugs2m 26sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
34m 1s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5809
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 3d1875144a73 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-28463 Compile Tests _
+1 💚mvninstall2m 47sHBASE-28463 passed
+1 💚compile0m 39sHBASE-28463 passed
+1 💚shadedjars5m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 28sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚shadedjars5m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
-1 ❌unit236m 46shbase-server in the patch failed.
259m 55s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5809
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7b4a7f02d324 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/testReport/
Max. process+thread count5510 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 12sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-28463 Compile Tests _
+1 💚mvninstall3m 4sHBASE-28463 passed
+1 💚compile0m 49sHBASE-28463 passed
+1 💚shadedjars5m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile0m 50sthe patch passed
+1 💚javac0m 50sthe patch passed
+1 💚shadedjars6m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
-1 ❌unit256m 7shbase-server in the patch failed.
281m 19s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5809
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 76a21bda4a8a 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/testReport/
Max. process+thread count5222 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-28463 Compile Tests _
+1 💚mvninstall2m 57sHBASE-28463 passed
+1 💚compile2m 28sHBASE-28463 passed
+1 💚checkstyle0m 36sHBASE-28463 passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 32sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile2m 36sthe patch passed
+1 💚javac2m 36sthe patch passed
-0 ⚠️checkstyle0m 35shbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 29sPatch does not cause any errors with Hadoop 3.3.6.
-1 ❌spotless0m 46spatch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs2m 21sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
32m 1s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5809
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 2960b2c85a47 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-28463 Compile Tests _
+1 💚mvninstall2m 49sHBASE-28463 passed
+1 💚compile0m 40sHBASE-28463 passed
+1 💚shadedjars5m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚shadedjars5m 35spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
-1 ❌unit240m 1shbase-server in the patch failed.
263m 27s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5809
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4495b4a2ae53 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/testReport/
Max. process+thread count5404 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-28463 Compile Tests _
+1 💚mvninstall5m 1sHBASE-28463 passed
+1 💚compile1m 11sHBASE-28463 passed
+1 💚shadedjars7m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 49sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 30sthe patch passed
+1 💚compile1m 22sthe patch passed
+1 💚javac1m 22sthe patch passed
+1 💚shadedjars8m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41sthe patch passed
_ Other Tests _
-1 ❌unit342m 36shbase-server in the patch failed.
377m 26s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5809
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9b869afe148c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/testReport/
Max. process+thread count4415 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-28463 Compile Tests _
+1 💚mvninstall3m 53sHBASE-28463 passed
+1 💚compile2m 54sHBASE-28463 passed
+1 💚checkstyle0m 43sHBASE-28463 passed
+1 💚spotless0m 52sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 50sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 28sthe patch passed
+1 💚compile2m 56sthe patch passed
-0 ⚠️javac2m 56shbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚checkstyle0m 44sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 3sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless1m 2spatch has no errors when running spotless:check.
+1 💚spotbugs2m 32sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
35m 46s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5809
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 61647e87054d 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-28463 Compile Tests _
+1 💚mvninstall2m 49sHBASE-28463 passed
+1 💚compile0m 39sHBASE-28463 passed
+1 💚shadedjars5m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚shadedjars5m 40spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
+1 💚unit237m 18shbase-server in the patch passed.
260m 21s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5809
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3b44d7b373c8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/testReport/
Max. process+thread count5986 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 10, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-28463 Compile Tests _
+1 💚mvninstall4m 20sHBASE-28463 passed
+1 💚compile1m 17sHBASE-28463 passed
+1 💚shadedjars7m 28sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 13sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars7m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
+1 💚unit258m 30shbase-server in the patch passed.
291m 0s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5809
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fe87538c4481 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/testReport/
Max. process+thread count4494 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil approved these changes Apr 11, 2024
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, overall, just posted some minor nits. Please address it and I'll merge it to the feature branch.

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java Outdated

private static void checkDateTieredCompactionForTimeRangeDataTiering(final Configuration conf)
throws IOException {
final String DATE_TIERED_STORE_ENGINE =

@wchevreuilwchevreuilApr 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: make this a public constant somewhere in the date tiered compaction code, then import static here.

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java
Comment on lines +242 to +244
if (!DATE_TIERED_STORE_ENGINE.equals(conf.get(StoreEngine.STORE_ENGINE_CLASS_KEY))) {
throw new IOException(errorMessage);
}

@wchevreuilwchevreuilApr 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We should throw IllegalArgumentException, since this is rather a config error.

@Apache-HBase

Apache-HBase commented Apr 11, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-28463 Compile Tests _
+1 💚mvninstall3m 17sHBASE-28463 passed
+1 💚compile3m 0sHBASE-28463 passed
+1 💚checkstyle0m 37sHBASE-28463 passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 34sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 51sthe patch passed
+1 💚compile2m 28sthe patch passed
+1 💚javac2m 28sthe patch passed
+1 💚checkstyle0m 36sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck5m 44sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 48spatch has no errors when running spotless:check.
+1 💚spotbugs2m 15sthe patch passed
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
32m 16s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5809
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux c7e52c42d5c4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-28463 Compile Tests _
+1 💚mvninstall4m 34sHBASE-28463 passed
+1 💚compile1m 8sHBASE-28463 passed
+1 💚shadedjars6m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 4sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚shadedjars6m 55spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42sthe patch passed
_ Other Tests _
-1 ❌unit335m 1shbase-server in the patch failed.
367m 5s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5809
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7734fb3ad69b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/testReport/
Max. process+thread count4538 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-28463 Compile Tests _
+1 💚mvninstall3m 56sHBASE-28463 passed
+1 💚compile0m 52sHBASE-28463 passed
+1 💚shadedjars6m 28sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sHBASE-28463 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 23sthe patch passed
+1 💚compile0m 59sthe patch passed
+1 💚javac0m 59sthe patch passed
+1 💚shadedjars6m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 32sthe patch passed
_ Other Tests _
-1 ❌unit347m 14shbase-server in the patch failed.
376m 18s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5809
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bf07a665f134 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-28463 / a9d3170
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/testReport/
Max. process+thread count4437 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
wchevreuil merged commit b7bb8b9 into apache:HBASE-28463Apr 12, 2024
wchevreuil pushed a commit that referenced this pull request Apr 22, 2024
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
c1ea652
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Apr 25, 2024
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
9572f7d
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request May 20, 2024
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
99c412f
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
vinayakphegde added a commit to vinayakphegde/hbase that referenced this pull request May 21, 2024
@vinayakphegde
HBASE-28505 Implement enforcement to require Date Tiered Compaction f…
8bf4d0e
…or Time Range Data Tiering (apache#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request May 21, 2024
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
6ff8b06
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
jhungund pushed a commit to janardhanrh/hbase that referenced this pull request May 29, 2024
@vinayakphegde@jhungund
HBASE-28505 Implement enforcement to require Date Tiered Compaction f…
e056963
…or Time Range Data Tiering (apache#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Change-Id: I67f611e828c457f00df98fb58bcd1fd9b08f57da
wchevreuil pushed a commit that referenced this pull request Jun 24, 2025
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
db2e23f
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Jul 10, 2025
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
3e3064c
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Jul 11, 2025
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
025f685
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Aug 5, 2025
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
7525682
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Sep 1, 2025
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
2974949
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Sep 1, 2025
@vinayakphegde@wchevreuil
HBASE-28505 Implement enforcement to require Date Tiered Compaction f…
a21c8f7
…or Time Range Data Tiering (apache#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89
wchevreuil pushed a commit that referenced this pull request Sep 1, 2025
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
36cf624
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Sep 3, 2025
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
2a7860c
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Sep 3, 2025
@vinayakphegde@wchevreuil
HBASE-28505 Implement enforcement to require Date Tiered Compaction f…
76070ca
…or Time Range Data Tiering (apache#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89
wchevreuil pushed a commit that referenced this pull request Sep 3, 2025
@vinayakphegde@wchevreuil
HBASE-28505Implement enforcement to require Date Tiered Compaction f…
063e4cc
…or Time Range Data Tiering (#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 22, 2025
@vinayakphegde@wchevreuil
CDPD-89846: Backport HBASE-28463 Time Based Priority for BucketCache …
16463d0
…into cdh_main
HBASE-28505 Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering (apache#5809)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinayakphegde@Apache-HBase@wchevreuil