Uh oh!
There was an error while loading. Please reload this page.
HBASE-13798 TestFromClientSide* don't close the Table - #193
Merged
Conversation
Apache-HBase
commented
Apr 26, 2019
💔 -1 overall
This message was automatically generated. |
busbey
commented
Apr 26, 2019
Contributor
Well the unit tests hopefully are just a bad CI host. Let me go relaunch those. |
Apache-HBase
commented
Apr 26, 2019
💔 -1 overall
This message was automatically generated. |
busbey
commented
Apr 26, 2019
Contributor
much more reasonable! @anmolnar can you clean up the checkstyle complaints? looks like mostly improper line length handling. |
busbey
reviewed
Apr 26, 2019
busbey
left a comment
Contributor
There was a problem hiding this comment.
ugh. TestFromClientSide.testNull should be several tests instead of mixing up all of those "should/should not throw" conditions. Not your problem here, but filing a follow-on jira to make note of the need would be good.
Uh oh!
There was an error while loading. Please reload this page.
anmolnar
commented
Apr 30, 2019
ContributorAuthor
@busbey Agreed. Similarly it would be nice to split |
Apache-HBase
commented
Apr 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Apr 30, 2019
💔 -1 overall
This message was automatically generated. |
anmolnar
commented
May 6, 2019
ContributorAuthor
Rebased on latest master. I expect lots of checkstyle warnings again, so probably still not ready to commit. |
Apache-HBase
commented
May 6, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 7, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 8, 2019
💔 -1 overall
This message was automatically generated. |
anmolnar
commented
May 8, 2019
ContributorAuthor
@busbey@petersomogyi |
HorizonNet
commented
May 8, 2019
Contributor
@anmolnar The build only shows newly introduced violations. Let's wait for the latest build if they got resolved. |
Apache-HBase
commented
May 8, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 10, 2019
💔 -1 overall
This message was automatically generated. |
anmolnar
commented
May 10, 2019
ContributorAuthor
@petersomogyi Looks like we have a green build finally? |
petersomogyi
commented
May 11, 2019
Contributor
The latest verification looks good. I'm retriggering it once more. |
Apache-HBase
commented
May 11, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 13, 2019
💔 -1 overall
This message was automatically generated. |
This was referenced Jun 12, 2024
Merged
This was referenced Jun 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored test cases
TestFromClientSideandTestFromClientSide3to use try-with-resources for classes which are auto-closeable: Table, Scanner, etc.TestFromClientSide
Refactored all individual tests to close closeable resources properly. Doing this in setUp/tearDown methods is not beneficial, because most tests create their tables with custom parameters.
TestFromClientSide3
Initialisation of tables are pretty much the same in these tests, so I ended up writing setUp/tearDown methods. For tests which need custom initialisation I delete the created table first and let them create custom one instead.