Skip to content

HBASE-28558 Fix constructors for sub classes of Connection - #5861

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28558
May 1, 2024
Merged

HBASE-28558 Fix constructors for sub classes of Connection#5861
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28558

Conversation

@Apache9

@Apache9Apache9 commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Apr 29, 2024
@Apache9Apache9 mentioned this pull request Apr 29, 2024
Closed
@Apache-HBase

Apache-HBase commented Apr 29, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 57smaster passed
+1 💚compile1m 24smaster passed
+1 💚checkstyle0m 33smaster passed
+1 💚spotless0m 57sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 26smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 52sthe patch passed
+1 💚compile1m 37sthe patch passed
-0 ⚠️javac0m 43shbase-mapreduce generated 2 new + 197 unchanged - 2 fixed = 199 total (was 199)
+1 💚checkstyle0m 32sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 31sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 53spatch has no errors when running spotless:check.
+1 💚spotbugs1m 52sthe patch passed
_ Other Tests _
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
32m 37s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5861
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 03527c4b484e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4230c42
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-client hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 29, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 38smaster passed
+1 💚compile0m 38smaster passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 30sthe patch passed
+1 💚compile0m 38sthe patch passed
+1 💚javac0m 38sthe patch passed
+1 💚shadedjars5m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30sthe patch passed
_ Other Tests _
+1 💚unit1m 29shbase-client in the patch passed.
+1 💚unit14m 47shbase-mapreduce in the patch passed.
36m 47s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5861
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3f4bee2155e0 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4230c42
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/testReport/
Max. process+thread count2845 (vs. ulimit of 30000)
modulesC: hbase-client hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 29, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 55smaster passed
+1 💚compile0m 41smaster passed
+1 💚shadedjars5m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 34smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile0m 42sthe patch passed
+1 💚javac0m 42sthe patch passed
+1 💚shadedjars5m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sthe patch passed
_ Other Tests _
+1 💚unit1m 36shbase-client in the patch passed.
+1 💚unit17m 32shbase-mapreduce in the patch passed.
40m 21s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5861
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fc561ff8b7bd 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4230c42
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/testReport/
Max. process+thread count3252 (vs. ulimit of 30000)
modulesC: hbase-client hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 29, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 34smaster passed
+1 💚compile0m 46smaster passed
+1 💚shadedjars6m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 34sthe patch passed
+1 💚compile0m 47sthe patch passed
+1 💚javac0m 47sthe patch passed
+1 💚shadedjars6m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 32sthe patch passed
_ Other Tests _
+1 💚unit1m 42shbase-client in the patch passed.
+1 💚unit15m 3shbase-mapreduce in the patch passed.
41m 27s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5861
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f5cacce8adf7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4230c42
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/testReport/
Max. process+thread count2927 (vs. ulimit of 30000)
modulesC: hbase-client hbase-mapreduce U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

infraio
infraio approved these changes May 1, 2024
View reviewed changes

@infraioinfraio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

GeorryHuang
GeorryHuang approved these changes May 1, 2024
View reviewed changes

@GeorryHuangGeorryHuang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache9
Apache9 merged commit e9ced39 into apache:masterMay 1, 2024
Apache9 added a commit that referenced this pull request May 1, 2024
@Apache9
HBASE-28558Fix constructors for sub classes of Connection (#5861)
72b5c8f
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit e9ced39)
Apache9 added a commit that referenced this pull request May 1, 2024
@Apache9
HBASE-28558Fix constructors for sub classes of Connection (#5861)
951f335
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
(cherry picked from commit e9ced39)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request May 21, 2024
@Apache9@vinayakphegde
HBASE-28558 Fix constructors for sub classes of Connection (apache#5861)
721fe2b
Signed-off-by: Guanghao Zhang <zghao@apache.org>
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infraioinfraioinfraio approved these changes
@GeorryHuangGeorryHuangGeorryHuang approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@infraio@GeorryHuang