Skip to content

HBASE-28425 Allow specify cluster key without zookeeper in replication - #5865

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28425
May 24, 2024
Merged

HBASE-28425 Allow specify cluster key without zookeeper in replication#5865
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28425

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this May 1, 2024
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 6smaster passed
+1 💚compile5m 57smaster passed
+1 💚checkstyle1m 57smaster passed
+1 💚spotless0m 57sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 33sthe patch passed
+1 💚compile6m 5sthe patch passed
-0 ⚠️javac0m 48shbase-client generated 2 new + 102 unchanged - 0 fixed = 104 total (was 102)
-0 ⚠️javac3m 15shbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
-0 ⚠️javac0m 24shbase-testing-util generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
+1 💚checkstyle1m 49sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 30sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless1m 0spatch has no errors when running spotless:check.
+1 💚spotbugs5m 59sthe patch passed
_ Other Tests _
+1 💚asflicense1m 0sThe patch does not generate ASF License warnings.
54m 52s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5865
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 6c3094f6684d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 36smaster passed
+1 💚compile2m 6smaster passed
+1 💚shadedjars5m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 34smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 29sthe patch passed
+1 💚compile2m 4sthe patch passed
+1 💚javac2m 4sthe patch passed
+1 💚shadedjars5m 7spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 15shbase-client generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)
_ Other Tests _
+1 💚unit1m 54shbase-common in the patch passed.
+1 💚unit1m 28shbase-client in the patch passed.
+1 💚unit0m 33shbase-replication in the patch passed.
-1 ❌unit236m 50shbase-server in the patch failed.
-1 ❌unit15m 51shbase-mapreduce in the patch failed.
+1 💚unit3m 4shbase-testing-util in the patch passed.
289m 3s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fe964c898d37 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaTemurin-1.8.0_352-b08
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/testReport/
Max. process+thread count5092 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 45smaster passed
+1 💚compile3m 22smaster passed
+1 💚shadedjars6m 18sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 11smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 10sthe patch passed
+1 💚compile2m 44sthe patch passed
+1 💚javac2m 44sthe patch passed
+1 💚shadedjars5m 22spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-client generated 1 new + 44 unchanged - 0 fixed = 45 total (was 44)
_ Other Tests _
+1 💚unit2m 20shbase-common in the patch passed.
+1 💚unit1m 37shbase-client in the patch passed.
+1 💚unit0m 35shbase-replication in the patch passed.
-1 ❌unit258m 23shbase-server in the patch failed.
-1 ❌unit21m 7shbase-mapreduce in the patch failed.
+1 💚unit2m 42shbase-testing-util in the patch passed.
322m 24s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d14a7d468686 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-11.0.17+8
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/testReport/
Max. process+thread count4776 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 45smaster passed
+1 💚compile2m 57smaster passed
+1 💚shadedjars6m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 58smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile2m 33sthe patch passed
+1 💚javac2m 33sthe patch passed
+1 💚shadedjars5m 47spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 21shbase-client generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26)
_ Other Tests _
+1 💚unit2m 48shbase-common in the patch passed.
+1 💚unit1m 44shbase-client in the patch passed.
+1 💚unit0m 35shbase-replication in the patch passed.
-1 ❌unit266m 2shbase-server in the patch failed.
-1 ❌unit17m 1shbase-mapreduce in the patch failed.
+1 💚unit2m 0shbase-testing-util in the patch passed.
326m 0s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8b446d56e6bf 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-17.0.10+7
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk17-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/testReport/
Max. process+thread count5998 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@anmolnaranmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 12smaster passed
+1 💚compile5m 10smaster passed
+1 💚checkstyle1m 29smaster passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 1smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile5m 15sthe patch passed
-0 ⚠️javac0m 41shbase-client generated 2 new + 102 unchanged - 0 fixed = 104 total (was 102)
-0 ⚠️javac2m 53shbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
-0 ⚠️javac0m 20shbase-testing-util generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
+1 💚checkstyle1m 29sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck5m 44sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
+1 💚spotbugs4m 49sthe patch passed
_ Other Tests _
+1 💚asflicense0m 50sThe patch does not generate ASF License warnings.
45m 22s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5865
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux ae26eac3acad 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall2m 57smaster passed
+1 💚compile2m 12smaster passed
+1 💚shadedjars5m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 29smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile2m 12sthe patch passed
+1 💚javac2m 12sthe patch passed
+1 💚shadedjars5m 28spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 16shbase-client generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26)
_ Other Tests _
+1 💚unit2m 8shbase-common in the patch passed.
+1 💚unit1m 35shbase-client in the patch passed.
+1 💚unit0m 26shbase-replication in the patch passed.
+1 💚unit206m 47shbase-server in the patch passed.
-1 ❌unit13m 40shbase-mapreduce in the patch failed.
+1 💚unit2m 6shbase-testing-util in the patch passed.
257m 25s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0a84b36c59f8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-17.0.10+7
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk17-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/testReport/
Max. process+thread count5262 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 46smaster passed
+1 💚compile2m 21smaster passed
+1 💚shadedjars5m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 43smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
+1 💚compile2m 19sthe patch passed
+1 💚javac2m 19sthe patch passed
+1 💚shadedjars5m 9spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-client generated 1 new + 44 unchanged - 0 fixed = 45 total (was 44)
_ Other Tests _
+1 💚unit2m 20shbase-common in the patch passed.
+1 💚unit1m 40shbase-client in the patch passed.
+1 💚unit0m 35shbase-replication in the patch passed.
+1 💚unit234m 9shbase-server in the patch passed.
-1 ❌unit15m 28shbase-mapreduce in the patch failed.
+1 💚unit2m 22shbase-testing-util in the patch passed.
287m 41s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8912c2173958 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-11.0.17+8
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/testReport/
Max. process+thread count4615 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 36smaster passed
+1 💚compile2m 7smaster passed
+1 💚shadedjars5m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 24sthe patch passed
+1 💚compile2m 7sthe patch passed
+1 💚javac2m 7sthe patch passed
+1 💚shadedjars5m 8spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 15shbase-client generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)
_ Other Tests _
+1 💚unit1m 55shbase-common in the patch passed.
+1 💚unit1m 29shbase-client in the patch passed.
+1 💚unit0m 33shbase-replication in the patch passed.
+1 💚unit237m 15shbase-server in the patch passed.
-1 ❌unit15m 24shbase-mapreduce in the patch failed.
+1 💚unit2m 35shbase-testing-util in the patch passed.
289m 48s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 93e49b324237 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaTemurin-1.8.0_352-b08
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/testReport/
Max. process+thread count4950 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 12smaster passed
+1 💚compile5m 11smaster passed
+1 💚checkstyle1m 30smaster passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 9smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile5m 8sthe patch passed
+1 💚javac5m 8sthe patch passed
+1 💚checkstyle1m 29sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck5m 45sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 43spatch has no errors when running spotless:check.
+1 💚spotbugs4m 53sthe patch passed
_ Other Tests _
+1 💚asflicense0m 49sThe patch does not generate ASF License warnings.
45m 44s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5865
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux f79ea3863402 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 50smaster passed
+1 💚compile2m 27smaster passed
+1 💚shadedjars5m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 52sthe patch passed
+1 💚compile2m 27sthe patch passed
+1 💚javac2m 27sthe patch passed
+1 💚shadedjars5m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 44sthe patch passed
_ Other Tests _
+1 💚unit2m 34shbase-common in the patch passed.
+1 💚unit1m 30shbase-client in the patch passed.
+1 💚unit0m 33shbase-replication in the patch passed.
+1 💚unit229m 55shbase-server in the patch passed.
+1 💚unit15m 30shbase-mapreduce in the patch passed.
+1 💚unit1m 58shbase-testing-util in the patch passed.
283m 52s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 00218cbf2ba2 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/testReport/
Max. process+thread count5584 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 47smaster passed
+1 💚compile2m 20smaster passed
+1 💚shadedjars5m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 42smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile2m 20sthe patch passed
+1 💚javac2m 20sthe patch passed
+1 💚shadedjars5m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 43sthe patch passed
_ Other Tests _
+1 💚unit2m 20shbase-common in the patch passed.
+1 💚unit1m 38shbase-client in the patch passed.
+1 💚unit0m 35shbase-replication in the patch passed.
-1 ❌unit328m 50shbase-server in the patch failed.
+1 💚unit28m 36shbase-mapreduce in the patch passed.
+1 💚unit3m 34shbase-testing-util in the patch passed.
399m 24s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 32eb29137d11 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/testReport/
Max. process+thread count4591 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 28smaster passed
+1 💚compile2m 5smaster passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 31sthe patch passed
+1 💚compile2m 5sthe patch passed
+1 💚javac2m 5sthe patch passed
+1 💚shadedjars5m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35sthe patch passed
_ Other Tests _
+1 💚unit1m 55shbase-common in the patch passed.
+1 💚unit1m 29shbase-client in the patch passed.
+1 💚unit0m 32shbase-replication in the patch passed.
-1 ❌unit331m 28shbase-server in the patch failed.
+1 💚unit28m 37shbase-mapreduce in the patch passed.
+1 💚unit3m 36shbase-testing-util in the patch passed.
405m 57s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 064e347fdeba 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3d66866
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/testReport/
Max. process+thread count4653 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 57smaster passed
+1 💚compile5m 14smaster passed
+1 💚checkstyle1m 42smaster passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 16smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile5m 11sthe patch passed
+1 💚javac5m 11sthe patch passed
+1 💚checkstyle1m 38sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck5m 3sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 43spatch has no errors when running spotless:check.
+1 💚spotbugs5m 2sthe patch passed
_ Other Tests _
+1 💚asflicense0m 59sThe patch does not generate ASF License warnings.
44m 49s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5865
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 5de2d44bf76e 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 23fa363
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 7smaster passed
+1 💚compile2m 38smaster passed
+1 💚shadedjars5m 57sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile2m 28sthe patch passed
+1 💚javac2m 28sthe patch passed
+1 💚shadedjars5m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 44sthe patch passed
_ Other Tests _
+1 💚unit2m 35shbase-common in the patch passed.
+1 💚unit1m 29shbase-client in the patch passed.
+1 💚unit0m 34shbase-replication in the patch passed.
+1 💚unit234m 29shbase-server in the patch passed.
+1 💚unit14m 15shbase-mapreduce in the patch passed.
+1 💚unit1m 58shbase-testing-util in the patch passed.
288m 51s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0536ff82016f 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 23fa363
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/testReport/
Max. process+thread count5804 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall2m 30smaster passed
+1 💚compile2m 6smaster passed
+1 💚shadedjars5m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 34smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 31sthe patch passed
+1 💚compile2m 9sthe patch passed
+1 💚javac2m 9sthe patch passed
+1 💚shadedjars5m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 33sthe patch passed
_ Other Tests _
+1 💚unit1m 56shbase-common in the patch passed.
+1 💚unit1m 29shbase-client in the patch passed.
+1 💚unit0m 33shbase-replication in the patch passed.
+1 💚unit238m 20shbase-server in the patch passed.
+1 💚unit15m 5shbase-mapreduce in the patch passed.
+1 💚unit2m 35shbase-testing-util in the patch passed.
290m 14s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 29c60f612461 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 23fa363
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/testReport/
Max. process+thread count4586 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 47sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 54smaster passed
+1 💚compile3m 7smaster passed
+1 💚shadedjars6m 4sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 50smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 10sthe patch passed
+1 💚compile2m 36sthe patch passed
+1 💚javac2m 36sthe patch passed
+1 💚shadedjars5m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 43sthe patch passed
_ Other Tests _
+1 💚unit2m 22shbase-common in the patch passed.
+1 💚unit1m 37shbase-client in the patch passed.
+1 💚unit0m 35shbase-replication in the patch passed.
+1 💚unit259m 37shbase-server in the patch passed.
+1 💚unit18m 47shbase-mapreduce in the patch passed.
+1 💚unit2m 45shbase-testing-util in the patch passed.
321m 34s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8b72052cada4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 23fa363
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/testReport/
Max. process+thread count4599 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a couple questions and a couple API change requests.

* Validate the given {@code uri}.
* @throws IOException if this is not a valid connection registry URI.
*/
void validate(URI uri) throws IOException;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this interface should be boolean isValid(URI), and then the caller is free to throw or not.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throwing exception could let the upper layer know the details about why this is not valid.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I understand. This enforces try-catch flow control where if/else would be better. For this kind of thing, I really like the Result based API that is catching on in other languages.

Anyway, maybe it should throw something besides IOException ? IllegatStateException, for example?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like UnsupportedProtocol or IllegalArgument? But IllegalArgument is a RuntimeException, developers may miss to catch it and cause some fatal errors...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a RuntimeException is okay. It happens often enough in the JDK libraries, where they will also add a note about it in the javadoc.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the implementation, now we have these errors

No protocol scheme
No factory registered for the scheme

For zk based registry
Empty zk server string, i.e, empty uri authority
Empty zk parent path, i.e, empty uri path

For rpc based registry
Empty bootstrap nodes, i.e, empty uri authority

In general, there are no accurate exception types for these errors, and since we may add new checks for different registry implementations in the future, I prefer we still keep the throws IOException declaration, and can file new issues to add some specific exceptions which extend HBaseIOException for these cases.


import java.io.IOException;
import java.net.URI;
import org.apache.commons.lang3.StringUtils;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forget which dependencies we expose transitively. Should we be using a shaded version of this class?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check if we have commons-lang3 shaded.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not shade commons-lang3 in hbase-thirdparty

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks for checking. I wonder if we should.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commons-lang3 is not likely to introduce big conflicts. It changed its package name to commons-lang3 from commons-lang when introducing breaking changes.


@Override
protected String getClusterKey(HBaseTestingUtil util) throws Exception {
// TODO: VerifyReplication does not support connection uri yet, so here we need to use cluster

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue filed for this TODO?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

* Validate the given {@code uri}.
* @throws IOException if this is not a valid connection registry URI.
*/
void validate(URI uri) throws IOException;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I understand. This enforces try-catch flow control where if/else would be better. For this kind of thing, I really like the Result based API that is catching on in other languages.

Anyway, maybe it should throw something besides IOException ? IllegatStateException, for example?


import java.io.IOException;
import java.net.URI;
import org.apache.commons.lang3.StringUtils;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.


@Override
protected String getClusterKey(HBaseTestingUtil util) throws Exception {
// TODO: VerifyReplication does not support connection uri yet, so here we need to use cluster

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

try (Connection conn = ConnectionFactory.createConnection(connectionUri, conf);
Admin admin = conn.getAdmin()) {
peerClusterId =
admin.getClusterMetrics(EnumSet.of(ClusterMetrics.Option.CLUSTER_ID)).getClusterId();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be nice, but I guess not urgent.

} catch (IOException | KeeperException e) {
// we just want to check whether we will replicate to the same cluster, so if we get an error
// while getting the cluster id of the peer cluster, it means we are not connecting to
// ourselves, as we are still alive. So here we just log the error and continue

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nod

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 49smaster passed
+1 💚compile5m 43smaster passed
+1 💚checkstyle1m 36smaster passed
+1 💚spotless0m 57sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 34smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 38sthe patch passed
+1 💚compile6m 16sthe patch passed
+1 💚javac6m 16sthe patch passed
+1 💚checkstyle1m 48sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 26sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 52spatch has no errors when running spotless:check.
+1 💚spotbugs5m 59sthe patch passed
_ Other Tests _
+1 💚asflicense0m 55sThe patch does not generate ASF License warnings.
52m 43s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5865
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 1f5d7d14ade1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d85574a
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/5/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 51smaster passed
+1 💚compile2m 20smaster passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 42smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile2m 19sthe patch passed
+1 💚javac2m 19sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 41sthe patch passed
_ Other Tests _
+1 💚unit2m 21shbase-common in the patch passed.
+1 💚unit1m 38shbase-client in the patch passed.
+1 💚unit0m 35shbase-replication in the patch passed.
-1 ❌unit14m 2shbase-server in the patch failed.
+1 💚unit15m 45shbase-mapreduce in the patch passed.
+1 💚unit2m 17shbase-testing-util in the patch passed.
64m 56s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5b63fc57ccd3 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d85574a
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/5/testReport/
Max. process+thread count2976 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/5/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 34smaster passed
+1 💚compile5m 54smaster passed
+1 💚checkstyle1m 49smaster passed
+1 💚spotless1m 8sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 52smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 47sthe patch passed
+1 💚compile6m 10sthe patch passed
+1 💚javac6m 10sthe patch passed
+1 💚checkstyle1m 46sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 19sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 56spatch has no errors when running spotless:check.
+1 💚spotbugs6m 0sthe patch passed
_ Other Tests _
+1 💚asflicense0m 57sThe patch does not generate ASF License warnings.
54m 12s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5865
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 646509145a3c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d85574a
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 53smaster passed
+1 💚compile2m 19smaster passed
+1 💚shadedjars5m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 43smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 45sthe patch passed
+1 💚compile2m 19sthe patch passed
+1 💚javac2m 19sthe patch passed
+1 💚shadedjars5m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 35sthe patch passed
_ Other Tests _
+1 💚unit2m 20shbase-common in the patch passed.
+1 💚unit1m 38shbase-client in the patch passed.
+1 💚unit0m 35shbase-replication in the patch passed.
+1 💚unit241m 19shbase-server in the patch passed.
+1 💚unit20m 15shbase-mapreduce in the patch passed.
+1 💚unit2m 43shbase-testing-util in the patch passed.
299m 59s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 75804e9eab5a 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d85574a
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/testReport/
Max. process+thread count4676 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 24smaster passed
+1 💚compile2m 6smaster passed
+1 💚shadedjars5m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 34smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile2m 6sthe patch passed
+1 💚javac2m 6sthe patch passed
+1 💚shadedjars5m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 32sthe patch passed
_ Other Tests _
+1 💚unit1m 58shbase-common in the patch passed.
+1 💚unit1m 31shbase-client in the patch passed.
+1 💚unit0m 33shbase-replication in the patch passed.
+1 💚unit246m 40shbase-server in the patch passed.
+1 💚unit21m 18shbase-mapreduce in the patch passed.
+1 💚unit3m 4shbase-testing-util in the patch passed.
305m 25s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 27886aaeeedf 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d85574a
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/testReport/
Max. process+thread count5026 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 18smaster passed
+1 💚compile3m 1smaster passed
+1 💚shadedjars6m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 12smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 34sthe patch passed
+1 💚compile2m 56sthe patch passed
+1 💚javac2m 56sthe patch passed
+1 💚shadedjars6m 4spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 48sthe patch passed
_ Other Tests _
+1 💚unit2m 46shbase-common in the patch passed.
+1 💚unit1m 58shbase-client in the patch passed.
+1 💚unit0m 34shbase-replication in the patch passed.
+1 💚unit274m 19shbase-server in the patch passed.
+1 💚unit21m 58shbase-mapreduce in the patch passed.
+1 💚unit2m 16shbase-testing-util in the patch passed.
340m 40s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5865
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 802af54fdfae 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d85574a
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/testReport/
Max. process+thread count4695 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-replication hbase-server hbase-mapreduce hbase-testing-util U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5865/6/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
ContributorAuthor

Going to merge this today if no other concerns.

@Apache9
Apache9 merged commit c5e6d82 into apache:masterMay 24, 2024
Apache9 added a commit that referenced this pull request May 24, 2024
#5865)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Reviewed-by: Andor Molnár <andor@apache.org>
(cherry picked from commit c5e6d82)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@ndimiduk@anmolnar