Skip to content

HBASE-28572 Remove deprecated methods in thrift module - #5882

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28572
May 17, 2024
Merged

HBASE-28572 Remove deprecated methods in thrift module#5882
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28572

Conversation

@Apache9

@Apache9Apache9 commented May 8, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this May 8, 2024
@Apache-HBase

Apache-HBase commented May 8, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 21smaster passed
+1 💚compile0m 50smaster passed
+1 💚shadedjars5m 54sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 49smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile0m 45sthe patch passed
+1 💚javac0m 45sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 47sthe patch passed
_ Other Tests _
+1 💚unit7m 49shbase-thrift in the patch passed.
+1 💚unit1m 52shbase-examples in the patch passed.
32m 36s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5882
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 060227abee23 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 23fa363
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/testReport/
Max. process+thread count1321 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 8, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 15sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 15smaster passed
+1 💚compile0m 57smaster passed
+1 💚shadedjars7m 28sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 50smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 38sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚shadedjars5m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
+1 💚unit6m 52shbase-thrift in the patch passed.
+1 💚unit2m 0shbase-examples in the patch passed.
32m 40s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5882
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ac32f66bf879 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 23fa363
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/testReport/
Max. process+thread count1384 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 8, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 22smaster passed
+1 💚compile1m 28smaster passed
+1 💚checkstyle0m 42smaster passed
+1 💚spotless0m 52sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 43smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile1m 9sthe patch passed
+1 💚javac1m 9sthe patch passed
+1 💚checkstyle0m 41sthe patch passed
-0 ⚠️pylint0m 33sThe patch generated 149 new + 945 unchanged - 35 fixed = 1094 total (was 980)
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck6m 6sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless1m 2spatch has no errors when running spotless:check.
+1 💚spotbugs2m 27sthe patch passed
_ Other Tests _
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
34m 36s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5882
Optional Testsdupname asflicense javac spotless pylint shellcheck shelldocs spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 42408d858cbc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 23fa363
Default JavaEclipse Adoptium-11.0.17+8
pylinthttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-general-check/output/diff-patch-pylint.txt
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0 spotbugs=4.7.3 pylint=2.15.5
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 8, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 31smaster passed
+1 💚compile0m 54smaster passed
+1 💚shadedjars6m 27sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 26sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars7m 16spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sthe patch passed
_ Other Tests _
+1 💚unit6m 44shbase-thrift in the patch passed.
+1 💚unit2m 9shbase-examples in the patch passed.
35m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5882
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 87b838d0823b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 23fa363
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/testReport/
Max. process+thread count1658 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ddupg
ddupg approved these changes May 17, 2024
View reviewed changes

@ddupgddupg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9
Apache9 merged commit 0db26ec into apache:masterMay 17, 2024
Apache9 added a commit that referenced this pull request May 17, 2024
@Apache9
HBASE-28572Remove deprecated methods in thrift module (#5882)
0fa92e6
Signed-off-by: Xin Sun <sunxin@apache.org>
(cherry picked from commit 0db26ec)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request May 21, 2024
@Apache9@vinayakphegde
HBASE-28572 Remove deprecated methods in thrift module (apache#5882)
064bf6f
Signed-off-by: Xin Sun <sunxin@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddupgddupgddupg approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@ddupg