Skip to content

Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2 - #5915

Merged
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:28568-branch-2
May 18, 2024
Merged

Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2#5915
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:28568-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented May 17, 2024

Copy link
Copy Markdown
Member

The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in that root dir).

The incremental backup set can only shrink when backups are deleted. However, the implementation was incorrect, causing this set to never be able to shrink.

Reviewed-by: Ray Mattingly rmdmattingly@gmail.com

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label May 17, 2024
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
DieterDP-ngand others added 2 commits May 17, 2024 18:34
@DieterDP-ng@ndimiduk
HBASE-28568 Incremental backup set does not correctly shrink (apache#…
b8ab4dd
…5876)
The incremental backup set is the set of tables included when
an incremental backup is created, it is managed per backup
root dir and contains all tables that are present in at least
one backup (in that root dir).
The incremental backup set can only shrink when backups are
deleted. However, the implementation was incorrect, causing this
set to never be able to shrink.
Reviewed-by: Ray Mattingly <rmdmattingly@gmail.com>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@ndimiduk
HBASE-28568 Incremental backup set does not correctly shrink (addendu…
c4a8336
…m) (apache#5917)
Import the correct shaded Guava and run spotless:apply.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@Apache-HBase

Apache-HBase commented May 17, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 58sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 0sbranch-2 passed
+1 💚compile0m 37sbranch-2 passed
+1 💚checkstyle0m 12sbranch-2 passed
+1 💚spotless0m 54sbranch has no errors when running spotless:check.
+1 💚spotbugs0m 38sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 13sthe patch passed
+1 💚compile0m 28sthe patch passed
+1 💚javac0m 28shbase-backup generated 0 new + 104 unchanged - 2 fixed = 104 total (was 106)
+1 💚checkstyle0m 11sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 23sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚spotless1m 1spatch has no errors when running spotless:check.
+1 💚spotbugs0m 56sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
26m 22s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5915
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 249ad14c30c4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / fcaffb8
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count75 (vs. ulimit of 30000)
modulesC: hbase-backup U: hbase-backup
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 17, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 17sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 6sbranch-2 passed
+1 💚compile0m 19sbranch-2 passed
+1 💚shadedjars5m 27sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 17sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile0m 18sthe patch passed
+1 💚javac0m 18sthe patch passed
+1 💚shadedjars5m 21spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 15shbase-backup generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚unit10m 52shbase-backup in the patch passed.
29m 55s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5915
Optional Testsjavac javadoc unit shadedjars compile
unameLinux aef665e3ff0b 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / fcaffb8
Default JavaEclipse Adoptium-11.0.17+8
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-backup.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/testReport/
Max. process+thread count3127 (vs. ulimit of 30000)
modulesC: hbase-backup U: hbase-backup
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 17, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 44sbranch-2 passed
+1 💚compile0m 17sbranch-2 passed
+1 💚shadedjars6m 18sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 15sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 55sthe patch passed
+1 💚compile0m 17sthe patch passed
+1 💚javac0m 17sthe patch passed
+1 💚shadedjars5m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 12sthe patch passed
_ Other Tests _
+1 💚unit11m 54shbase-backup in the patch passed.
33m 19s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5915
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 145b62c6e4d6 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / fcaffb8
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/testReport/
Max. process+thread count3455 (vs. ulimit of 30000)
modulesC: hbase-backup U: hbase-backup
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5915/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 794f6b4 into apache:branch-2May 18, 2024
@ndimiduk
ndimiduk deleted the 28568-branch-2 branch May 18, 2024 17:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@DieterDP-ng