Skip to content

HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars - #5918

Merged
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:28605-ban-import-hadoop-thirdparty
May 22, 2024
Merged

HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars#5918
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:28605-ban-import-hadoop-thirdparty

Conversation

@ndimiduk

Copy link
Copy Markdown
Member

This change results in this error on master at 3a3dd66e21.

[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
@ndimiduk
ndimidukforce-pushed the 28605-ban-import-hadoop-thirdparty branch from ba6ab0f to 6f6dce9CompareMay 21, 2024 08:10
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 3smaster passed
+1 💚compile5m 4smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 37sthe patch passed
+1 💚compile4m 59sthe patch passed
+1 💚javac4m 59sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck5m 4sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
29m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5918
Optional Testsdupname asflicense javac hadoopcheck spotless xml compile
unameLinux 53f277e12a7c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8a5337b
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 5smaster passed
+1 💚compile2m 2smaster passed
+1 💚shadedjars5m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 5smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile2m 4sthe patch passed
+1 💚javac2m 4sthe patch passed
+1 💚shadedjars5m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 5sthe patch passed
_ Other Tests _
-1 ❌unit294m 8sroot in the patch failed.
324m 32s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5918
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ccc5b4761fd8 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8a5337b
Default JavaEclipse Adoptium-17.0.10+7
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/testReport/
Max. process+thread count5543 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 57smaster passed
+1 💚compile1m 59smaster passed
+1 💚shadedjars5m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 56smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile1m 58sthe patch passed
+1 💚javac1m 58sthe patch passed
+1 💚shadedjars5m 13spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 53sthe patch passed
_ Other Tests _
-1 ❌unit340m 40sroot in the patch failed.
371m 32s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5918
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b7a5fbf3fa34 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8a5337b
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/testReport/
Max. process+thread count7885 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 13sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 30smaster passed
+1 💚compile1m 39smaster passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 24smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 23sthe patch passed
+1 💚compile1m 37sthe patch passed
+1 💚javac1m 37sthe patch passed
+1 💚shadedjars5m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 25sthe patch passed
_ Other Tests _
+1 💚unit414m 15sroot in the patch passed.
442m 24s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5918
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 328c2990e9a2 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8a5337b
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/testReport/
Max. process+thread count9149 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5918/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 3b18ba6 into apache:masterMay 22, 2024
@ndimiduk
ndimiduk deleted the 28605-ban-import-hadoop-thirdparty branch May 22, 2024 08:05
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request May 22, 2024
…he#5918)
This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request May 22, 2024
…he#5918)
This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request May 22, 2024
…he#5918)
This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request May 22, 2024
…he#5918)
This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
ndimiduk added a commit that referenced this pull request May 23, 2024
This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
ndimiduk added a commit that referenced this pull request May 23, 2024
This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
ndimiduk added a commit that referenced this pull request May 23, 2024
This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
ndimiduk added a commit that referenced this pull request May 23, 2024
This change results in this error on master at `3a3dd66e21`.
```
[WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message:
Banned imports detected:
Reason: Use shaded version in hbase-thirdparty
in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java
org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**)
```
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ndimiduk@Apache-HBase@bbeaudreault@Apache9