Uh oh!
There was an error while loading. Please reload this page.
HBASE-22280 Separate read/write handler for priority request(especial… - #202
Conversation
Apache-HBase
commented
Apr 30, 2019
💔 -1 overall
This message was automatically generated. |
carp84
left a comment
There was a problem hiding this comment.
Please add a new UT case to cover MetaRWQueueRpcExecutor
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
carp84
commented
May 14, 2019
Please also check the |
Apache-HBase
commented
Jun 11, 2019
💔 -1 overall
This message was automatically generated. |
saintstack
commented
Jun 24, 2019
Any updates here @binlijin ? Thanks. |
@saintstack i am sorry that i can not do the contribution now for some reason, someone else can take it over. |
Apache-HBase
commented
Jul 12, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 15, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 16, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 17, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 20, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 22, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 31, 2019
💔 -1 overall
This message was automatically generated. |
carp84
left a comment
There was a problem hiding this comment.
Checking the UT result we could see below error:
[ERROR] Failures:
[ERROR] TestReportOnlineRegionsRace.testRace:167 Waiting timed out after [10,000] msec
[ERROR] Errors:
[ERROR] TestReportOnlineRegionsRace.setUp:130 » TimeoutIO java.util.concurrent.Timeout...
I checked in local environment and reproduced the error, and there's no such issue if we revert the commit of this PR, so this is a regression must be fixed.
binlijin
commented
Nov 21, 2019
@carp84 fix the ut, the test need at least two write handler when use separate read/write handlers. |
Apache-HBase
commented
Nov 21, 2019
💔 -1 overall
This message was automatically generated. |
carp84
commented
Dec 5, 2019
From the latest UT result I could see below failure/error, please double check whether they're related to changes here @binlijin . Thanks.
|
binlijin
commented
Dec 5, 2019
@carp84 run this tests and passed locally, they're not related to the patch. |
carp84
left a comment
There was a problem hiding this comment.
Thanks for the confirmation, then everything LGTM, +1.
#202) Signed-off-by: Yu Li <liyu@apache.org>
#202) Signed-off-by: Yu Li <liyu@apache.org>
…ly for meta).