Skip to content

HBASE-22280 Separate read/write handler for priority request(especial… - #202

Merged
binlijin merged 2 commits into
apache:masterfrom
binlijin:HBASE-22280
Dec 9, 2019
Merged

HBASE-22280 Separate read/write handler for priority request(especial…#202
binlijin merged 2 commits into
apache:masterfrom
binlijin:HBASE-22280

Conversation

@binlijin

Copy link
Copy Markdown
Contributor

…ly for meta).

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec162Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author1The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall269master passed
+1compile55master passed
+1checkstyle68master passed
+1shadedjars265branch has no errors when building our shaded downstream artifacts.
+1findbugs210master passed
+1javadoc35master passed
_ Patch Compile Tests _
-1mvninstall167root in the patch failed.
+1compile54the patch passed
+1javac54the patch passed
-1checkstyle68hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace0The patch has no whitespace issues.
-1shadedjars214patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck119The patch causes 11 errors with Hadoop v2.7.4.
-1hadoopcheck246The patch causes 11 errors with Hadoop v3.0.0.
+1findbugs215the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit53hbase-server in the patch failed.
+1asflicense14The patch does not generate ASF License warnings.
2210
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a7a658b46f6e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / f9f6354
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-javac-2.7.4.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-javac-3.0.0.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/testReport/
Max. process+thread count96 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@carp84carp84 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new UT case to cover MetaRWQueueRpcExecutor

@carp84

Copy link
Copy Markdown
Member

Please also check the mvninstall, checkstyle and UT error reported by robot

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec30Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall349master passed
+1compile85master passed
+1checkstyle79master passed
+1shadedjars345branch has no errors when building our shaded downstream artifacts.
+1findbugs418master passed
+1javadoc52master passed
_ Patch Compile Tests _
-1mvninstall267root in the patch failed.
+1compile90the patch passed
+1javac90the patch passed
-1checkstyle85hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace0The patch has no whitespace issues.
-1shadedjars315patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck184The patch causes 11 errors with Hadoop v2.8.5.
-1hadoopcheck368The patch causes 11 errors with Hadoop v2.9.2.
-1hadoopcheck570The patch causes 11 errors with Hadoop v3.1.2.
+1findbugs345the patch passed
+1javadoc55the patch passed
_ Other Tests _
-1unit98hbase-server in the patch failed.
+1asflicense19The patch does not generate ASF License warnings.
3296
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 4571e48797fb 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / ada772a
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/testReport/
Max. process+thread count50 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack

Copy link
Copy Markdown
Contributor

Any updates here @binlijin ? Thanks.

@binlijin

binlijin commented Jun 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@saintstack i am sorry that i can not do the contribution now for some reason, someone else can take it over.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec31Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall230master passed
+1compile50master passed
+1checkstyle65master passed
+1shadedjars261branch has no errors when building our shaded downstream artifacts.
+1findbugs204master passed
+1javadoc30master passed
_ Patch Compile Tests _
-1mvninstall155root in the patch failed.
+1compile53the patch passed
+1javac53the patch passed
-1checkstyle67hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace0The patch has no whitespace issues.
-1shadedjars207patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck115The patch causes 11 errors with Hadoop v2.8.5.
-1hadoopcheck229The patch causes 11 errors with Hadoop v2.9.2.
-1hadoopcheck349The patch causes 11 errors with Hadoop v3.1.2.
+1findbugs207the patch passed
+1javadoc33the patch passed
_ Other Tests _
-1unit55hbase-server in the patch failed.
+1asflicense13The patch does not generate ASF License warnings.
2068
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux abb2e4ccaa87 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 438bf32
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/testReport/
Max. process+thread count96 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec31Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall232master passed
+1compile53master passed
+1checkstyle67master passed
+1shadedjars268branch has no errors when building our shaded downstream artifacts.
+1findbugs206master passed
+1javadoc34master passed
_ Patch Compile Tests _
-1mvninstall157root in the patch failed.
+1compile54the patch passed
+1javac54the patch passed
-1checkstyle67hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace1The patch has no whitespace issues.
-1shadedjars211patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck116The patch causes 11 errors with Hadoop v2.8.5.
-1hadoopcheck235The patch causes 11 errors with Hadoop v2.9.2.
-1hadoopcheck357The patch causes 11 errors with Hadoop v3.1.2.
+1findbugs215the patch passed
+1javadoc33the patch passed
_ Other Tests _
-1unit54hbase-server in the patch failed.
+1asflicense12The patch does not generate ASF License warnings.
2115
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 99acbbc184e2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 74731c2
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/testReport/
Max. process+thread count96 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/4/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec32Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall255master passed
+1compile56master passed
+1checkstyle70master passed
+1shadedjars274branch has no errors when building our shaded downstream artifacts.
+1findbugs222master passed
+1javadoc31master passed
_ Patch Compile Tests _
-1mvninstall162root in the patch failed.
+1compile53the patch passed
+1javac53the patch passed
-1checkstyle67hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace0The patch has no whitespace issues.
-1shadedjars216patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck128The patch causes 11 errors with Hadoop v2.8.5.
-1hadoopcheck249The patch causes 11 errors with Hadoop v2.9.2.
-1hadoopcheck371The patch causes 11 errors with Hadoop v3.1.2.
+1findbugs228the patch passed
+1javadoc35the patch passed
_ Other Tests _
-1unit53hbase-server in the patch failed.
+1asflicense15The patch does not generate ASF License warnings.
2201
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 68b1ac49ea09 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / cc38de1
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/testReport/
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/5/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec73Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1mvninstall80root in master failed.
-1compile38hbase-server in master failed.
+1checkstyle65master passed
+1shadedjars250branch has no errors when building our shaded downstream artifacts.
+1findbugs225master passed
+1javadoc32master passed
_ Patch Compile Tests _
-1mvninstall13root in the patch failed.
-1compile35hbase-server in the patch failed.
-1javac35hbase-server in the patch failed.
-1checkstyle63hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace0The patch has no whitespace issues.
-1shadedjars201patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck10The patch causes 10 errors with Hadoop v2.8.5.
-1hadoopcheck19The patch causes 10 errors with Hadoop v2.9.2.
-1hadoopcheck29The patch causes 10 errors with Hadoop v3.1.2.
+1findbugs222the patch passed
+1javadoc33the patch passed
_ Other Tests _
-1unit33hbase-server in the patch failed.
+1asflicense9The patch does not generate ASF License warnings.
1464
SubsystemReport/Notes
DockerClient=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a540931346bc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 72e58a8
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/branch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/branch-compile-hbase-server.txt
findbugsv3.1.11
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-compile-hbase-server.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-compile-hbase-server.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/testReport/
Max. process+thread count96 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/6/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec188Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1mvninstall250root in master failed.
+1compile56master passed
+1checkstyle62master passed
+1shadedjars267branch has no errors when building our shaded downstream artifacts.
+1findbugs221master passed
+1javadoc31master passed
_ Patch Compile Tests _
-1mvninstall157root in the patch failed.
+1compile50the patch passed
+1javac50the patch passed
-1checkstyle67hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace0The patch has no whitespace issues.
-1shadedjars205patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck112The patch causes 11 errors with Hadoop v2.8.5.
-1hadoopcheck233The patch causes 11 errors with Hadoop v2.9.2.
-1hadoopcheck361The patch causes 11 errors with Hadoop v3.1.2.
+1findbugs149the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit54hbase-server in the patch failed.
+1asflicense11The patch does not generate ASF License warnings.
2226
SubsystemReport/Notes
DockerClient=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux cb3b4619b2b5 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 00075ea
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/branch-mvninstall-root.txt
findbugsv3.1.11
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/testReport/
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/7/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec55Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall265master passed
+1compile61master passed
+1checkstyle73master passed
+1shadedjars301branch has no errors when building our shaded downstream artifacts.
+1javadoc36master passed
0spotbugs285Used deprecated FindBugs config; considering switching to SpotBugs.
+1findbugs282master passed
_ Patch Compile Tests _
-1mvninstall167root in the patch failed.
+1compile53the patch passed
+1javac53the patch passed
-1checkstyle71hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace0The patch has no whitespace issues.
-1shadedjars224patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck123The patch causes 11 errors with Hadoop v2.8.5.
-1hadoopcheck246The patch causes 11 errors with Hadoop v2.9.2.
-1hadoopcheck377The patch causes 11 errors with Hadoop v3.1.2.
+1javadoc36the patch passed
+1findbugs279the patch passed
_ Other Tests _
-1unit57hbase-server in the patch failed.
+1asflicense11The patch does not generate ASF License warnings.
2417
SubsystemReport/Notes
DockerClient=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux a00bca78553a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh
git revisionmaster / c9293b0
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/testReport/
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/8/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec61Docker mode activated.
_ Prechecks _
+1dupname0No case conflicting files found.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall239master passed
+1compile56master passed
+1checkstyle74master passed
+1shadedjars262branch has no errors when building our shaded downstream artifacts.
-1javadoc18hbase-server in master failed.
0spotbugs319Used deprecated FindBugs config; considering switching to SpotBugs.
-1findbugs38hbase-server in master failed.
_ Patch Compile Tests _
-1mvninstall166root in the patch failed.
-1compile35hbase-server in the patch failed.
-1javac35hbase-server in the patch failed.
-1checkstyle70hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1whitespace0The patch has no whitespace issues.
-1shadedjars208patch has 11 errors when building our shaded downstream artifacts.
-1hadoopcheck119The patch causes 11 errors with Hadoop v2.8.5.
-1hadoopcheck240The patch causes 11 errors with Hadoop v2.9.2.
-1hadoopcheck366The patch causes 11 errors with Hadoop v3.1.2.
+1javadoc35the patch passed
+1findbugs251the patch passed
_ Other Tests _
-1unit56hbase-server in the patch failed.
+1asflicense11The patch does not generate ASF License warnings.
2002
SubsystemReport/Notes
DockerClient=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux c3d57cee89a4 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh
git revisionmaster / aa9679d
Default Java1.8.0_181
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/branch-javadoc-hbase-server.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/branch-findbugs-hbase-server.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-compile-hbase-server.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-compile-hbase-server.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/diff-checkstyle-hbase-server.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-javac-3.1.2.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/testReport/
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/9/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@binlijinbinlijin reopened this Oct 31, 2019
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 33sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚mvninstall5m 30smaster passed
💚compile0m 56smaster passed
💚checkstyle1m 17smaster passed
💚shadedjars4m 36sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 37smaster passed
💙spotbugs3m 55sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs3m 52smaster passed
_ Patch Compile Tests _
💚mvninstall4m 54sthe patch passed
💚compile0m 56sthe patch passed
💚javac0m 56sthe patch passed
💚checkstyle1m 19sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 37spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 33sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 36sthe patch passed
💚findbugs4m 7sthe patch passed
_ Other Tests _
💔unit162m 49shbase-server in the patch failed.
💚asflicense0m 34sThe patch does not generate ASF License warnings.
219m 13s
ReasonTests
Failed junit testshadoop.hbase.master.assignment.TestReportOnlineRegionsRace
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 0e66ee070ec5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh
git revisionmaster / e1b4a2a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/testReport/
Max. process+thread count4924 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@carp84carp84 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the UT result we could see below error:

[ERROR] Failures:
[ERROR] TestReportOnlineRegionsRace.testRace:167 Waiting timed out after [10,000] msec
[ERROR] Errors:
[ERROR] TestReportOnlineRegionsRace.setUp:130 » TimeoutIO java.util.concurrent.Timeout...

I checked in local environment and reproduced the error, and there's no such issue if we revert the commit of this PR, so this is a regression must be fixed.

@binlijin

Copy link
Copy Markdown
ContributorAuthor

@carp84 fix the ut, the test need at least two write handler when use separate read/write handlers.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall5m 23smaster passed
+1 💚compile0m 55smaster passed
+1 💚checkstyle1m 20smaster passed
+1 💚shadedjars4m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
+0 🆗spotbugs4m 9sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 6smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 3sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚checkstyle1m 19sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars4m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck15m 31sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚javadoc0m 37sthe patch passed
+1 💚findbugs4m 8sthe patch passed
_ Other Tests _
-1 ❌unit167m 23shbase-server in the patch failed.
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
224m 12s
ReasonTests
Failed junit testshadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk
hadoop.hbase.replication.TestReplicationDroppedTables
hadoop.hbase.master.TestClusterRestartFailover
SubsystemReport/Notes
DockerClient=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/Dockerfile
GITHUB PR#202
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux d9f62458b8d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-202/out/precommit/personality/provided.sh
git revisionmaster / 4ea7922
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/testReport/
Max. process+thread count5054 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-202/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@carp84

Copy link
Copy Markdown
Member

From the latest UT result I could see below failure/error, please double check whether they're related to changes here @binlijin . Thanks.

[ERROR] Failures:
[ERROR] TestClusterRestartFailover.test:111 Submit the SCP for the same serverName d9f62458b8d2,42889,1574347120113 which should fail
[ERROR] TestClusterRestartFailoverSplitWithoutZk>TestClusterRestartFailover.test:111 Submit the SCP for the same serverName d9f62458b8d2,38945,1574346611108 which should fail
[ERROR] Errors:
[ERROR] org.apache.hadoop.hbase.replication.TestReplicationDroppedTables.org.apache.hadoop.hbase.replication.TestReplicationDroppedTables
[ERROR] Run 1: TestReplicationDroppedTables.testEditsDroppedWithDroppedTableNS:132->testEditsBehindDroppedTable:186 » TestTimedOut
[ERROR] Run 2: TestReplicationDroppedTables.org.apache.hadoop.hbase.replication.TestReplicationDroppedTables »

@binlijin

Copy link
Copy Markdown
ContributorAuthor

@carp84 run this tests and passed locally, they're not related to the patch.

@carp84carp84 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation, then everything LGTM, +1.

@binlijin
binlijin merged commit dff7fff into apache:masterDec 9, 2019
asfgit pushed a commit that referenced this pull request Dec 9, 2019
asfgit pushed a commit that referenced this pull request Dec 9, 2019
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Oct 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@binlijin@Apache-HBase@carp84@saintstack