Skip to content

HBASE-8458 Support for batch version of checkAndPut() and checkAndDelete() - #594

Closed
guangxuCheng wants to merge 1 commit into
apache:branch-2from
guangxuCheng:HBASE-8458
Closed

HBASE-8458 Support for batch version of checkAndPut() and checkAndDelete()#594
guangxuCheng wants to merge 1 commit into
apache:branch-2from
guangxuCheng:HBASE-8458

Conversation

@guangxuCheng

Copy link
Copy Markdown
Member

batch checkAndxxx using existing batch method on Table.

detail see: https://issues.apache.org/jira/browse/HBASE-8458

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 36sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💙prototool0m 0sprototool was not available.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
💙mvndep0m 15sMaven dependency ordering for branch
💚mvninstall5m 57sbranch-2 passed
💚compile2m 1sbranch-2 passed
💚checkstyle2m 18sbranch-2 passed
💚shadedjars4m 11sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 17sbranch-2 passed
💙spotbugs3m 9sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs6m 55sbranch-2 passed
_ Patch Compile Tests _
💙mvndep0m 15sMaven dependency ordering for patch
💚mvninstall5m 0sthe patch passed
💚compile2m 3sthe patch passed
💚cc2m 3sthe patch passed
💚javac2m 3sthe patch passed
💚checkstyle2m 20sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 21spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 47sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚hbaseprotoc1m 55sthe patch passed
💚javadoc1m 14sthe patch passed
💚findbugs7m 45sthe patch passed
_ Other Tests _
💚unit0m 41shbase-protocol-shaded in the patch passed.
💚unit3m 39shbase-client in the patch passed.
💔unit176m 44shbase-server in the patch failed.
💚asflicense1m 30sThe patch does not generate ASF License warnings.
253m 51s
ReasonTests
Failed junit testshadoop.hbase.replication.regionserver.TestWALEntryStream
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/artifact/out/Dockerfile
GITHUB PR#594
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux ef30042b166f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-594/out/precommit/personality/provided.sh
git revisionbranch-2 / 1568e05
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/testReport/
Max. process+thread count4796 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@saintstack

Copy link
Copy Markdown
Contributor

Oh. Rerunning tests but patch has conflicts. Mind fixing please @guangxuCheng ?

@guangxuCheng

Copy link
Copy Markdown
MemberAuthor

Oh. Rerunning tests but patch has conflicts. Mind fixing please @guangxuCheng ?

@saintstack Thanks for review. Rebased to current branch-2, pending QA, Thanks

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec0m 40sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💙prototool0m 0sprototool was not available.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
💙mvndep0m 30sMaven dependency ordering for branch
💚mvninstall5m 13sbranch-2 passed
💚compile1m 59sbranch-2 passed
💚checkstyle2m 16sbranch-2 passed
💚shadedjars4m 12sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 15sbranch-2 passed
💙spotbugs3m 21sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs6m 55sbranch-2 passed
_ Patch Compile Tests _
💙mvndep0m 15sMaven dependency ordering for patch
💚mvninstall4m 46sthe patch passed
💚compile1m 59sthe patch passed
💚cc1m 59sthe patch passed
💚javac1m 59sthe patch passed
💚checkstyle2m 14sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 13spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 15sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚hbaseprotoc1m 51sthe patch passed
💚javadoc1m 12sthe patch passed
💚findbugs7m 22sthe patch passed
_ Other Tests _
💚unit0m 42shbase-protocol-shaded in the patch passed.
💚unit3m 38shbase-client in the patch passed.
💚unit160m 42shbase-server in the patch passed.
💚asflicense1m 35sThe patch does not generate ASF License warnings.
235m 36s
SubsystemReport/Notes
DockerClient=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/5/artifact/out/Dockerfile
GITHUB PR#594
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 9b7e52fd7b96 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-594/out/precommit/personality/provided.sh
git revisionbranch-2 / 18ff188
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/5/testReport/
Max. process+thread count4061 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-594/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@guangxuCheng

Copy link
Copy Markdown
MemberAuthor

@saintstack@Apache9 can you take a look? Thanks

@Apache9

Copy link
Copy Markdown
Contributor

Could you please upload a patch against master?

@guangxuCheng

Copy link
Copy Markdown
MemberAuthor

Thanks @Apache9 for review. Create a new PR for master. #765

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guangxuCheng@Apache-HBase@saintstack@Apache9@brfrn169