Skip to content

HBASE-8458 Support for batch version of checkAndPut() and checkAndDel… - #765

Closed
guangxuCheng wants to merge 1 commit into
apache:masterfrom
guangxuCheng:HBASE-8458-master
Closed

HBASE-8458 Support for batch version of checkAndPut() and checkAndDel…#765
guangxuCheng wants to merge 1 commit into
apache:masterfrom
guangxuCheng:HBASE-8458-master

Conversation

@guangxuCheng

@guangxuChengguangxuCheng commented Oct 28, 2019

Copy link
Copy Markdown
Member

…ete()

@guangxuChengguangxuCheng mentioned this pull request Oct 28, 2019
Closed
@Apache-HBase

Apache-HBase commented Oct 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec2m 3sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💙prototool0m 0sprototool was not available.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
💙mvndep0m 35sMaven dependency ordering for branch
💚mvninstall5m 13smaster passed
💚compile2m 0smaster passed
💚checkstyle2m 7smaster passed
💚shadedjars4m 50sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 15smaster passed
💙spotbugs4m 21sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs8m 6smaster passed
_ Patch Compile Tests _
💙mvndep0m 15sMaven dependency ordering for patch
💚mvninstall4m 57sthe patch passed
💚compile2m 1sthe patch passed
💚cc2m 1sthe patch passed
💚javac2m 1sthe patch passed
💔checkstyle0m 38shbase-client: The patch generated 2 new + 305 unchanged - 0 fixed = 307 total (was 305)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 33spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck16m 1sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚hbaseprotoc1m 55sthe patch passed
💚javadoc1m 13sthe patch passed
💔findbugs1m 16shbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
💚unit0m 40shbase-protocol-shaded in the patch passed.
💚unit1m 59shbase-client in the patch passed.
💚unit158m 53shbase-server in the patch passed.
💚asflicense1m 37sThe patch does not generate ASF License warnings.
237m 33s
ReasonTests
FindBugsmodule:hbase-client
org.apache.hadoop.hbase.client.CheckAndRowMutate defines compareTo(Object) and uses Object.equals() At CheckAndRowMutate.java:Object.equals() At CheckAndRowMutate.java:[line 30]
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/1/artifact/out/Dockerfile
GITHUB PR#765
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 5933afbe74f0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-765/out/precommit/personality/provided.sh
git revisionmaster / d7deafa
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/1/artifact/out/diff-checkstyle-hbase-client.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/1/artifact/out/new-findbugs-hbase-client.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/1/testReport/
Max. process+thread count4857 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 28, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 35sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💙prototool0m 0sprototool was not available.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
💙mvndep0m 36sMaven dependency ordering for branch
💚mvninstall5m 12smaster passed
💚compile2m 0smaster passed
💚checkstyle2m 11smaster passed
💚shadedjars4m 36sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 13smaster passed
💙spotbugs4m 5sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs7m 48smaster passed
_ Patch Compile Tests _
💙mvndep0m 15sMaven dependency ordering for patch
💚mvninstall4m 54sthe patch passed
💚compile2m 1sthe patch passed
💚cc2m 1sthe patch passed
💚javac2m 1sthe patch passed
💔checkstyle0m 41shbase-client: The patch generated 1 new + 305 unchanged - 0 fixed = 306 total (was 305)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 34spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 34sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚hbaseprotoc1m 55sthe patch passed
💚javadoc1m 13sthe patch passed
💚findbugs8m 4sthe patch passed
_ Other Tests _
💚unit0m 41shbase-protocol-shaded in the patch passed.
💚unit1m 59shbase-client in the patch passed.
💚unit158m 57shbase-server in the patch passed.
💚asflicense1m 38sThe patch does not generate ASF License warnings.
235m 8s
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/2/artifact/out/Dockerfile
GITHUB PR#765
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 81b52603cc61 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-765/out/precommit/personality/provided.sh
git revisionmaster / 4c75485
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/2/artifact/out/diff-checkstyle-hbase-client.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/2/testReport/
Max. process+thread count4804 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 29, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 33sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💙prototool0m 1sprototool was not available.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
💙mvndep0m 36sMaven dependency ordering for branch
💚mvninstall5m 16smaster passed
💚compile1m 59smaster passed
💚checkstyle2m 12smaster passed
💚shadedjars4m 36sbranch has no errors when building our shaded downstream artifacts.
💚javadoc1m 14smaster passed
💙spotbugs3m 59sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs7m 31smaster passed
_ Patch Compile Tests _
💙mvndep0m 14sMaven dependency ordering for patch
💚mvninstall4m 54sthe patch passed
💚compile2m 0sthe patch passed
💚cc2m 0sthe patch passed
💚javac2m 0sthe patch passed
💚checkstyle2m 11sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 31spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 49sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚hbaseprotoc1m 55sthe patch passed
💚javadoc1m 14sthe patch passed
💚findbugs8m 2sthe patch passed
_ Other Tests _
💚unit0m 41shbase-protocol-shaded in the patch passed.
💚unit1m 56shbase-client in the patch passed.
💔unit161m 47shbase-server in the patch failed.
💚asflicense1m 38sThe patch does not generate ASF License warnings.
237m 47s
ReasonTests
Failed junit testshadoop.hbase.regionserver.TestOpenSeqNumUnexpectedIncrease
SubsystemReport/Notes
DockerClient=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/3/artifact/out/Dockerfile
GITHUB PR#765
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 1d61cde40ce4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-765/out/precommit/personality/provided.sh
git revisionmaster / a881678
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/3/testReport/
Max. process+thread count4836 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-765/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@HorizonNet

HorizonNet commented Dec 13, 2019

Copy link
Copy Markdown
Contributor

@guangxuCheng Can you please resolve the conflict. Is #594 still needed if this one gets merged and backported?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guangxuCheng@Apache-HBase@HorizonNet@brfrn169