Skip to content

HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure (#5816) - #5960

Merged
Apache9 merged 2 commits into
apache:branch-2from
Umeshkumar9414:HBASE-28420_branch-2
Jun 5, 2024
Merged

HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure (#5816)#5960
Apache9 merged 2 commits into
apache:branch-2from
Umeshkumar9414:HBASE-28420_branch-2

Conversation

@Umeshkumar9414

@Umeshkumar9414Umeshkumar9414 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure (#5816)

@Apache-HBase

Apache-HBase commented Jun 3, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 0sbranch-2 passed
+1 💚compile3m 14sbranch-2 passed
+1 💚checkstyle0m 47sbranch-2 passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 21sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile3m 13sthe patch passed
+1 💚cc3m 13sthe patch passed
+1 💚javac3m 13sthe patch passed
+1 💚checkstyle0m 44sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 23sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚hbaseprotoc1m 5sthe patch passed
-1 ❌spotless0m 37spatch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚spotbugs3m 35sthe patch passed
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
36m 7s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5960
Optional Testsdupname asflicense cc hbaseprotoc spotless prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 4a23ee552ab6 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 7869f7f
Default JavaEclipse Adoptium-11.0.17+8
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasanivirajjasani added the backport This PR is a back port of some issue or issues already committed to master label Jun 3, 2024
@virajjasani

virajjasani commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

@Umeshkumar9414 you will have to run spotless:apply

@Apache-HBase

Apache-HBase commented Jun 3, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 46sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 35sbranch-2 passed
+1 💚compile1m 2sbranch-2 passed
+1 💚shadedjars5m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 32sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚shadedjars5m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30sthe patch passed
_ Other Tests _
+1 💚unit0m 23shbase-protocol-shaded in the patch passed.
-1 ❌unit213m 16shbase-server in the patch failed.
239m 54s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5960
Optional Testsunit javac javadoc shadedjars compile
unameLinux 497e0d16a344 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 7869f7f
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/testReport/
Max. process+thread count4279 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 49sbranch-2 passed
+1 💚compile1m 40sbranch-2 passed
+1 💚shadedjars7m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 24sthe patch passed
+1 💚compile1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
+1 💚shadedjars7m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 48sthe patch passed
_ Other Tests _
+1 💚unit0m 44shbase-protocol-shaded in the patch passed.
+1 💚unit257m 47shbase-server in the patch passed.
291m 4s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5960
Optional Testsunit javac javadoc shadedjars compile
unameLinux cd14a4c6cd66 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 7869f7f
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/testReport/
Max. process+thread count4595 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Jun 4, 2024
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run mvn spotless:apply to fix the style issue?

Thanks.

Umeshkumar9414and others added 2 commits June 4, 2024 21:03
@Umeshkumar9414ukumawat
HBASE-28420 Update the procedure's field to store for ServerRemotePro…
16bfd87
…cedure (apache#5816)
Co-authored-by: ukumawat <ukumawat@salesforce.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
ukumawat
HBASE-28420 spotless apply
969b79b
@Apache-HBase

Apache-HBase commented Jun 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 52sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 45sbranch-2 passed
+1 💚compile3m 13sbranch-2 passed
+1 💚checkstyle0m 46sbranch-2 passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs3m 15sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile3m 21sthe patch passed
+1 💚cc3m 21sthe patch passed
+1 💚javac3m 21sthe patch passed
+1 💚checkstyle0m 45sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 13sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚hbaseprotoc1m 6sthe patch passed
+1 💚spotless0m 43spatch has no errors when running spotless:check.
+1 💚spotbugs3m 32sthe patch passed
_ Other Tests _
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
35m 34s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5960
Optional Testsdupname asflicense cc hbaseprotoc spotless prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux e2e433918fd8 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 700b5a4
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall2m 16sbranch-2 passed
+1 💚compile1m 1sbranch-2 passed
+1 💚shadedjars5m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 20sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30sthe patch passed
_ Other Tests _
+1 💚unit0m 24shbase-protocol-shaded in the patch passed.
+1 💚unit209m 52shbase-server in the patch passed.
234m 0s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5960
Optional Testsunit javac javadoc shadedjars compile
unameLinux aaf6981f93d6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 700b5a4
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/2/testReport/
Max. process+thread count4286 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 59sbranch-2 passed
+1 💚compile1m 26sbranch-2 passed
+1 💚shadedjars5m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile1m 23sthe patch passed
+1 💚javac1m 23sthe patch passed
+1 💚shadedjars5m 24spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sthe patch passed
_ Other Tests _
+1 💚unit0m 36shbase-protocol-shaded in the patch passed.
+1 💚unit243m 14shbase-server in the patch passed.
270m 47s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5960
Optional Testsunit javac javadoc shadedjars compile
unameLinux 6c73cd899d78 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 700b5a4
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/2/testReport/
Max. process+thread count4586 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5960/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Umeshkumar9414

Umeshkumar9414 commented Jun 5, 2024

Copy link
Copy Markdown
ContributorAuthor

It's nice to see all the tests passed here as well. It gave me a hard time in the master branch. @virajjasani , @Apache9 please approve and merge.

@Apache9
Apache9 merged commit 377c37f into apache:branch-2Jun 5, 2024
Apache9 pushed a commit that referenced this pull request Jun 5, 2024
@Umeshkumar9414ukumawat@Apache9
HBASE-28420Update the procedure's field to store for ServerRemotePro…
675f3cd
…cedure (#5816) (#5960)
Co-authored-by: ukumawat <ukumawat@salesforce.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 377c37f)
Apache9 pushed a commit that referenced this pull request Jun 5, 2024
@Umeshkumar9414ukumawat@Apache9
HBASE-28420Update the procedure's field to store for ServerRemotePro…
12733bc
…cedure (#5816) (#5960)
Co-authored-by: ukumawat <ukumawat@salesforce.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 377c37f)
@Umeshkumar9414
Umeshkumar9414 deleted the HBASE-28420_branch-2 branch July 28, 2024 14:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Umeshkumar9414@Apache-HBase@virajjasani@Apache9