HBASE-28676 Make pre commit build for 3.x to only run jdk 17 test by Apache9 · Pull Request #6001 · apache/hbase

Apache9 · 2024-06-19T08:51:50Z

No description provided.

Apache-HBase · 2024-06-19T09:34:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 0s	master passed
+1 💚	compile	1m 58s	master passed
+1 💚	shadedjars	5m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	1m 58s	the patch passed
-0 ⚠️	javac	1m 58s	root generated 75 new + 0 unchanged - 0 fixed = 75 total (was 0)
+1 💚	shadedjars	5m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 53s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 39s	root in the patch failed.
		28m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6001
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0fdbc457f351 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `046e9d5`
Default Java	Eclipse Adoptium-17.0.10+7
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/artifact/yetus-jdk17-hadoop3-check/output/diff-compile-javac-root.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/testReport/
Max. process+thread count	300 (vs. ulimit of 30000)
modules	C: hbase-build-configuration . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-19T09:36:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 46s	master passed
-1 ❌	compile	0m 16s	root in master failed.
+1 💚	spotless	0m 56s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 18s	the patch passed
+1 💚	compile	8m 27s	the patch passed
-0 ⚠️	javac	8m 27s	root generated 1206 new + 0 unchanged - 0 fixed = 1206 total (was 0)
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	xml	0m 1s	The patch has 2 ill-formed XML file(s).
+1 💚	hadoopcheck	5m 7s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		30m 22s

Reason	Tests
XML	Parsing Error(s):
	hbase-build-configuration/pom.xml
	pom.xml

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6001
Optional Tests	dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile
uname	Linux a27884dbf7a4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `046e9d5`
Default Java	Eclipse Adoptium-17.0.10+7
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/artifact/yetus-general-check/output/branch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
xml	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/artifact/yetus-general-check/output/xml.txt
Max. process+thread count	189 (vs. ulimit of 30000)
modules	C: hbase-build-configuration . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/1/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-19T12:33:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 53s	master passed
-1 ❌	compile	0m 15s	root in master failed.
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	7m 42s	the patch passed
-0 ⚠️	javac	7m 42s	root generated 1179 new + 0 unchanged - 0 fixed = 1179 total (was 0)
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	xml	0m 1s	The patch has 2 ill-formed XML file(s).
+1 💚	hadoopcheck	4m 56s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		28m 4s

Reason	Tests
XML	Parsing Error(s):
	hbase-build-configuration/pom.xml
	pom.xml

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6001
Optional Tests	dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile
uname	Linux fe43716f7415 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ff1e52b`
Default Java	Eclipse Adoptium-17.0.10+7
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/2/artifact/yetus-general-check/output/branch-compile-root.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
xml	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/2/artifact/yetus-general-check/output/xml.txt
Max. process+thread count	185 (vs. ulimit of 30000)
modules	C: hbase-build-configuration . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/2/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-06-19T15:20:28Z

Filed HBASE-28679 for the xml problem, and we can not move releaseTarget to 17 because there are tests failures on mockito, which may require code change. Plan to solve it in HBASE-28675.

Apache-HBase · 2024-06-19T17:05:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	1m 57s	master passed
+1 💚	shadedjars	5m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 56s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 52s	the patch passed
+1 💚	compile	1m 58s	the patch passed
+1 💚	javac	1m 58s	the patch passed
+1 💚	shadedjars	5m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	268m 26s	root in the patch passed.
		299m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6001
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 100ee231074d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ff1e52b`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/2/testReport/
Max. process+thread count	8957 (vs. ulimit of 30000)
modules	C: hbase-build-configuration . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-22T03:51:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 48s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --blanks-eol-ignore-list --blanks-tabs-ignore-list
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 52s		master passed
-1 ❌	compile	0m 15s	/branch-compile-root.txt	root in master failed.
+1 💚	spotless	0m 42s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 46s		the patch passed
+1 💚	compile	7m 35s		the patch passed
-0 ⚠️	javac	7m 35s	/results-compile-javac-root.txt	root generated 1179 new + 0 unchanged - 0 fixed = 1179 total (was 0)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	4m 57s		Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 42s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 17s		The patch does not generate ASF License warnings.
		30m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6001
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile
uname	Linux e48bb3803d5c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9ad500a`
Default Java	Eclipse Adoptium-17.0.10+7
Max. process+thread count	187 (vs. ulimit of 30000)
modules	C: hbase-build-configuration . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/3/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-06-22T05:42:17Z

The error for compile for the current master branch is expected, since we change to use jdk17 for compiling, we need to add some compile args for error prone.

Apache-HBase · 2024-06-22T10:13:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-list --blanks-tabs-ignore-list --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 9s		master passed
+1 💚	compile	1m 58s		master passed
+1 💚	javadoc	1m 53s		master passed
+1 💚	shadedjars	5m 37s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s		the patch passed
+1 💚	compile	1m 56s		the patch passed
+1 💚	javac	1m 56s		the patch passed
+1 💚	javadoc	1m 53s		the patch passed
+1 💚	shadedjars	5m 28s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	332m 12s	/patch-unit-root.txt	root in the patch failed.
		412m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6001
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2a7ec825152b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9ad500a`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/3/testReport/
Max. process+thread count	7336 (vs. ulimit of 30000)
modules	C: hbase-build-configuration . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-23T15:58:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 34s		master passed
-1 ❌	compile	0m 24s	/branch-compile-root.txt	root in master failed.
+1 💚	spotless	0m 58s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 44s		the patch passed
+1 💚	compile	9m 57s		the patch passed
-0 ⚠️	javac	9m 57s	/results-compile-javac-root.txt	root generated 1179 new + 0 unchanged - 0 fixed = 1179 total (was 0)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	6m 41s		Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 57s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		37m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6001
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile
uname	Linux 8fc13d8fa23a 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `407e80f`
Default Java	Eclipse Adoptium-17.0.10+7
Max. process+thread count	186 (vs. ulimit of 30000)
modules	C: hbase-build-configuration . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/4/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-06-23T21:11:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 41s		master passed
+1 💚	compile	2m 48s		master passed
+1 💚	javadoc	2m 29s		master passed
+1 💚	shadedjars	5m 38s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 55s		the patch passed
+1 💚	compile	2m 47s		the patch passed
+1 💚	javac	2m 47s		the patch passed
+1 💚	javadoc	3m 18s		the patch passed
+1 💚	shadedjars	6m 53s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	311m 26s		root in the patch passed.
		351m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6001
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 741cec0e2f13 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `407e80f`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/4/testReport/
Max. process+thread count	8231 (vs. ulimit of 30000)
modules	C: hbase-build-configuration . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6001/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-06-24T01:21:50Z

OK, good. Xml check can pass now.

Apache9 · 2024-06-24T01:23:05Z

Merging this will cause the nightly build for master and branch-3 to fail since we still use jdk11 for general checks.

Will start to work on HBASE-28678 ASAP after merging this PR.

ndimiduk · 2024-06-26T11:07:47Z

 <tar.name>${project.build.finalName}.tar.gz</tar.name>
 <maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
 <buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>


ndimiduk · 2024-06-26T11:10:58Z

 <buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
+ <compileSource>17</compileSource>
 <releaseTarget>8</releaseTarget>


What does it mean to have compile target at 17 but release target at 8? Can javac emit bytecode for 17 features for an 8 VM?
We are dropping JDK8 runtime support, so I think we can move the release target up as well.

ReleaseTarget 17 will break mockito, need to dig more...

Apache9 · 2024-06-26T13:17:21Z

Filed HBASE-28679 for the xml problem, and we can not move releaseTarget to 17 because there are tests failures on mockito, which may require code change. Plan to solve it in HBASE-28675.

@ndimiduk See here, I tried to jump to 17 too for releaseTarget at first, but it breaks mockito, so I plan to address it in HBASE-28675 since it may require java code changes.

) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 80516d7)

ndimiduk · 2024-06-27T15:03:39Z

Makes sense. Thanks @Apache9 !

…ache#6001) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

Apache9 self-assigned this Jun 19, 2024

Apache9 force-pushed the HBASE-28676 branch from b5c6fb4 to f5d6f08Compare June 19, 2024 11:55

Apache9 force-pushed the HBASE-28676 branch from f5d6f08 to 9ad500aCompare June 22, 2024 03:18

HBASE-28676 Make pre commit build for 3.x to only run jdk 17 test
407e80f

Apache9 force-pushed the HBASE-28676 branch from 9ad500a to 407e80fCompare June 23, 2024 15:07

Apache9 requested a review from ndimiduk June 24, 2024 01:21

ndimiduk approved these changes Jun 26, 2024
View reviewed changes

Apache9 merged commit 80516d7 into apache:masterJun 26, 2024

Apache9 added a commit that referenced this pull request Jun 26, 2024
HBASE-28676Make pre commit build for 3.x to only run jdk 17 test (#6001
5520620
) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 80516d7)

NihalJain mentioned this pull request May 20, 2025
HBASE-29317 Bump hbase-thirdparty to 4.1.11 (#6993) #7002
Merged

prabhjyotsingh pushed a commit to acceldata-io/hbase that referenced this pull request Jun 9, 2026
HBASE-28676 Make pre commit build for 3.x to only run jdk 17 test (ap…
80d6f8f
…ache#6001) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

Uh oh!

Conversation

Apache9 commented Jun 19, 2024

Uh oh!

Apache-HBase commented Jun 19, 2024

Uh oh!

Apache-HBase commented Jun 19, 2024

Uh oh!

Apache-HBase commented Jun 19, 2024

Uh oh!

Apache9 commented Jun 19, 2024

Uh oh!

Apache-HBase commented Jun 19, 2024

Uh oh!

Apache-HBase commented Jun 22, 2024

Uh oh!

Apache9 commented Jun 22, 2024

Uh oh!

Apache-HBase commented Jun 22, 2024

Uh oh!

Apache-HBase commented Jun 23, 2024

Uh oh!

Apache-HBase commented Jun 23, 2024

Uh oh!

Apache9 commented Jun 24, 2024

Uh oh!

Apache9 commented Jun 24, 2024

Uh oh!

ndimidukJun 26, 2024

Choose a reason for hiding this comment

Uh oh!

ndimidukJun 26, 2024

Choose a reason for hiding this comment

Uh oh!

Apache9Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Jun 26, 2024

Uh oh!

ndimiduk commented Jun 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants