Skip to content

HBASE-28665 WALs not marked closed when there are errors in closing WALs - #6027

Merged
virajjasani merged 5 commits into
apache:branch-2.5from
kiran-maturi:HBASE-28665
Jul 11, 2024
Merged

HBASE-28665 WALs not marked closed when there are errors in closing WALs#6027
virajjasani merged 5 commits into
apache:branch-2.5from
kiran-maturi:HBASE-28665

Conversation

@kiran-maturi

@kiran-maturikiran-maturi commented Jun 26, 2024•
edited by virajjasani
Loading

Copy link
Copy Markdown
Contributor

@Apache-HBase

Apache-HBase commented Jun 26, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 31sbranch-2.5 passed
+1 💚compile0m 38sbranch-2.5 passed
+1 💚javadoc0m 24sbranch-2.5 passed
+1 💚shadedjars5m 7sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 17sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚javadoc0m 23sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit10m 31s/patch-unit-hbase-server.txthbase-server in the patch failed.
30m 11s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6027
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 2643838c9562 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 9330bf5
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/testReport/
Max. process+thread count1731 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 26, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 19sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 51sbranch-2.5 passed
+1 💚compile0m 47sbranch-2.5 passed
+1 💚javadoc0m 26sbranch-2.5 passed
+1 💚shadedjars5m 0sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 44sthe patch passed
+1 💚compile0m 47sthe patch passed
+1 💚javac0m 47sthe patch passed
+1 💚javadoc0m 25sthe patch passed
+1 💚shadedjars5m 1spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit12m 36s/patch-unit-hbase-server.txthbase-server in the patch failed.
32m 51s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6027
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 0ae823d368dd 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 9330bf5
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/testReport/
Max. process+thread count1596 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 26, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.5 Compile Tests _
+1 💚mvninstall3m 14sbranch-2.5 passed
+1 💚compile2m 34sbranch-2.5 passed
+1 💚checkstyle0m 37sbranch-2.5 passed
+1 💚spotbugs1m 31sbranch-2.5 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 48sthe patch passed
+1 💚compile2m 35sthe patch passed
+1 💚javac2m 35sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 35s/results-checkstyle-hbase-server.txthbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚spotbugs1m 38sthe patch passed
+1 💚hadoopcheck15m 9sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
-1 ❌spotless0m 36spatch has 23 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
34m 37s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6027
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux bd0d58a5307f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 9330bf5
Default JavaEclipse Adoptium-11.0.17+8
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Jun 26, 2024
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for 2.5.x? Other branches are not affected?

@kiran-maturi
kiran-maturi marked this pull request as draft June 26, 2024 15:19
@kiran-maturi

kiran-maturi commented Jun 26, 2024

Copy link
Copy Markdown
ContributorAuthor

@Apache9 This impacts other branches (branch-2.x) as well. I have started with 2.5 will create pull request for other branches as well. Please let me know if we need to start with any specific branch for 2.x

@Apache-HBase

Apache-HBase commented Jun 28, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 16sbranch-2.5 passed
+1 💚compile0m 40sbranch-2.5 passed
+1 💚javadoc0m 23sbranch-2.5 passed
+1 💚shadedjars5m 6sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 16sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 38sthe patch passed
+1 💚javadoc0m 23sthe patch passed
+1 💚shadedjars5m 7spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit10m 34s/patch-unit-hbase-server.txthbase-server in the patch failed.
29m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6027
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 4a020171c482 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / a20ab24
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/testReport/
Max. process+thread count1718 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 28, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 53sbranch-2.5 passed
+1 💚compile0m 53sbranch-2.5 passed
+1 💚javadoc0m 30sbranch-2.5 passed
+1 💚shadedjars5m 2sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 39sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚javadoc0m 28sthe patch passed
+1 💚shadedjars4m 59spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit11m 40s/patch-unit-hbase-server.txthbase-server in the patch failed.
32m 18s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6027
Optional Testsjavac javadoc unit compile shadedjars
unameLinux fc70b62fa2b1 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / a20ab24
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/testReport/
Max. process+thread count1656 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 28, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 18sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 53sbranch-2.5 passed
+1 💚compile0m 47sbranch-2.5 passed
+1 💚javadoc0m 27sbranch-2.5 passed
+1 💚shadedjars5m 0sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 40sthe patch passed
+1 💚compile0m 49sthe patch passed
+1 💚javac0m 49sthe patch passed
+1 💚javadoc0m 25sthe patch passed
+1 💚shadedjars4m 57spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit12m 43s/patch-unit-hbase-server.txthbase-server in the patch failed.
32m 38s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6027
Optional Testsjavac javadoc unit compile shadedjars
unameLinux f1033582d3fb 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / a20ab24
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/testReport/
Max. process+thread count1592 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 28, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 46sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.5 Compile Tests _
+1 💚mvninstall3m 14sbranch-2.5 passed
+1 💚compile2m 37sbranch-2.5 passed
+1 💚checkstyle0m 36sbranch-2.5 passed
+1 💚spotbugs1m 34sbranch-2.5 passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 51sthe patch passed
+1 💚compile2m 36sthe patch passed
+1 💚javac2m 36sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 35s/results-checkstyle-hbase-server.txthbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚spotbugs1m 41sthe patch passed
+1 💚hadoopcheck16m 40sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
-1 ❌spotless0m 48spatch has 63 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
36m 38s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6027
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux b48fccc0b15a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / a20ab24
Default JavaEclipse Adoptium-11.0.17+8
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 29, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker0m 7sDocker failed to build run-specific yetus/hbase:tp-11287}.
SubsystemReport/Notes
GITHUB PR#6027
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/console
versionsgit=2.25.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 29, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker0m 15sDocker failed to build run-specific yetus/hbase:tp-12915}.
SubsystemReport/Notes
GITHUB PR#6027
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/console
versionsgit=2.25.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 29, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker0m 15sDocker failed to build run-specific yetus/hbase:tp-26249}.
SubsystemReport/Notes
GITHUB PR#6027
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/console
versionsgit=2.25.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@kiran-maturi
kiran-maturi marked this pull request as ready for review June 29, 2024 20:55
@Apache-HBase

Apache-HBase commented Jun 30, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 23sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 16sbranch-2.5 passed
+1 💚compile0m 39sbranch-2.5 passed
+1 💚javadoc0m 23sbranch-2.5 passed
+1 💚shadedjars5m 9sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 18sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚javadoc0m 23sthe patch passed
+1 💚shadedjars5m 11spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit196m 36shbase-server in the patch passed.
219m 15s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6027
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 6f3b08969c28 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 5cbb2f2
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/testReport/
Max. process+thread count4120 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 30, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker0m 11sDocker failed to build run-specific yetus/hbase:tp-22459}.
SubsystemReport/Notes
GITHUB PR#6027
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/console
versionsgit=2.25.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 30, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker0m 16sDocker failed to build run-specific yetus/hbase:tp-1157}.
SubsystemReport/Notes
GITHUB PR#6027
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/console
versionsgit=2.25.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 30, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 50sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.5 Compile Tests _
+1 💚mvninstall4m 6sbranch-2.5 passed
+1 💚compile2m 56sbranch-2.5 passed
+1 💚checkstyle0m 42sbranch-2.5 passed
+1 💚spotbugs1m 45sbranch-2.5 passed
+1 💚spotless0m 50sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile2m 50sthe patch passed
+1 💚javac2m 50sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 42sthe patch passed
+1 💚spotbugs1m 58sthe patch passed
+1 💚hadoopcheck18m 21sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚spotless0m 53spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
41m 8s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6027
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux c8565aa24e60 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 3b29094
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jun 30, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+1 💚mvninstall2m 20sbranch-2.5 passed
+1 💚compile0m 39sbranch-2.5 passed
+1 💚javadoc0m 22sbranch-2.5 passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 23sthe patch passed
+1 💚compile0m 39sthe patch passed
+1 💚javac0m 39sthe patch passed
+1 💚javadoc0m 24sthe patch passed
+1 💚shadedjars5m 10spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit196m 58shbase-server in the patch passed.
218m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6027
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 8b1c867bacd6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 3b29094
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/testReport/
Max. process+thread count4018 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6027/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@kiran-maturi

kiran-maturi commented Jul 1, 2024

Copy link
Copy Markdown
ContributorAuthor

@virajjasani@apurtell can you please help with the review

@virajjasani
virajjasani self-requested a review July 1, 2024 19:07
virajjasani
virajjasani reviewed Jul 2, 2024
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, master branch does not check for unflushed entries anymore. @Apache9 is it because of HBASE-27231?

@virajjasani

virajjasani commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

@kiran-maturi could you please create PR against branch-2? From branch-2, we can backport to both 2.6 and 2.5 cleanly. Since this PR is already opened, 2.5 is already covered but usually branch-2 PR is required to run all tests.

ranganathg
ranganathg reviewed Jul 2, 2024
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
closeWriter(this.writer, oldPath, true);
} finally {
inflightWALClosures.remove(oldPath.getName());
if (!isUnflushedEntries()) {

@ranganathgranganathgJul 2, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the code below at line 403, should we also have a catch block to Log a WARNING?
Does it make any difference to first remove old path and then call markCloseAndClean or vice versa? Since the JIRA said we are trying to follow the similar as below, we can try to keep it same?

@ranganathgranganathgJul 2, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another question, does closeWriter also flush?

@kiran-maturikiran-maturiJul 2, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranganathginflightWALClosures.remove(oldPath.getName()); was there previously as well so not changing the behaviour there. We are explicitly looking for the closing for cleanup

Just another question, does closeWriter also flush?

No, this is in the write path it will not trigger any flush

@kiran-maturikiran-maturiJul 3, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranganathg sorry I got confused with the flush for region. If you are asking for flush for the entries that are there on the ringbuffer that will be done by the sycn runner threads which will increment the sequenceId

@virajjasani

virajjasani commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

Merged changes to branch-2 and branch-2.6, let me merge this PR now.

@virajjasani
virajjasani merged commit edda2d2 into apache:branch-2.5Jul 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 left review comments
@virajjasanivirajjasanivirajjasani left review comments
+1 more reviewer
@ranganathgranganathgranganathg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kiran-maturi@Apache-HBase@virajjasani@ranganathg@Apache9