Skip to content

HBASE-28637 asyncwal should attempt to recover lease if close fails (#5962) - #6033

Merged
jojochuang merged 2 commits into
apache:branch-2from
jojochuang:HBASE-28637-branch-2
Jul 10, 2024
Merged

HBASE-28637 asyncwal should attempt to recover lease if close fails (#5962)#6033
jojochuang merged 2 commits into
apache:branch-2from
jojochuang:HBASE-28637-branch-2

Conversation

@jojochuang

Copy link
Copy Markdown
Contributor

Signed-off-by: Duo Zhang zhangduo@apache.org
(cherry picked from commit 0e8cfdb) (cherry picked from commit b881296)

Conflicts:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java

Change-Id: Ia704c1b36b99be345d11a70ac2452dea094e9575

…pache#5962)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 0e8cfdb)
(cherry picked from commit b881296)
Conflicts:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
Change-Id: Ia704c1b36b99be345d11a70ac2452dea094e9575
@jojochuang

Copy link
Copy Markdown
ContributorAuthor

Changes made to address code conflicts:
(1) moved the recoverLease call from AbstractFSWAL to AsyncFSWAL.
(2) For FSHLog, move the logic inside closeWriter.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 14sbranch-2 passed
+1 💚compile2m 47sbranch-2 passed
+1 💚checkstyle0m 37sbranch-2 passed
+1 💚spotbugs1m 26sbranch-2 passed
-1 ❌spotless0m 45sbranch has 1 errors when running spotless:check, run spotless:apply to fix.
_ Patch Compile Tests _
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile2m 47sthe patch passed
+1 💚javac2m 47sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 32sthe patch passed
+1 💚spotbugs1m 33sthe patch passed
+1 💚hadoopcheck9m 45sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
-1 ❌spotless0m 37spatch has 31 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
29m 33s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6033
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 24e6a771fd47 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 015f1d9
Default JavaEclipse Adoptium-11.0.17+8
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/artifact/yetus-general-check/output/branch-spotless.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: Ie9a4b193ce7f5836a6dc071b9acd268930ffaf8a
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 18sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 2sbranch-2 passed
+1 💚compile1m 0sbranch-2 passed
+1 💚javadoc0m 39sbranch-2 passed
+1 💚shadedjars6m 29sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 14sthe patch passed
+1 💚compile1m 16sthe patch passed
+1 💚javac1m 17sthe patch passed
+1 💚javadoc0m 48sthe patch passed
+1 💚shadedjars6m 22spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit216m 19s/patch-unit-hbase-server.txthbase-server in the patch failed.
243m 56s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6033
Optional Testsjavac javadoc unit compile shadedjars
unameLinux ce6337a71711 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 015f1d9
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/testReport/
Max. process+thread count4732 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 52sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 53sbranch-2 passed
+1 💚compile0m 46sbranch-2 passed
+1 💚javadoc0m 30sbranch-2 passed
+1 💚shadedjars5m 57sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 43sthe patch passed
+1 💚compile0m 49sthe patch passed
+1 💚javac0m 49sthe patch passed
+1 💚javadoc0m 29sthe patch passed
+1 💚shadedjars5m 53spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit244m 7shbase-server in the patch passed.
269m 29s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6033
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 5c104100c13a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 015f1d9
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/testReport/
Max. process+thread count4233 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 58sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 26sbranch-2 passed
+1 💚compile0m 54sbranch-2 passed
+1 💚javadoc0m 33sbranch-2 passed
+1 💚shadedjars7m 20sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 40sthe patch passed
+1 💚compile1m 6sthe patch passed
+1 💚javac1m 6sthe patch passed
+1 💚javadoc0m 35sthe patch passed
+1 💚shadedjars7m 32spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit260m 26shbase-server in the patch passed.
291m 13s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6033
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 8a498a4a6056 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 015f1d9
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/testReport/
Max. process+thread count4257 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚mvninstall2m 44sbranch-2 passed
+1 💚compile2m 44sbranch-2 passed
+1 💚checkstyle0m 34sbranch-2 passed
+1 💚spotbugs1m 25sbranch-2 passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile2m 43sthe patch passed
+1 💚javac2m 43sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 35sthe patch passed
+1 💚spotbugs1m 33sthe patch passed
+1 💚hadoopcheck9m 40sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 8sThe patch does not generate ASF License warnings.
28m 48s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6033
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 53fb52b65c90 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ef21185
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 20sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 57sbranch-2 passed
+1 💚compile0m 55sbranch-2 passed
+1 💚javadoc0m 29sbranch-2 passed
+1 💚shadedjars5m 21sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚javadoc0m 29sthe patch passed
+1 💚shadedjars5m 21spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit209m 1shbase-server in the patch passed.
233m 4s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6033
Optional Testsjavac javadoc unit compile shadedjars
unameLinux b767c1750ecd 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ef21185
Default JavaEclipse Adoptium-17.0.10+7
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/testReport/
Max. process+thread count4752 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 57sbranch-2 passed
+1 💚compile0m 39sbranch-2 passed
+1 💚javadoc0m 24sbranch-2 passed
+1 💚shadedjars6m 20sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 15sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚javadoc0m 32sthe patch passed
+1 💚shadedjars7m 12spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit220m 15shbase-server in the patch passed.
247m 30s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6033
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 210eeb12fcd2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ef21185
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/testReport/
Max. process+thread count4277 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 52sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 53sbranch-2 passed
+1 💚compile0m 53sbranch-2 passed
+1 💚javadoc0m 29sbranch-2 passed
+1 💚shadedjars7m 7sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 39sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚javadoc0m 30sthe patch passed
+1 💚shadedjars6m 57spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit268m 19s/patch-unit-hbase-server.txthbase-server in the patch failed.
297m 6s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6033
Optional Testsjavac javadoc unit compile shadedjars
unameLinux b1d43cbf49c6 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / ef21185
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/testReport/
Max. process+thread count4168 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6033/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang
jojochuang requested a review from Apache9July 8, 2024 19:20
@jojochuang

Copy link
Copy Markdown
ContributorAuthor

@Apache9 can i have your review again? Due to code refactors, the changes for branch-2 is quite different.

@jojochuang
jojochuang merged commit 059a895 into apache:branch-2Jul 10, 2024
@jojochuang

Copy link
Copy Markdown
ContributorAuthor

Thanks @Apache9

szucsvillo pushed a commit to szucsvillo/hbase that referenced this pull request Sep 9, 2024
…lose fails (apache#5962) (apache#6033)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 0e8cfdb)
(cherry picked from commit b881296)
Change-Id: I6ad1d3122a0452d583a7269be9dbc3851f4f3a37
szucsvillo pushed a commit to szucsvillo/hbase that referenced this pull request Feb 7, 2025
…lose fails (apache#5962) (apache#6033)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 0e8cfdb)
(cherry picked from commit b881296)
Change-Id: I6ad1d3122a0452d583a7269be9dbc3851f4f3a37
(cherry picked from commit b68fecf)
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 22, 2025
…lose fails (apache#5962) (apache#6033)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 0e8cfdb)
(cherry picked from commit b881296)
Change-Id: I6ad1d3122a0452d583a7269be9dbc3851f4f3a37
(cherry picked from commit b68fecf)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jojochuang@Apache-HBase@Apache9