Skip to content

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2 - #6098

Merged
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:28716-branch-2
Jul 23, 2024
Merged

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2#6098
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:28716-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented Jul 19, 2024

Copy link
Copy Markdown
Member

No description provided.

@charlesconnell@ndimiduk
HBASE-28716 Users of QuotaRetriever should pass an existing connection (
305b08e
apache#6065)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jul 19, 2024
@charlesconnell

charlesconnell commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

This and the other 2.x PRs for this ticket require a change to HBaseAdmin to use the new QuotaRetriever constructor

@ndimiduk

ndimiduk commented Jul 19, 2024

Copy link
Copy Markdown
MemberAuthor

This and the other 2.x PRs for this ticket require a change to HBaseAdmin to use the new QuotaRetriever constructor

Okay. Let me do a search for other usages of this class on branch-2.

@ndimiduk

ndimiduk commented Jul 19, 2024

Copy link
Copy Markdown
MemberAuthor

Or would you prefer to handle the branch-2 backport?

@charlesconnell

charlesconnell commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

I trust you!

@Apache-HBase

This comment has been minimized.

Sign in to view
@ndimiduk

ndimiduk commented Jul 19, 2024

Copy link
Copy Markdown
MemberAuthor

I don't find any more static usage on branch-2.

@Apache-HBase

This comment has been minimized.

Sign in to view
charlesconnell
charlesconnell approved these changes Jul 19, 2024
View reviewed changes

@charlesconnellcharlesconnell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

Apache-HBase commented Jul 22, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 57sbranch-2 passed
+1 💚compile3m 37sbranch-2 passed
+1 💚checkstyle0m 58sbranch-2 passed
+1 💚spotbugs2m 25sbranch-2 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile3m 37sthe patch passed
+1 💚javac3m 37sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 57sthe patch passed
+1 💚spotbugs2m 41sthe patch passed
+1 💚hadoopcheck15m 29sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 42spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
40m 25s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6098
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 0d7b8d5bf842 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b4bd02c
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 22, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 15sbranch-2 passed
+1 💚compile1m 12sbranch-2 passed
+1 💚javadoc0m 44sbranch-2 passed
+1 💚shadedjars6m 10sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 4sthe patch passed
+1 💚compile1m 10sthe patch passed
+1 💚javac1m 10sthe patch passed
+1 💚javadoc0m 43sthe patch passed
+1 💚shadedjars6m 10spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit8m 18shbase-client in the patch passed.
+1 💚unit219m 27shbase-server in the patch passed.
255m 54s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6098
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 1ed73742169c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b4bd02c
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/testReport/
Max. process+thread count4398 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

ndimiduk commented Jul 22, 2024

Copy link
Copy Markdown
MemberAuthor

WTF jenkins?
image

@Apache-HBase

Apache-HBase commented Jul 22, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 43sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 4sbranch-2 passed
+1 💚compile3m 35sbranch-2 passed
+1 💚checkstyle0m 54sbranch-2 passed
+1 💚spotbugs2m 16sbranch-2 passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile3m 31sthe patch passed
+1 💚javac3m 31sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 51sthe patch passed
+1 💚spotbugs2m 33sthe patch passed
+1 💚hadoopcheck15m 55sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
40m 31s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6098
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux bb56502b19d7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b4bd02c
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

pankaj72981
pankaj72981 approved these changes Jul 22, 2024
View reviewed changes

@pankaj72981pankaj72981 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@Apache-HBase

Apache-HBase commented Jul 22, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 20sbranch-2 passed
+1 💚compile1m 28sbranch-2 passed
+1 💚javadoc0m 49sbranch-2 passed
+1 💚shadedjars6m 10sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile1m 14sthe patch passed
+1 💚javac1m 14sthe patch passed
+1 💚javadoc0m 50sthe patch passed
+1 💚shadedjars6m 11spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit8m 20shbase-client in the patch passed.
-1 ❌unit250m 17s/patch-unit-hbase-server.txthbase-server in the patch failed.
288m 10s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6098
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 59e7eb967ae9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b4bd02c
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/testReport/
Max. process+thread count4161 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 22, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall4m 45sbranch-2 passed
+1 💚compile1m 56sbranch-2 passed
+1 💚javadoc1m 7sbranch-2 passed
+1 💚shadedjars6m 33sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 34sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚javadoc1m 7sthe patch passed
+1 💚shadedjars6m 43spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit9m 28shbase-client in the patch passed.
-1 ❌unit334m 9s/patch-unit-hbase-server.txthbase-server in the patch failed.
379m 13s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6098
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 280cbbe15759 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b4bd02c
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/testReport/
Max. process+thread count4296 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 22, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 43sbranch-2 passed
+1 💚compile1m 49sbranch-2 passed
+1 💚javadoc1m 0sbranch-2 passed
+1 💚shadedjars6m 37sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 37sthe patch passed
+1 💚compile1m 39sthe patch passed
+1 💚javac1m 39sthe patch passed
+1 💚javadoc1m 1sthe patch passed
+1 💚shadedjars6m 53spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit9m 16shbase-client in the patch passed.
+1 💚unit347m 41shbase-server in the patch passed.
392m 19s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6098
Optional Testsjavac javadoc unit compile shadedjars
unameLinux bf954cd2d1a4 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / b4bd02c
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/testReport/
Max. process+thread count4610 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6098/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit fc4e1f9 into apache:branch-2Jul 23, 2024
@ndimiduk
ndimiduk deleted the 28716-branch-2 branch July 23, 2024 13:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charlesconnellcharlesconnellcharlesconnell approved these changes
@pankaj72981pankaj72981pankaj72981 approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndimiduk@charlesconnell@Apache-HBase@pankaj72981