Skip to content

HBASE-28756 RegionSizeCalculator ignored the size of memstore, which … - #6120

Merged
ddupg merged 1 commit into
apache:masterfrom
ddupg:HBASE-28756
Jul 26, 2024
Merged

HBASE-28756 RegionSizeCalculator ignored the size of memstore, which …#6120
ddupg merged 1 commit into
apache:masterfrom
ddupg:HBASE-28756

Conversation

@ddupg

@ddupgddupg commented Jul 25, 2024

Copy link
Copy Markdown
Member

…leads Spark miss data

@ddupgddupg self-assigned this Jul 25, 2024
@Apache-HBase

Apache-HBase commented Jul 25, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 17smaster passed
+1 💚compile0m 38smaster passed
+1 💚checkstyle0m 11smaster passed
+1 💚spotbugs0m 32smaster passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 1sthe patch passed
+1 💚compile0m 36sthe patch passed
+1 💚javac0m 36sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 10sthe patch passed
+1 💚spotbugs0m 37sthe patch passed
+1 💚hadoopcheck11m 38sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌spotless0m 40spatch has 51 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
29m 50s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6120
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 981bc1fdc217 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b551fb2
Default JavaEclipse Adoptium-17.0.11+9
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 25, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 17sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 25smaster passed
+1 💚compile0m 27smaster passed
+1 💚javadoc0m 19smaster passed
+1 💚shadedjars6m 21sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 14sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚javadoc0m 17sthe patch passed
+1 💚shadedjars6m 28spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit20m 22shbase-mapreduce in the patch passed.
43m 52s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6120
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 5b42679f9f73 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b551fb2
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/1/testReport/
Max. process+thread count3348 (vs. ulimit of 30000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Xin Sun
HBASE-28756 RegionSizeCalculator ignored the size of memstore, which …
f0a047e
…leads Spark miss data
Change-Id: Ib60fbe1e4d718d5164f76b744dcdedd94ce2fed6
@Apache-HBase

Apache-HBase commented Jul 25, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 4smaster passed
+1 💚compile0m 36smaster passed
+1 💚checkstyle0m 11smaster passed
+1 💚spotbugs0m 29smaster passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile0m 36sthe patch passed
+1 💚javac0m 36sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 11sthe patch passed
+1 💚spotbugs0m 37sthe patch passed
+1 💚hadoopcheck11m 30sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 8sThe patch does not generate ASF License warnings.
29m 25s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6120
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 7f62981bc5a3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f0a047e
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 25, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 14sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 57smaster passed
+1 💚compile0m 23smaster passed
+1 💚javadoc0m 16smaster passed
+1 💚shadedjars5m 21sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile0m 22sthe patch passed
+1 💚javac0m 22sthe patch passed
+1 💚javadoc0m 17sthe patch passed
+1 💚shadedjars5m 22spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit20m 30shbase-mapreduce in the patch passed.
39m 53s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6120
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 2a2182651b58 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f0a047e
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/2/testReport/
Max. process+thread count3540 (vs. ulimit of 30000)
modulesC: hbase-mapreduce U: hbase-mapreduce
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6120/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

pankaj72981
pankaj72981 approved these changes Jul 25, 2024
View reviewed changes

@pankaj72981pankaj72981 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@ddupg
ddupg merged commit 23d3d3d into apache:masterJul 26, 2024
ddupg added a commit that referenced this pull request Jul 26, 2024
@ddupgXin Sun
HBASE-28756RegionSizeCalculator ignored the size of memstore, which …
ee7d822
…leads Spark miss data (#6120)
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
ddupg pushed a commit that referenced this pull request Jul 26, 2024
Xin Sun
HBASE-28756RegionSizeCalculator ignored the size of memstore, which …
6e81029
…leads Spark miss data (#6120)
Change-Id: I7449f2b776369777600c583d22b811e1931e6559
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
ddupg pushed a commit that referenced this pull request Jul 26, 2024
Xin Sun
HBASE-28756RegionSizeCalculator ignored the size of memstore, which …
3e2ba48
…leads Spark miss data (#6120)
Change-Id: I7449f2b776369777600c583d22b811e1931e6559
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
ddupg pushed a commit that referenced this pull request Jul 26, 2024
Xin Sun
HBASE-28756RegionSizeCalculator ignored the size of memstore, which …
846c60a
…leads Spark miss data (#6120)
Change-Id: I7449f2b776369777600c583d22b811e1931e6559
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Aug 24, 2025
Xin Sun@mnpoonia
HBASE-28756 RegionSizeCalculator ignored the size of memstore, which …
857330d
…leads Spark miss data (apache#6120)
Change-Id: I7449f2b776369777600c583d22b811e1931e6559
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: apoonia <apoonia@salesforce.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes
@pankaj72981pankaj72981pankaj72981 approved these changes

Assignees

@ddupgddupg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddupg@Apache-HBase@Apache9@pankaj72981