Skip to content

HBASE-28389 HBase backup yarn queue parameter ignored - #6131

Merged
2005hithlj merged 1 commit into
apache:masterfrom
2005hithlj:HBASE-28389
Jul 31, 2024
Merged

HBASE-28389 HBase backup yarn queue parameter ignored#6131
2005hithlj merged 1 commit into
apache:masterfrom
2005hithlj:HBASE-28389

Conversation

@2005hithlj

Copy link
Copy Markdown
Contributor

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 4smaster passed
+1 💚compile0m 32smaster passed
+1 💚checkstyle0m 12smaster passed
+1 💚spotbugs0m 33smaster passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 54sthe patch passed
+1 💚compile0m 30sthe patch passed
+1 💚javac0m 30sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 11sthe patch passed
+1 💚spotbugs0m 37sthe patch passed
+1 💚hadoopcheck10m 31sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
27m 25s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6131/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6131
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 84b5b1f1b9b9 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e0ebb9f
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-backup U: hbase-backup
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6131/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 6smaster passed
+1 💚compile0m 21smaster passed
+1 💚javadoc0m 16smaster passed
+1 💚shadedjars5m 23sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 57sthe patch passed
+1 💚compile0m 21sthe patch passed
+1 💚javac0m 21sthe patch passed
+1 💚javadoc0m 15sthe patch passed
+1 💚shadedjars5m 22spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit11m 5shbase-backup in the patch passed.
30m 48s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6131/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6131
Optional Testsjavac javadoc unit compile shadedjars
unameLinux c074a040592e 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e0ebb9f
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6131/1/testReport/
Max. process+thread count3455 (vs. ulimit of 30000)
modulesC: hbase-backup U: hbase-backup
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6131/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj

Copy link
Copy Markdown
ContributorAuthor

This PR for branch master and branch-3.
@DieterDP-ng@Apache9 Could you take a look? Thanks.

@NihalJain

NihalJain commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Also could you please share how this PR was tested and which all commands were covered? I am not sure if writing a UT would be straightforward, if possible that would be great!

@2005hithlj

Copy link
Copy Markdown
ContributorAuthor

@NihalJain Thanks for your review. @DieterDP-ng has verified "Setting the queue through the configuration does work.", and the changes here is also simple and clear. Besides, the UT for this part is not easy to implement. Could you give me some suggestions?

@2005hithlj
2005hithlj merged commit 9dccc67 into apache:masterJul 31, 2024
2005hithlj added a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
(cherry picked from commit 9dccc67)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@2005hithlj@Apache-HBase@NihalJain@Apache9