Skip to content

HBASE-28433 Modify the assembly to not include test jars and their tr… - #6184

Merged
NihalJain merged 5 commits into
apache:masterfrom
NihalJain:HBASE-28433
Nov 8, 2024
Merged

HBASE-28433 Modify the assembly to not include test jars and their tr…#6184
NihalJain merged 5 commits into
apache:masterfrom
NihalJain:HBASE-28433

Conversation

@NihalJain

@NihalJainNihalJain commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

…ansitive dependencies

@NihalJain
NihalJain marked this pull request as draft August 30, 2024 06:51
@NihalJain

NihalJain commented Aug 30, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This will require HBASE-28432 to be inplace first. Putting this up to give a fair idea on how changes would look before I start HBASE-28432. Also test failures of this PR would give a fair idea on what all should be moved in new module as we refactor as part of HBASE-28432.

NihalJain
NihalJain commented Aug 30, 2024
View reviewed changes
Comment threadhbase-thrift/pom.xml
NihalJain
NihalJain commented Aug 30, 2024
View reviewed changes
Comment threadhbase-assembly/src/main/assembly/hadoop-three-compat.xml
NihalJain
NihalJain commented Aug 30, 2024
View reviewed changes
Comment threadbin/hbase
@NihalJain

This comment was marked as outdated.

Sign in to view
@NihalJain

NihalJain commented Aug 30, 2024

Copy link
Copy Markdown
ContributorAuthor

UT failures will say if we are being too aggressive here!

NihalJain
NihalJain commented Aug 30, 2024
View reviewed changes
Comment threadbin/hbase Outdated
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@ndimiduk

ndimiduk commented Sep 9, 2024

Copy link
Copy Markdown
Member

Nice to see progress here!

This was referenced Sep 16, 2024
Closed
Merged
stoty
stoty reviewed Sep 18, 2024
View reviewed changes
Comment threadhbase-assembly/src/main/assembly/client.xml
@NihalJain

NihalJain commented Oct 14, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Rebased code on top of #6258 to unblock progress here. Please look at commit adb7158 onwards for review purpose.

@NihalJain
NihalJain marked this pull request as ready for review October 14, 2024 11:27
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@NihalJain

NihalJain commented Oct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased code as #6258 is merged

@Apache-HBase

This comment has been minimized.

Sign in to view
NihalJain
NihalJain commented Oct 15, 2024
View reviewed changes
Comment threadhbase-assembly/pom.xml Outdated
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@NihalJain

NihalJain commented Oct 15, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Diff of assembly directories, master vs master with this PR:

hbase % diff -rq assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/LICENSE.txt and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/LICENSE.txt differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/NOTICE.txt and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/NOTICE.txt differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/bin/hbase and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/bin/hbase differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/master/WEB-INF/web.xml and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/master/WEB-INF/web.xml differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/regionserver/WEB-INF/web.xml and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/regionserver/WEB-INF/web.xml differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/thrift/WEB-INF/web.xml and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/hbase-webapps/thrift/WEB-INF/web.xml differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/include/utils/version.h and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/include/utils/version.h differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: HikariCP-java7-2.4.12.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: asm-analysis-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: asm-commons-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: asm-tree-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: commons-csv-1.9.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: ehcache-3.3.1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: fst-2.50.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: geronimo-jcache_1.0_spec-1.0-alpha-1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-common-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-hdfs-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-app-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-common-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-hs-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-jobclient-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-jobclient-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-mapreduce-client-shuffle-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-minicluster-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-minikdc-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-registry-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-common-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-nodemanager-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-resourcemanager-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-tests-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-timelineservice-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hadoop-yarn-server-web-proxy-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-annotations-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-annotations-4.0.0-alpha-1-SNAPSHOT.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-endpoint-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-endpoint-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-hadoop-compat-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-it-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-it-4.0.0-alpha-1-SNAPSHOT.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-shell-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-shell-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-testing-util-4.0.0-alpha-1-SNAPSHOT.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-thrift-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-thrift-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: java-util-1.9.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: javax-websocket-client-impl-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: javax-websocket-server-impl-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: javax.websocket-api-1.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: javax.websocket-client-api-1.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: jetty-annotations-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: jetty-jndi-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: jetty-plus-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: jna-5.2.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: json-io-2.5.1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: leveldbjni-all-1.8.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: mssql-jdbc-6.2.1.jre7.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-client-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-client-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-client-byo-hadoop-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-client-byo-hadoop-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-mapreduce-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT/lib/shaded-clients/hbase-shaded-mapreduce-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: websocket-server-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT/lib: websocket-servlet-9.4.48.v20220622.jar
hbase %

and

hbase % diff -rq assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/LICENSE.txt and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/LICENSE.txt differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/NOTICE.txt and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/NOTICE.txt differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/bin/hbase and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/bin/hbase differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: HikariCP-java7-2.4.12.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: asm-analysis-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: asm-commons-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: asm-tree-9.3.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: commons-csv-1.9.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: ehcache-3.3.1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: fst-2.50.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: geronimo-jcache_1.0_spec-1.0-alpha-1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-common-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-app-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-common-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-hs-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-jobclient-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-mapreduce-client-shuffle-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-minicluster-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-registry-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-common-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-nodemanager-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-resourcemanager-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-tests-3.3.5-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-timelineservice-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hadoop-yarn-server-web-proxy-3.3.5.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-shell-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-shell-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-thrift-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-thrift-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: java-util-1.9.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: javax-websocket-client-impl-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: javax-websocket-server-impl-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: javax.websocket-api-1.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: javax.websocket-client-api-1.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: jetty-annotations-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: jetty-jndi-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: jetty-plus-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: jna-5.2.0.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: json-io-2.5.1.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: leveldbjni-all-1.8.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: mssql-jdbc-6.2.1.jre7.jar
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-client-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-client-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-client-byo-hadoop-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-client-byo-hadoop-4.0.0-alpha-1-SNAPSHOT.jar differ
Files assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-mapreduce-4.0.0-alpha-1-SNAPSHOT.jar and assembly_HBASE-28433/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/shaded-clients/hbase-shaded-mapreduce-4.0.0-alpha-1-SNAPSHOT.jar differ
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: websocket-server-9.4.48.v20220622.jar
Only in assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client/lib: websocket-servlet-9.4.48.v20220622.jar
hbase %

Size Comparison, master vs master with this PR::

assembly_master:
total 1387688
705528 -rw-r--r--@ 1 nihaljain user 361228649 Oct 16 02:11 hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
682160 -rw-r--r--@ 1 nihaljain user 349262475 Oct 16 02:11 hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz
assembly_HBASE-28433:
total 1258728
630912 -rw-r--r--@ 1 nihaljain user 323023191 Oct 16 02:03 hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
627816 -rw-r--r--@ 1 nihaljain user 321441419 Oct 16 02:03 hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
stoty
stoty reviewed Oct 17, 2024
View reviewed changes
Comment threadhbase-thrift/pom.xml
Comment threadbin/hbase Outdated
Comment threadhbase-assembly/src/main/assembly/client.xml
Comment threadhbase-assembly/src/main/assembly/hadoop-three-compat.xml
Comment threadhbase-it/pom.xml
@NihalJain

NihalJain commented Oct 18, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you @stoty for reviewing the code, will have a look at comments and revert back soon.

@stoty

stoty commented Oct 18, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

I'm not sure hbase-it needs to be reverted anymore.

At first I thought that we shouldn't introduce this potenitally breaking change, but since this goes only into a new major version, maybe we should prioritize correctness over backwards compatibility with incorrectly set up downstream projects.

Whatever you decide to do with hbase-it is fine by me.

@NihalJain
- Improve the handling of how we run IT, other tools in dev environme…
555573c
…nt, now we revert back to directly using cached_classpath.txt to load jars required during runtime (as before). NOTE: To ensure cached_classpath is same as before this change, we retain some jars (including test jars) in assembly pom.xml which we actually remove during tarball creation.
@NihalJain

NihalJain commented Oct 21, 2024

Copy link
Copy Markdown
ContributorAuthor

I'm not sure hbase-it needs to be reverted anymore.

At first I thought that we shouldn't introduce this potenitally breaking change, but since this goes only into a new major version, maybe we should prioritize correctness over backwards compatibility with incorrectly set up downstream projects.

Whatever you decide to do with hbase-it is fine by me.

Went ahead with changing scope of the hadoop-minicluster jars from compile to test for correctness.

@NihalJain

NihalJain commented Oct 21, 2024

Copy link
Copy Markdown
ContributorAuthor

Summary of 4th commit:
This commit addresses the review comments and improves the handling of how we can run IT, other tools in dev environment post this change. Now we revert back to directly using cached_classpath.txt to load jars required during runtime (as before).
NOTE: To ensures the content of cached_classpath.txt is same as without this patch (which was not the case until commit 3 as we were removing dependencies from hbase-assembly), we retain some jars (including test jars) in assembly pom.xml although we actually remove them during tarball creation.

Only 1 review comment is pending: on checking whether *:test-jar is a safety check or if we really hit it. I have forgotten what was the case given I rasied v1 of this PR almost 2 months ago. Let me redo analysis and come back to you.

@NihalJain

NihalJain commented Oct 21, 2024

Copy link
Copy Markdown
ContributorAuthor

Updated Info:

  1. List of jars removed with this patch from our assembly
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/mockito-core-4.11.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/junit-4.13.2.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/hamcrest-core-1.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/websocket-servlet-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/websocket-server-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/mssql-jdbc-6.2.1.jre7.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/leveldbjni-all-1.8.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/json-io-2.5.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jna-5.2.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-plus-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-jndi-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-annotations-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.websocket-client-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.websocket-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax-websocket-server-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax-websocket-client-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/java-util-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/HikariCP-java7-2.4.12.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-testing-util-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-it-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-it-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-hadoop-compat-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-annotations-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-annotations-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-web-proxy-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-timelineservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-tests-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-resourcemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-nodemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-registry-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-minikdc-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-minicluster-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-shuffle-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-jobclient-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-jobclient-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-hs-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-app-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-hdfs-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-common-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/geronimo-jcache_1.0_spec-1.0-alpha-1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/fst-2.50.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/ehcache-3.3.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/commons-csv-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-tree-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-commons-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-analysis-9.3.jar

and

./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/mockito-core-4.11.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/junit-4.13.2.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/hamcrest-core-1.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/websocket-servlet-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/websocket-server-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/mssql-jdbc-6.2.1.jre7.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/leveldbjni-all-1.8.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/json-io-2.5.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jna-5.2.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-plus-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-jndi-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-annotations-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax.websocket-client-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax.websocket-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax-websocket-server-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax-websocket-client-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/java-util-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/HikariCP-java7-2.4.12.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-web-proxy-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-timelineservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-tests-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-resourcemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-nodemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-registry-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-minicluster-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-shuffle-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-jobclient-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-hs-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-app-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-common-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/geronimo-jcache_1.0_spec-1.0-alpha-1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/fst-2.50.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/ehcache-3.3.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/commons-csv-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-tree-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-commons-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-analysis-9.3.jar
  1. Size Comparison, master vs master with this PR::
705528 -rw-r--r--@ 1 nihaljain user 361228649 Oct 16 02:11 assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
682160 -rw-r--r--@ 1 nihaljain user 349262475 Oct 16 02:11 assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz

VS

629032 -rw-r--r--@ 1 nihaljain user 322063229 Oct 22 00:09 assembly_HBASE-28433_v2/hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
625944 -rw-r--r--@ 1 nihaljain user 320483247 Oct 22 00:09 assembly_HBASE-28433_v2/hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz
  1. Diff of cached paths: EMPTY
hbase % diff <( cat assembly_master/cached_classpath.txt | sed -e 's/:/\n/g' | sort) <( cat assembly_HBASE-28433_v2/cached_classpath.txt | sed -e 's/:/\n/g' | sort )
hbase %
  1. Started hbase cluster in standalone mode and tested following:
  • From extracted bin:
    • Started shell and verified basic CRUD
    • Triggered IntegrationTestsDriver: Fails as expected
    • Ran tools from last round of refactoring, no new issues seen
  • From compiled source bin:
    • Started shell and verified basic CRUD
    • Triggered IntegrationTestsDriver and no failure observed.

Please let me know if I should verify anything else.

@NihalJain
NihalJain requested a review from stotyOctober 21, 2024 19:08
@Apache-HBase

This comment has been minimized.

Sign in to view
NihalJain
NihalJain commented Oct 21, 2024
View reviewed changes
Comment threadhbase-assembly/pom.xml Outdated
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

Apache-HBase commented Oct 23, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall3m 47smaster passed
+1 💚compile12m 0smaster passed
+1 💚spotless1m 21sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for patch
+1 💚mvninstall4m 58sthe patch passed
+1 💚compile13m 33sthe patch passed
+1 💚javac13m 33sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚shellcheck0m 1sThe patch generated 0 new + 37 unchanged - 1 fixed = 37 total (was 38)
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck15m 24sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 55spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense1m 19sThe patch does not generate ASF License warnings.
65m 25s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6184
Optional Testsdupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile
unameLinux d2008eb8b632 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c1cc762
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count187 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/console
versionsgit=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 23, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall2m 51smaster passed
+1 💚compile2m 6smaster passed
+1 💚javadoc3m 36smaster passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile2m 5sthe patch passed
+1 💚javac2m 5sthe patch passed
+1 💚javadoc3m 33sthe patch passed
+1 💚shadedjars5m 8spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit300m 2sroot in the patch passed.
336m 54s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6184
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3d3f35b923b6 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c1cc762
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/testReport/
Max. process+thread count8677 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6184/8/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

stoty
stoty reviewed Oct 24, 2024
View reviewed changes
Comment threadhbase-assembly/pom.xml
stoty
stoty approved these changes Nov 7, 2024
View reviewed changes

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@NihalJain

NihalJain commented Nov 7, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you so much @stoty for patiently reviewing this one. I will be merging this in next few hours, unless no new reviews/objections comes up.

@NihalJain
NihalJain merged commit 3fbe4fb into apache:masterNov 8, 2024
NihalJain added a commit to NihalJain/hbase that referenced this pull request Nov 8, 2024
@NihalJain
HBASE-28433 Modify the assembly to not include test jars and their tr…
52e3370
…ansitive dependencies (apache#6184)
- Before this change, our assembly included test jars and test dependencies, which added unnecessary bloat to the assembly and classpath. This not only increases the distribution size but also potentially introduces CVE-prone JARs into the binary assemblies.
- With this change, we modify the assembly to exclude these test jars and their dependencies. This will result in a leaner, more secure assembly with a faster startup time.
- To ensure cached_classpath is same as before this change, we retain some jars (including test jars) in assembly pom.xml which we actually remove during tarball creation.
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit 3fbe4fb)
@NihalJainNihalJain mentioned this pull request Nov 8, 2024
Merged
NihalJain added a commit that referenced this pull request Nov 11, 2024
@NihalJain
HBASE-28433Modify the assembly to not include test jars and their tr…
aad1242
…ansitive dependencies (#6184) (#6452)
- Before this change, our assembly included test jars and test dependencies, which added unnecessary bloat to the assembly and classpath. This not only increases the distribution size but also potentially introduces CVE-prone JARs into the binary assemblies.
- With this change, we modify the assembly to exclude these test jars and their dependencies. This will result in a leaner, more secure assembly with a faster startup time.
- To ensure cached_classpath is same as before this change, we retain some jars (including test jars) in assembly pom.xml which we actually remove during tarball creation.
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit 3fbe4fb)
vinayakphegde added a commit to vinayakphegde/hbase that referenced this pull request Jan 21, 2025
@vinayakphegde
Revert "HBASE-28433 Modify the assembly to not include test jars and …
1e4f0b9
…their transitive dependencies (apache#6184)"
This reverts commit 3fbe4fb.
vinayakphegde added a commit to vinayakphegde/hbase that referenced this pull request Feb 4, 2025
@vinayakphegde
Revert "HBASE-28433 Modify the assembly to not include test jars and …
cee334f
…their transitive dependencies (apache#6184)"
This reverts commit 3fbe4fb.
vinayakphegde added a commit to vinayakphegde/hbase that referenced this pull request Feb 27, 2025
@vinayakphegde
Revert "HBASE-28433 Modify the assembly to not include test jars and …
bcd9af9
…their transitive dependencies (apache#6184)"
This reverts commit 3fbe4fb.
vinayakphegde added a commit to vinayakphegde/hbase that referenced this pull request Mar 7, 2025
@vinayakphegde
Revert "HBASE-28433 Modify the assembly to not include test jars and …
d6d4f96
…their transitive dependencies (apache#6184)"
This reverts commit 3fbe4fb.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimidukndimidukAwaiting requested review from ndimiduk
1 more reviewer
@stotystotystoty approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NihalJain@Apache-HBase@ndimiduk@stoty