Skip to content

HBASE-28433 Modify the assembly to not include test jars and their transitive dependencies - #6452

Merged
NihalJain merged 1 commit into
apache:branch-3from
NihalJain:HBASE-28433_branch-3
Nov 11, 2024
Merged

HBASE-28433 Modify the assembly to not include test jars and their transitive dependencies#6452
NihalJain merged 1 commit into
apache:branch-3from
NihalJain:HBASE-28433_branch-3

Conversation

@NihalJain

Copy link
Copy Markdown
Contributor

…ansitive dependencies (apache#6184)
- Before this change, our assembly included test jars and test dependencies, which added unnecessary bloat to the assembly and classpath. This not only increases the distribution size but also potentially introduces CVE-prone JARs into the binary assemblies.
- With this change, we modify the assembly to exclude these test jars and their dependencies. This will result in a leaner, more secure assembly with a faster startup time.
- To ensure cached_classpath is same as before this change, we retain some jars (including test jars) in assembly pom.xml which we actually remove during tarball creation.
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit 3fbe4fb)
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Nov 8, 2024
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+0 🆗shelldocs0m 1sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-3 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 6sbranch-3 passed
+1 💚compile8m 11sbranch-3 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 54sthe patch passed
+1 💚compile8m 17sthe patch passed
+1 💚javac8m 17sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚shellcheck0m 0sThe patch generated 0 new + 37 unchanged - 1 fixed = 37 total (was 38)
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck10m 27sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense1m 13sThe patch does not generate ASF License warnings.
43m 59s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6452/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6452
Optional Testsdupname asflicense codespell detsecrets shellcheck shelldocs spotless javac xmllint hadoopcheck compile
unameLinux b90cd10e731f 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 52e3370
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count194 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6452/3/console
versionsgit=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 20sbranch-3 passed
+1 💚compile2m 23sbranch-3 passed
+1 💚javadoc4m 44sbranch-3 passed
+1 💚shadedjars6m 54sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 30sthe patch passed
+1 💚compile2m 58sthe patch passed
+1 💚javac2m 58sthe patch passed
+1 💚javadoc3m 22sthe patch passed
+1 💚shadedjars7m 11spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit327m 6s/patch-unit-root.txtroot in the patch failed.
370m 9s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6452/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6452
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d744795dd3b3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 52e3370
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6452/3/testReport/
Max. process+thread count5348 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-shell hbase-endpoint hbase-it hbase-examples hbase-assembly . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6452/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
NihalJain merged commit aad1242 into apache:branch-3Nov 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NihalJain@Apache-HBase