Skip to content

Backport "HBASE-28842 TestRequestAttributes should fail when expected (#6255)" to branch-2 - #6268

Merged
rmdmattingly merged 1 commit into
branch-2from
28842-branch-2
Sep 23, 2024
Merged

Backport "HBASE-28842 TestRequestAttributes should fail when expected (#6255)" to branch-2#6268
rmdmattingly merged 1 commit into
branch-2from
28842-branch-2

Conversation

@rmdmattingly

@rmdmattinglyrmdmattingly commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

@eab148 am I correct that this is the only change introduced by this commit to branch-2 since this bug was discovered in the backport?

@eab148Evie BolandRay Mattingly
HBASE-28842TestRequestAttributes should fail when expected (#6255)
480b7f2
Co-authored-by: Evie Boland <eboland@hubspot.com>
Signed-off-by: Ray Mattingly <rmattingly@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@rmdmattinglyrmdmattingly changed the title HBASE-28842 TestRequestAttributes should fail when expected (#6255)Backport "HBASE-28842 TestRequestAttributes should fail when expected (#6255)" to branch-2Sep 18, 2024
@Apache-HBase

Apache-HBase commented Sep 18, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 20sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 6sbranch-2 passed
+1 💚compile2m 53sbranch-2 passed
+1 💚checkstyle0m 39sbranch-2 passed
+1 💚spotbugs1m 36sbranch-2 passed
+1 💚spotless0m 48sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 54sthe patch passed
+1 💚compile2m 55sthe patch passed
+1 💚javac2m 55sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 38sthe patch passed
+1 💚spotbugs1m 45sthe patch passed
+1 💚hadoopcheck15m 16sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
35m 29s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6268
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 9fa1802fa738 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 480b7f2
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 19, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 15sbranch-2 passed
+1 💚compile0m 50sbranch-2 passed
+1 💚javadoc0m 26sbranch-2 passed
+1 💚shadedjars5m 55sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile0m 50sthe patch passed
+1 💚javac0m 50sthe patch passed
+1 💚javadoc0m 25sthe patch passed
+1 💚shadedjars5m 55spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit221m 45shbase-server in the patch passed.
247m 9s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6268
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 8771def2d6b0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 480b7f2
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/testReport/
Max. process+thread count4412 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 19, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 9sbranch-2 passed
+1 💚compile0m 57sbranch-2 passed
+1 💚javadoc0m 31sbranch-2 passed
+1 💚shadedjars5m 28sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚javadoc0m 29sthe patch passed
+1 💚shadedjars5m 30spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit222m 58s/patch-unit-hbase-server.txthbase-server in the patch failed.
248m 24s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6268
Optional Testsjavac javadoc unit compile shadedjars
unameLinux f20382c41b98 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 480b7f2
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/testReport/
Max. process+thread count4778 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 19, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 35sbranch-2 passed
+1 💚compile0m 45sbranch-2 passed
+1 💚javadoc0m 28sbranch-2 passed
+1 💚shadedjars4m 54sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 28sthe patch passed
+1 💚compile0m 45sthe patch passed
+1 💚javac0m 45sthe patch passed
+1 💚javadoc0m 25sthe patch passed
+1 💚shadedjars4m 54spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit299m 15s/patch-unit-hbase-server.txthbase-server in the patch failed.
322m 13s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6268
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 9b0cea078ab1 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 480b7f2
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/testReport/
Max. process+thread count4234 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Sep 19, 2024
@ndimiduk

ndimiduk commented Sep 19, 2024

Copy link
Copy Markdown
Member

Test failures look unrelated. Prompting a new test run.

@ndimiduk

ndimiduk commented Sep 19, 2024

Copy link
Copy Markdown
Member

Yeah it looks to me like some of these test changes were snuck past me in the backport of HBASE-28001 to branch-2 (#6246) and branch-2.6 (#6256). Normally under such a circumstance, I find it easier to track when we re-open the original JIRA for a revert + fixes apply (ideally), or an addendum commit (unfortunately also common).

I see that there is a minor inconsistency in the method signature of isValidRequestAttributes across the versions. As much as possible, we want the code to match line-for-line across branches. It's a foundation of our the community's strategy for maintaining multile active release lines via backports.

Let's continue as we are with the second issue. It looks to me like there will be two shapes of commit for this change. The first applies to master and branch-3 only, which fixed the bug that was fixed in the branch-2 backport of HBASE-28001. The second patch applies to branch-2 and branch-2.6, which aligns the method signatures with what is present on master.

@Apache-HBase

Apache-HBase commented Sep 19, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 20sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 2sbranch-2 passed
+1 💚compile2m 52sbranch-2 passed
+1 💚checkstyle0m 39sbranch-2 passed
+1 💚spotbugs1m 35sbranch-2 passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 52sthe patch passed
+1 💚compile2m 46sthe patch passed
+1 💚javac2m 46sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 38sthe patch passed
+1 💚spotbugs1m 46sthe patch passed
+1 💚hadoopcheck15m 9sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
35m 3s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6268
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux a50616637670 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 480b7f2
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@eab148

eab148 commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

Let's continue as we are with the second issue. It looks to me like there will be two shapes of commit for this change. The first applies to master and branch-3 only, which fixed the bug that was fixed in the branch-2 backport of HBASE-28001. The second patch applies to branch-2 and branch-2.6, which aligns the method signatures with what is present on master.

@rmdmattingly, what @ndimiduk said is correct. Apologies about the changed method signatures!

@Apache-HBase

Apache-HBase commented Sep 19, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 4sbranch-2 passed
+1 💚compile0m 59sbranch-2 passed
+1 💚javadoc0m 29sbranch-2 passed
+1 💚shadedjars5m 28sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 57sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚javadoc0m 29sthe patch passed
+1 💚shadedjars5m 29spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit220m 31s/patch-unit-hbase-server.txthbase-server in the patch failed.
245m 42s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6268
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 3060b229c960 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 480b7f2
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/testReport/
Max. process+thread count4954 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 19, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 29sbranch-2 passed
+1 💚compile0m 44sbranch-2 passed
+1 💚javadoc0m 27sbranch-2 passed
+1 💚shadedjars4m 55sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile0m 44sthe patch passed
+1 💚javac0m 44sthe patch passed
+1 💚javadoc0m 26sthe patch passed
+1 💚shadedjars4m 51spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit238m 30s/patch-unit-hbase-server.txthbase-server in the patch failed.
261m 2s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6268
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 3724963606dd 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 480b7f2
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/testReport/
Max. process+thread count4265 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@rmdmattingly

rmdmattingly commented Sep 19, 2024

Copy link
Copy Markdown
ContributorAuthor

Test failure again looks unrelated. For such a trivial diff, I'm inclined to move forward. Separately, maybe we should begin taking account of these noisy test failures.

@Apache-HBase

Apache-HBase commented Sep 19, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 28sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 1sbranch-2 passed
+1 💚compile1m 3sbranch-2 passed
+1 💚javadoc0m 32sbranch-2 passed
+1 💚shadedjars6m 53sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 48sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚javadoc0m 30sthe patch passed
+1 💚shadedjars7m 17spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit328m 22s/patch-unit-hbase-server.txthbase-server in the patch failed.
359m 51s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6268
Optional Testsjavac javadoc unit compile shadedjars
unameLinux c4e86f4b9f62 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 480b7f2
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/testReport/
Max. process+thread count4253 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6268/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

ndimiduk commented Sep 23, 2024

Copy link
Copy Markdown
Member

Test failure again looks unrelated. For such a trivial diff, I'm inclined to move forward. Separately, maybe we should begin taking account of these noisy test failures.

Allow me to introduce you to our "Find Flaky Test" dashboard, for master and branch-2.

@rmdmattingly

rmdmattingly commented Sep 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Well, I wrote at least one of those 🫣

@rmdmattingly
rmdmattingly merged commit 414f24e into branch-2Sep 23, 2024
@rmdmattingly
rmdmattingly deleted the 28842-branch-2 branch September 23, 2024 19:37
rmdmattingly added a commit that referenced this pull request Sep 23, 2024
@rmdmattingly@eab148
Evie BolandRay Mattingly
HBASE-28842TestRequestAttributes should fail when expected (#6255) (#…
bd0e7bb
…6268)
Signed-off-by: Ray Mattingly <rmattingly@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com>
Co-authored-by: Evie Boland <eboland@hubspot.com>
@rmdmattinglyrmdmattingly mentioned this pull request Sep 23, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmdmattingly@Apache-HBase@ndimiduk@eab148