Skip to content

Backport "HBASE-28842 TestRequestAttributes should fail when expected (#6255)" to branch-2.6 - #6287

Merged
rmdmattingly merged 1 commit into
branch-2.6from
28842-branch-2.6
Sep 25, 2024
Merged

Backport "HBASE-28842 TestRequestAttributes should fail when expected (#6255)" to branch-2.6#6287
rmdmattingly merged 1 commit into
branch-2.6from
28842-branch-2.6

Conversation

@rmdmattingly

@rmdmattinglyrmdmattingly commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

The diff is a little weird. Full explanation here: #6268 (comment)

@rmdmattingly@eab148
Evie BolandRay Mattingly
HBASE-28842TestRequestAttributes should fail when expected (#6255) (#…
bd0e7bb
…6268)
Signed-off-by: Ray Mattingly <rmattingly@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com>
Co-authored-by: Evie Boland <eboland@hubspot.com>
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@ndimiduk

ndimiduk commented Sep 24, 2024

Copy link
Copy Markdown
Member

sigh

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

Apache-HBase commented Sep 24, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+1 💚mvninstall2m 56sbranch-2.6 passed
+1 💚compile2m 55sbranch-2.6 passed
+1 💚checkstyle0m 36sbranch-2.6 passed
+1 💚spotbugs1m 28sbranch-2.6 passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 54sthe patch passed
+1 💚compile2m 51sthe patch passed
+1 💚javac2m 51sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 36sthe patch passed
+1 💚spotbugs1m 39sthe patch passed
+1 💚hadoopcheck15m 53sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
35m 53s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6287
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 87cd20127eff 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / bd0e7bb
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count81 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 25, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 20sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 6sbranch-2.6 passed
+1 💚compile0m 57sbranch-2.6 passed
+1 💚javadoc0m 31sbranch-2.6 passed
+1 💚shadedjars5m 34sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 57sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚javadoc0m 30sthe patch passed
+1 💚shadedjars5m 27spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit209m 44s/patch-unit-hbase-server.txthbase-server in the patch failed.
234m 33s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6287
Optional Testsjavac javadoc unit compile shadedjars
unameLinux e877f901bd67 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / bd0e7bb
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/testReport/
Max. process+thread count4923 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 25, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall2m 46sbranch-2.6 passed
+1 💚compile0m 42sbranch-2.6 passed
+1 💚javadoc0m 24sbranch-2.6 passed
+1 💚shadedjars5m 24sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 25sthe patch passed
+1 💚compile0m 42sthe patch passed
+1 💚javac0m 42sthe patch passed
+1 💚javadoc0m 23sthe patch passed
+1 💚shadedjars5m 21spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit216m 8shbase-server in the patch passed.
239m 19s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6287
Optional Testsjavac javadoc unit compile shadedjars
unameLinux b7f8d488dad4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / bd0e7bb
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/testReport/
Max. process+thread count4284 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 25, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 6sbranch-2.6 passed
+1 💚compile0m 50sbranch-2.6 passed
+1 💚javadoc0m 25sbranch-2.6 passed
+1 💚shadedjars6m 7sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 9sthe patch passed
+1 💚compile0m 51sthe patch passed
+1 💚javac0m 51sthe patch passed
+1 💚javadoc0m 25sthe patch passed
+1 💚shadedjars6m 9spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit216m 43shbase-server in the patch passed.
242m 19s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6287
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 3dc95e95538b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / bd0e7bb
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/testReport/
Max. process+thread count4390 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6287/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

ndimiduk commented Sep 25, 2024

Copy link
Copy Markdown
Member

Good enough for me!

@rmdmattingly
rmdmattingly merged commit 6fda6b2 into branch-2.6Sep 25, 2024
@rmdmattingly
rmdmattingly deleted the 28842-branch-2.6 branch September 25, 2024 12:03
eab148 added a commit to HubSpot/hbase that referenced this pull request Oct 3, 2024
@rmdmattingly@eab148Evie Boland
HubSpot Backport: HBASE-28842 TestRequestAttributes should fail when …
85bbee8
…expected (apache#6255) (apache#6287)
Signed-off-by: Ray Mattingly <rmattingly@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com>
Co-authored-by: Evie Boland <eboland@hubspot.com>
eab148 added a commit to HubSpot/hbase that referenced this pull request Oct 3, 2024
@rmdmattingly@eab148Evie Boland
HubSpot Backport: HBASE-28842 TestRequestAttributes should fail when …
e1ca764
…expected (apache#6255) (apache#6287)
Signed-off-by: Ray Mattingly <rmattingly@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Co-authored-by: eab148 <54775485+eab148@users.noreply.github.com>
Co-authored-by: Evie Boland <eboland@hubspot.com>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Oct 4, 2024
@ndimiduk
Revert "HBASE-28842 TestRequestAttributes should fail when expected (a…
12e4d4d
…pache#6255) (apache#6287)"
This reverts commit 6fda6b2.
eab148 added a commit to HubSpot/hbase that referenced this pull request Oct 4, 2024
@eab148@rmdmattinglyEvie Boland
HubSpot Backport: HBASE-28842 TestRequestAttributes should fail when …
00ff3c2
…expected (apache#6255) (apache#6287) (#117)
Signed-off-by: Ray Mattingly <rmattingly@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Co-authored-by: Ray Mattingly <rmattingly@apache.org>
Co-authored-by: Evie Boland <eboland@hubspot.com>
eab148 added a commit to HubSpot/hbase that referenced this pull request Oct 4, 2024
@eab148@rmdmattinglyEvie Boland
HubSpot Backport: HBASE-28842 TestRequestAttributes should fail when …
1498df4
…expected (apache#6255) (apache#6287) (#119)
Signed-off-by: Ray Mattingly <rmattingly@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Co-authored-by: Ray Mattingly <rmattingly@apache.org>
Co-authored-by: Evie Boland <eboland@hubspot.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmdmattingly@Apache-HBase@ndimiduk