HBASE-28832 Fixed TestInfoServersACL test by PDavid · Pull Request #6571 · apache/hbase

PDavid · 2025-01-06T07:13:21Z

There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page.

PDavid · 2025-01-06T07:14:04Z

This is an addendum for #6490.

PDavid · 2025-01-06T07:18:21Z


 @Test
 public void testTableActionsAvailableForAdmins() throws Exception {
- final String expectedAuthorizedContent = "Actions:";


The UI page does not have the colon anymore because I converted it to a HTML heading (<h2>Actions<h2>).
Alternatively we could expect here the HTML tags as well (<h2>Actions<h2>) but this way we are not depending on the actual HTML tag - if they change in the future the test will still be green.
What do you think?

Sounds good!

Apache-HBase · 2025-01-06T08:00:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 26s		master passed
+1 💚	compile	3m 19s		master passed
+1 💚	checkstyle	0m 39s		master passed
+1 💚	spotbugs	1m 41s		master passed
+1 💚	spotless	0m 47s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 22s		the patch passed
+1 💚	compile	3m 13s		the patch passed
+1 💚	javac	3m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 37s		the patch passed
+1 💚	spotbugs	1m 42s		the patch passed
+1 💚	hadoopcheck	11m 59s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 53s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		39m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6571/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6571
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 5e6dcd475816 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `eba6a85`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6571/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2025-01-06T09:44:43Z

Will wait for test results before merging.

Apache-HBase · 2025-01-06T10:46:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 13s		master passed
+1 💚	compile	0m 55s		master passed
+1 💚	javadoc	0m 27s		master passed
+1 💚	shadedjars	5m 53s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	0m 56s		the patch passed
+1 💚	javac	0m 56s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed
+1 💚	shadedjars	5m 50s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	180m 5s		hbase-server in the patch passed.
		205m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6571/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6571
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 46b27f506bff 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `eba6a85`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6571/1/testReport/
Max. process+thread count	5227 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6571/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

* There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page. (cherry picked from commit 43f728c)

* There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page.

* There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page. (cherry picked from commit 43f728c)

…3.3 (#6526) * HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 (#6490) First we upgraded to Bootstrap v4 - this was the majority of the changes - and then I upgraded to Bootstrap 5.3.3 - which is the latest non-vulnerable version according to https://security.snyk.io/package/npm/bootstrap/3.4.1 Changes were based on the migration documentation: - https://getbootstrap.com/docs/4.6/migration/ - https://getbootstrap.com/docs/5.3/migration/ Most of the changes are related to navbar-s, tabs and forms. The new Bootstrap look has a bit bigger font sizes but it is still OK in my opinion. Bootstrap v5 is not requiring JQuery anymore but we have some JQuery plugins (jquery.tablesorter.min.js, tab.js) which still need it so I left JQuery in. - Removed bootstrap-theme.min.css and Glyphicons icon font because these are not present anymore in newer Bootstrap versions. - Upgraded checked in Bootstrap CSS and JS files to v4. - Moved some inline CSS styles to hbase.css file (DRY). - The page-header class was dropped in Bootstrap v4 so added page-header small grey color to hbase.css. - Removed some unused imports in JSP files. - Improved the styling of the Log Level form - Replaced hbase_logo_small.png under thrift module with the hbase-server one. Reason: to make sure that they are the same size (this under thrift was smaller). - Upgraded checked in Bootstrap CSS and JS files to v5. - Migrated navbars for v5: - Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links. - Migrated data attributes. Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle. - form-inline was dropped in v5, so inline forms had to be styled with grid and utilities instead. - Added the favicon of the HBase website to the web UI pages. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain.cs@gmail.com> (cherry picked from commit 744ce13) * [ADDENDUM] HBASE-28832 Fixed TestInfoServersACL test (#6571) * There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page. (cherry picked from commit 43f728c) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

…3.3 (#6525) * HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 (#6490) First we upgraded to Bootstrap v4 - this was the majority of the changes - and then I upgraded to Bootstrap 5.3.3 - which is the latest non-vulnerable version according to https://security.snyk.io/package/npm/bootstrap/3.4.1 Changes were based on the migration documentation: - https://getbootstrap.com/docs/4.6/migration/ - https://getbootstrap.com/docs/5.3/migration/ Most of the changes are related to navbar-s, tabs and forms. The new Bootstrap look has a bit bigger font sizes but it is still OK in my opinion. Bootstrap v5 is not requiring JQuery anymore but we have some JQuery plugins (jquery.tablesorter.min.js, tab.js) which still need it so I left JQuery in. - Removed bootstrap-theme.min.css and Glyphicons icon font because these are not present anymore in newer Bootstrap versions. - Upgraded checked in Bootstrap CSS and JS files to v4. - Moved some inline CSS styles to hbase.css file (DRY). - The page-header class was dropped in Bootstrap v4 so added page-header small grey color to hbase.css. - Removed some unused imports in JSP files. - Improved the styling of the Log Level form - Replaced hbase_logo_small.png under thrift module with the hbase-server one. Reason: to make sure that they are the same size (this under thrift was smaller). - Upgraded checked in Bootstrap CSS and JS files to v5. - Migrated navbars for v5: - Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links. - Migrated data attributes. Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle. - form-inline was dropped in v5, so inline forms had to be styled with grid and utilities instead. - Added the favicon of the HBase website to the web UI pages. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain.cs@gmail.com> (cherry picked from commit 744ce13) * [ADDENDUM] HBASE-28832 Fixed TestInfoServersACL test (#6571) * There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page. (cherry picked from commit 43f728c) Signed-off-by: Peter Somogyi <psomogyi@apache.org>

HBASE-28832 Fixed TestInfoServersACL test
eba6a85
There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page.

PDavid commented Jan 6, 2025
View reviewed changes

PDavid mentioned this pull request Jan 6, 2025
HBASE-28832 Fixed TestInfoServersACL test #6572
Merged

NihalJain approved these changes Jan 6, 2025
View reviewed changes

PDavid marked this pull request as ready for review January 6, 2025 11:03

NihalJain merged commit 43f728c into apache:masterJan 6, 2025

PDavid deleted the HBASE-28832-bootstrap-upgrade-5-addendum branch January 8, 2025 13:55

Navigation Menu

Uh oh!

HBASE-28832 Fixed TestInfoServersACL test - #6571

HBASE-28832 Fixed TestInfoServersACL test#6571
NihalJain merged 1 commit into
apache:masterfrom
PDavid:HBASE-28832-bootstrap-upgrade-5-addendum

PDavid commented Jan 6, 2025

Uh oh!

PDavid commented Jan 6, 2025

Uh oh!

PDavidJan 6, 2025

Uh oh!

NihalJainJan 6, 2025

Uh oh!

Apache-HBase commented Jan 6, 2025

Uh oh!

NihalJain commented Jan 6, 2025

Uh oh!

Apache-HBase commented Jan 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PDavid commented Jan 6, 2025

Uh oh!

PDavid commented Jan 6, 2025

Uh oh!

PDavidJan 6, 2025

Choose a reason for hiding this comment

Uh oh!

NihalJainJan 6, 2025

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 6, 2025

Uh oh!

NihalJain commented Jan 6, 2025

Uh oh!

Apache-HBase commented Jan 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants