Skip to content

HBASE-28832 Fixed TestInfoServersACL test - #6572

Merged
stoty merged 1 commit into
apache:branch-3from
PDavid:HBASE-28832-bootstrap-upgrade-5-branch-3-addendum
Jan 15, 2025
Merged

HBASE-28832 Fixed TestInfoServersACL test#6572
stoty merged 1 commit into
apache:branch-3from
PDavid:HBASE-28832-bootstrap-upgrade-5-branch-3-addendum

Conversation

@PDavid

Copy link
Copy Markdown
Contributor

There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page.

@PDavid

Copy link
Copy Markdown
ContributorAuthor

This is the same as #6571 but for branch-3.

@NihalJain

Copy link
Copy Markdown
Contributor

Hi @PDavid We are good to merge this? Right?

@PDavid

Copy link
Copy Markdown
ContributorAuthor

Hi @PDavid We are good to merge this? Right?

Hi @NihalJain,

Actually I wanted to wait for a green build but as far as I see, the PR build timed out.
Should we rerun it maybe? I don't have permission to do it. Or I can also try to rebase the branch to run it again. 🤔

@PDavid
PDavidforce-pushed the HBASE-28832-bootstrap-upgrade-5-branch-3-addendum branch from fcb227c to bcb4587CompareJanuary 7, 2025 08:24
@NihalJain

NihalJain commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Hi @PDavid We are good to merge this? Right?

Hi @NihalJain,

Actually I wanted to wait for a green build but as far as I see, the PR build timed out. Should we rerun it maybe? I don't have permission to do it. Or I can also try to rebase the branch to run it again. 🤔

Sure let me re-trigger!

@NihalJain

Copy link
Copy Markdown
Contributor

Hi @PDavid We are good to merge this? Right?

Hi @NihalJain,
Actually I wanted to wait for a green build but as far as I see, the PR build timed out. Should we rerun it maybe? I don't have permission to do it. Or I can also try to rebase the branch to run it again. 🤔

Sure let me re-trigger!

Oh I see already forced pushed, we are good then!

@PDavid
PDavid marked this pull request as ready for review January 8, 2025 13:57
There were some changes in the Bootstrap upgrade which caused the test to fail because the test expected certain text to appear on the UI page.
(cherry picked from commit eba6a85)
@PDavid
PDavidforce-pushed the HBASE-28832-bootstrap-upgrade-5-branch-3-addendum branch from bcb4587 to 9852363CompareJanuary 9, 2025 09:51
@PDavid

Copy link
Copy Markdown
ContributorAuthor

Rebased and force pushed again to trigger new build.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-3 Compile Tests _
+1 💚mvninstall4m 5sbranch-3 passed
+1 💚compile4m 8sbranch-3 passed
+1 💚checkstyle0m 40sbranch-3 passed
+1 💚spotbugs1m 47sbranch-3 passed
+1 💚spotless0m 49sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 44sthe patch passed
+1 💚compile3m 54sthe patch passed
+1 💚javac3m 54sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 59sthe patch passed
+1 💚spotbugs2m 21sthe patch passed
+1 💚hadoopcheck14m 33sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 51spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
46m 47s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6572
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux ca07d3daf08f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 9852363
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Jan 9, 2025
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+1 💚mvninstall3m 5sbranch-3 passed
+1 💚compile1m 0sbranch-3 passed
+1 💚javadoc0m 30sbranch-3 passed
+1 💚shadedjars5m 50sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚javadoc0m 26sthe patch passed
+1 💚shadedjars5m 43spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit189m 19shbase-server in the patch passed.
214m 33s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6572
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 4b4e91b9a073 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / 9852363
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/testReport/
Max. process+thread count4795 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6572/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty
stoty merged commit 931b857 into apache:branch-3Jan 15, 2025
@PDavid
PDavid deleted the HBASE-28832-bootstrap-upgrade-5-branch-3-addendum branch January 15, 2025 09:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@PDavid@NihalJain@Apache-HBase@stoty