Skip to content

HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI) - #7018

Merged
ndimiduk merged 1 commit into
apache:masterfrom
PDavid:HBASE-27802-fix-popovers-addendum
May 23, 2025
Merged

HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI)#7018
ndimiduk merged 1 commit into
apache:masterfrom
PDavid:HBASE-27802-fix-popovers-addendum

Conversation

@PDavid

@PDavidPDavid commented May 22, 2025

Copy link
Copy Markdown
Contributor

Popovers ("Metrics" menu) were not working on the UI and the following JS error was logged to browser console:

Uncaught TypeError: i.createPopper is not a function

This is because popper.js was not available on the page for Bootstrap.

Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.

@PDavidPDavid changed the title HBASE-27802 Fix not working popovers on UIHBASE-27802 Fix not working popovers on UI (addendum)May 22, 2025
@PDavidPDavid changed the title HBASE-27802 Fix not working popovers on UI (addendum)HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI)May 22, 2025
…dum: Fix not working popovers on UI)
Popovers were not working on the UI and the following JS error was logged to browser console:
```
Uncaught TypeError: i.createPopper is not a function
```
This is because popper.js was not available on the page for Bootstrap.
Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 51sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall4m 38smaster passed
+1 💚compile5m 11smaster passed
+1 💚spotless1m 1sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall4m 14sthe patch passed
+1 💚compile4m 59sthe patch passed
+1 💚javac4m 59sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck13m 13sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 49spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 28sThe patch does not generate ASF License warnings.
44m 2s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7018/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7018
Optional Testsdupname asflicense javac codespell detsecrets spotless xmllint hadoopcheck compile
unameLinux 0ccda74bb2da 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / afdb24c
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7018/1/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid

Copy link
Copy Markdown
ContributorAuthor

There are failing unit tests in the PR build but to me those look unrelated.

@PDavid
PDavid marked this pull request as ready for review May 23, 2025 12:15
@PDavid

Copy link
Copy Markdown
ContributorAuthor

Hi @NihalJain and @ndimiduk,
Can you please review this addendum fix? Many thanks in advance. 🙏

@NihalJain

Copy link
Copy Markdown
Contributor

+1, LGTM

@ndimiduk

Copy link
Copy Markdown
Member

The build timed out

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@PDavid@Apache-HBase@NihalJain@ndimiduk