HBASE-27802 Manage static javascript resources programatically by PDavid · Pull Request #7033 · apache/hbase

PDavid · 2025-05-26T05:06:40Z

As is

Currently, the static JavaScript, CSS resources need to be manually managed. That is, if any of these has to be updated, we will be required to download them from web and place them under the appropriate path. This can be cumbersome.

After

To be able to manage them with minimal manual effort we could manage them as part of build.

Approach

This solution is very similar to how we manage the websitestatic resources in our build: #6668

Download and extract the UI resources as webjars using the maven-dependency-plugin in our build. It will only copy the required files to the hbase-server/target/hbase-webapps/static directory.

The REST and Thrift projects copies the static JavaScript, CSS resources from hbase-server - as before.

This way the no new dependency is packaged into the application, only the required JS, CSS files are copied and packaged.

Upgrading in the future

From now on upgrading the static JavaScript, CSS resources means to:

Check if the webjar is available for the new version: if not, open a new request for it at: https://github.com/webjars/webjars-classic/issues/new
Increment the version properties in root pom.xml.

Upgrades

Also upgraded the following static resources to current latest version:

jquery: 3.5.1 -> 3.7.1
tablesorter: 2.31.3 -> 2.32.0

…e#6864) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 2f9d9fc)

…dum: Fix not working popovers on UI) Popovers were not working on the UI and the following JS error was logged to browser console: ``` Uncaught TypeError: i.createPopper is not a function ``` This is because popper.js was not available on the page for Bootstrap. Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.

PDavid · 2025-05-26T05:07:14Z

This is a backport of #6864 to branch-2. This PR already includes the addendum fix (#7018).

I cherry-picked the master commit and resolved the conflicts. The reason this patch was not applying clearly is that on master we have the website and the reference guide (asciidoc) building code but on other branches we don't.

I tested this backported patch the same way as I described here: #6864 (comment)

Apache-HBase · 2025-05-26T05:24:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	docker	0m 4s		Docker failed to build run-specific yetus/hbase:tp-13220}.

Subsystem	Report/Notes
GITHUB PR	#7033
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/console
versions	git=2.17.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-26T10:38:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s		branch-2 passed
+1 💚	compile	2m 13s		branch-2 passed
+1 💚	javadoc	2m 47s		branch-2 passed
+1 💚	shadedjars	6m 9s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	2m 14s		the patch passed
+1 💚	javac	2m 14s		the patch passed
+1 💚	javadoc	2m 41s		the patch passed
+1 💚	shadedjars	6m 9s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	279m 25s		root in the patch passed.
		316m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7033
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b1ab8af14cfc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `7edb4bd`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/testReport/
Max. process+thread count	8418 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-26T11:01:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 20s		branch-2 passed
+1 💚	compile	2m 12s		branch-2 passed
+1 💚	javadoc	2m 47s		branch-2 passed
+1 💚	shadedjars	6m 32s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 16s		the patch passed
+1 💚	compile	2m 12s		the patch passed
+1 💚	javac	2m 12s		the patch passed
+1 💚	javadoc	2m 41s		the patch passed
+1 💚	shadedjars	6m 29s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	301m 53s		root in the patch passed.
		340m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#7033
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f09d028ccc6e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `7edb4bd`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/testReport/
Max. process+thread count	8270 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-26T13:05:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 31s		branch-2 passed
+1 💚	compile	1m 45s		branch-2 passed
+1 💚	javadoc	2m 35s		branch-2 passed
+1 💚	shadedjars	5m 20s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 28s		the patch passed
+1 💚	compile	1m 48s		the patch passed
+1 💚	javac	1m 48s		the patch passed
+1 💚	javadoc	2m 29s		the patch passed
+1 💚	shadedjars	5m 16s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	428m 33s	/patch-unit-root.txt	root in the patch failed.
		463m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#7033
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5ffcbd3d7241 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `7edb4bd`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/testReport/
Max. process+thread count	7639 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7033/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid · 2025-05-27T05:57:48Z

One replication-related test failed with timeout in the PR build but I think that is unrelated.

NihalJain · 2025-05-27T10:23:23Z

Hi @PDavid Should I merge this and related PRs?

PDavid · 2025-05-27T10:30:16Z

Hi @PDavid Should I merge this and related PRs?

Hi @NihalJain,
Yes, please merge these. Many thank in advance. 🙏

ndimiduk · 2025-05-27T12:10:55Z

Ah. Thanks @NihalJain !

…e#7033) * HBASE-27802 Manage static javascript resources programatically (apache#6864) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 2f9d9fc) * HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI) Popovers were not working on the UI and the following JS error was logged to browser console: ``` Uncaught TypeError: i.createPopper is not a function ``` This is because popper.js was not available on the page for Bootstrap. Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap. --------- Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

PDavid added 2 commits May 23, 2025 14:51

HBASE-27802 Manage static javascript resources programatically (apach…
62b3d0f
…e#6864) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 2f9d9fc)

PDavid marked this pull request as ready for review May 27, 2025 05:57

PDavid mentioned this pull request May 27, 2025
HBASE-27802 Manage static javascript resources programatically #6864
Merged

NihalJain merged commit ba4f01c into apache:branch-2May 27, 2025

PDavid deleted the HBASE-27802-js-programatically-branch-2 branch May 27, 2025 13:09

Navigation Menu

Uh oh!

HBASE-27802 Manage static javascript resources programatically - #7033

HBASE-27802 Manage static javascript resources programatically#7033
NihalJain merged 2 commits into
apache:branch-2from
PDavid:HBASE-27802-js-programatically-branch-2

PDavid commented May 26, 2025

Uh oh!

PDavid commented May 26, 2025

Uh oh!

Apache-HBase commented May 26, 2025

Uh oh!

Apache-HBase commented May 26, 2025

Uh oh!

Apache-HBase commented May 26, 2025

Uh oh!

Apache-HBase commented May 26, 2025

Uh oh!

PDavid commented May 27, 2025

Uh oh!

NihalJain commented May 27, 2025

Uh oh!

PDavid commented May 27, 2025

Uh oh!

ndimiduk commented May 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

PDavid commented May 26, 2025

As is

After

Approach

Upgrading in the future

Upgrades

Uh oh!

PDavid commented May 26, 2025

Uh oh!

Apache-HBase commented May 26, 2025

Uh oh!

Apache-HBase commented May 26, 2025

Uh oh!

Apache-HBase commented May 26, 2025

Uh oh!

Apache-HBase commented May 26, 2025

Uh oh!

PDavid commented May 27, 2025

Uh oh!

NihalJain commented May 27, 2025

Uh oh!

PDavid commented May 27, 2025

Uh oh!

ndimiduk commented May 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants