Skip to content

HBASE-29609 Upgrade checkstyle and Maven checkstyle plugin to support Java 14+ syntax - #7365

Merged
PDavid merged 1 commit into
apache:masterfrom
PDavid:HBASE-29609-checkstyle-upgrade-2
Oct 16, 2025
Merged

HBASE-29609 Upgrade checkstyle and Maven checkstyle plugin to support Java 14+ syntax#7365
PDavid merged 1 commit into
apache:masterfrom
PDavid:HBASE-29609-checkstyle-upgrade-2

Conversation

@PDavid

Copy link
Copy Markdown
Contributor

No description provided.

@PDavidPDavid self-assigned this Oct 7, 2025
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid
PDavid marked this pull request as ready for review October 7, 2025 15:10
@PDavid
PDavid requested a review from stotyOctober 7, 2025 15:10
@PDavid

Copy link
Copy Markdown
ContributorAuthor

Tested this with the following commands:

mvn clean install -DskipTests && mvn site
mvn test -Dtest=TestSnapshotProcedureEarlyExpiration -pl hbase-server && mvn surefire-report:report-only

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@PDavid

Copy link
Copy Markdown
ContributorAuthor

Opened a backport for branch-3 here: #7367

This checkstyle version is not working with Java 8 so this cannot be backported to branch-x branches.

@PDavid
PDavidforce-pushed the HBASE-29609-checkstyle-upgrade-2 branch from 8bb4be2 to 54fb613CompareOctober 16, 2025 08:04
@PDavid

Copy link
Copy Markdown
ContributorAuthor

Rebased the branch to make sure it works fine with latest master.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 51sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 48smaster passed
+1 💚compile12m 11smaster passed
+1 💚spotless1m 16sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall4m 53sthe patch passed
+1 💚compile13m 29sthe patch passed
+1 💚javac13m 29sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck17m 41sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless1m 8spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
67m 6s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7365
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux 6f3e7ff467b8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 54fb613
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count190 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 37smaster passed
+1 💚compile2m 9smaster passed
+1 💚javadoc2m 1smaster passed
+1 💚shadedjars6m 21sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 2sthe patch passed
+1 💚compile2m 12sthe patch passed
+1 💚javac2m 12sthe patch passed
+1 💚javadoc1m 58sthe patch passed
+1 💚shadedjars6m 13spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit285m 7sroot in the patch passed.
320m 45s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7365
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e035cd466f1e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 54fb613
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/testReport/
Max. process+thread count8131 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7365/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid
PDavid merged commit 6d7829a into apache:masterOct 16, 2025
1 check passed
@PDavid
PDavid deleted the HBASE-29609-checkstyle-upgrade-2 branch October 16, 2025 15:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@PDavid@Apache-HBase@stoty@Apache9