Skip to content

HBASE-29609 Upgrade checkstyle and Maven checkstyle plugin to support Java 14+ syntax - #7367

Merged
PDavid merged 1 commit into
apache:branch-3from
PDavid:HBASE-29609-checkstyle-upgrade-branch-3
Nov 24, 2025
Merged

HBASE-29609 Upgrade checkstyle and Maven checkstyle plugin to support Java 14+ syntax#7367
PDavid merged 1 commit into
apache:branch-3from
PDavid:HBASE-29609-checkstyle-upgrade-branch-3

Conversation

@PDavid

Copy link
Copy Markdown
Contributor

No description provided.

@PDavidPDavid self-assigned this Oct 8, 2025
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid

PDavid commented Oct 9, 2025

Copy link
Copy Markdown
ContributorAuthor

TestSCPWithMetaWithoutZKCoordinated test timed out in the PR build. I think it is unrelated to this change.

@PDavid
PDavid marked this pull request as ready for review October 9, 2025 06:30
@PDavid
PDavid requested a review from stotyOctober 9, 2025 06:30
@PDavidPDavid added the backport This PR is a back port of some issue or issues already committed to master label Oct 9, 2025
@PDavid

Copy link
Copy Markdown
ContributorAuthor

This is a backport of #7365 to branch-3.

Tested this with the following commands:

mvn clean install -DskipTests && mvn site
mvn test -Dtest=TestSnapshotProcedureEarlyExpiration -pl hbase-server && mvn surefire-report:report-only

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid
PDavidforce-pushed the HBASE-29609-checkstyle-upgrade-branch-3 branch from 6d464e2 to 4196f8cCompareOctober 17, 2025 11:49
@PDavid

Copy link
Copy Markdown
ContributorAuthor

Rebased the feature branch to have latest changes of branch-3.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid
PDavidforce-pushed the HBASE-29609-checkstyle-upgrade-branch-3 branch from 4196f8c to b178e09CompareNovember 5, 2025 09:46
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-3 Compile Tests _
+1 💚mvninstall3m 40sbranch-3 passed
+1 💚compile8m 47sbranch-3 passed
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 14sthe patch passed
+1 💚compile8m 41sthe patch passed
+1 💚javac8m 41sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck12m 25sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 47spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
46m 49s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7367
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux 0d9db57b4e15 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / b178e09
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count189 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-3 Compile Tests _
+1 💚mvninstall3m 44sbranch-3 passed
+1 💚compile2m 13sbranch-3 passed
+1 💚javadoc1m 59sbranch-3 passed
+1 💚shadedjars6m 16sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 9sthe patch passed
+1 💚compile2m 11sthe patch passed
+1 💚javac2m 11sthe patch passed
+1 💚javadoc1m 56sthe patch passed
+1 💚shadedjars6m 9spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit284m 18s/patch-unit-root.txtroot in the patch failed.
320m 20s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7367
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 947a63dc3fdf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-3 / b178e09
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/testReport/
Max. process+thread count7910 (vs. ulimit of 30000)
modulesC: . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7367/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty

Copy link
Copy Markdown
Contributor

This is the same as the master patch @PDavid ?

@PDavid

Copy link
Copy Markdown
ContributorAuthor

This is the same as the master patch @PDavid ?

@stoty Thanks, yes, this patch is the same as on master (#7365).

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@PDavid
PDavid merged commit 4370dfa into apache:branch-3Nov 24, 2025
1 check failed
@PDavid
PDavid deleted the HBASE-29609-checkstyle-upgrade-branch-3 branch November 24, 2025 09:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PDavid@Apache-HBase@stoty