Skip to content

HBASE-29820 Bump the syntax of velocity template to align with veloci… - #7614

Merged
stoty merged 1 commit into
apache:masterfrom
mnpoonia:velocity_update
Jan 19, 2026
Merged

HBASE-29820 Bump the syntax of velocity template to align with veloci…#7614
stoty merged 1 commit into
apache:masterfrom
mnpoonia:velocity_update

Conversation

@mnpoonia

@mnpooniamnpoonia commented Jan 11, 2026

Copy link
Copy Markdown
Contributor

…ty 2.x syntax

HBASE-29820

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 16sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 45smaster passed
+1 💚compile6m 43smaster passed
+1 💚spotless0m 57sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 21sthe patch passed
+1 💚compile6m 41sthe patch passed
+1 💚javac6m 41sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck13m 18sPatch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚spotless0m 51spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 48sThe patch does not generate ASF License warnings.
45m 59s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7614
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux 897c658d5e47 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5f173ea
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

@stoty@Apache9 FYI. This change and one more that i am working seems to be a pre-requisite to update apache parent to anything greater than 29. We are currently on 23.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 36smaster passed
+1 💚compile1m 32smaster passed
+1 💚javadoc0m 52smaster passed
+1 💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 14sthe patch passed
+1 💚compile1m 33sthe patch passed
+1 💚javac1m 33sthe patch passed
+1 💚javadoc0m 52sthe patch passed
+1 💚shadedjars4m 32spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 7shbase-resource-bundle in the patch passed.
+1 💚unit0m 42shbase-http in the patch passed.
-1 ❌unit218m 0s/patch-unit-hbase-server.txthbase-server in the patch failed.
+1 💚unit0m 44shbase-shaded in the patch passed.
+1 💚unit0m 16shbase-assembly in the patch passed.
244m 48s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7614
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0ef29b1f7a78 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5f173ea
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/testReport/
Max. process+thread count5316 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7614/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

The test failures seems unrelated.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

@stoty thank you for the review. Do you want me to create a separate PR for branch-2. I didnot try cherry-picking this to branch-2 yet.

@stoty

Copy link
Copy Markdown
Contributor

Yes, let's follow the process and make a backport PR @mnpoonia ,

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

@stoty I tried cherrypicking and it was a clean cherry pick to branch-2 and branch-2.6. Should i still create a separate PR or its not needed.

@stoty

Copy link
Copy Markdown
Contributor

I would suggest creating a branch-2 PR to make sure that it works with the maven plugins used there.

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

@stoty Gentle reminder. Please look into it when you get time.

@stoty
stoty merged commit da824c8 into apache:masterJan 19, 2026
1 check failed
stoty pushed a commit that referenced this pull request Jan 19, 2026
…ty 2.x syntax (#7614)
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit da824c8)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mnpoonia@Apache-HBase@stoty