Skip to content

HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntax - #7622

Merged
stoty merged 1 commit into
apache:branch-2from
mnpoonia:backport_velcoity_version
Jan 19, 2026
Merged

HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntax#7622
stoty merged 1 commit into
apache:branch-2from
mnpoonia:backport_velcoity_version

Conversation

@mnpoonia

@mnpooniamnpoonia commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

@stoty FYI. This is backport for branch-2.x for PR #7614

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 18sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 55sbranch-2 passed
+1 💚compile6m 48sbranch-2 passed
+1 💚spotless0m 57sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 31sthe patch passed
+1 💚compile6m 50sthe patch passed
+1 💚javac6m 50sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck19m 33sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚spotless0m 52spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 55sThe patch does not generate ASF License warnings.
47m 5s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7622
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux a02199242d50 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d4176f6
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 51sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 29sbranch-2 passed
+1 💚compile2m 0sbranch-2 passed
+1 💚javadoc1m 10sbranch-2 passed
+1 💚shadedjars6m 47sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 8sthe patch passed
+1 💚compile2m 2sthe patch passed
+1 💚javac2m 2sthe patch passed
+1 💚javadoc1m 8sthe patch passed
+1 💚shadedjars6m 41spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 9shbase-resource-bundle in the patch passed.
+1 💚unit0m 55shbase-http in the patch passed.
+1 💚unit232m 46shbase-server in the patch passed.
+1 💚unit0m 58shbase-shaded in the patch passed.
+1 💚unit0m 29shbase-assembly in the patch passed.
268m 30s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7622
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4795efdf7eb8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d4176f6
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/testReport/
Max. process+thread count3293 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stotystoty added the backport This PR is a back port of some issue or issues already committed to master label Jan 14, 2026
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 17sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 2sbranch-2 passed
+1 💚compile1m 49sbranch-2 passed
+1 💚javadoc1m 9sbranch-2 passed
+1 💚shadedjars4m 56sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile1m 49sthe patch passed
+1 💚javac1m 49sthe patch passed
+1 💚javadoc1m 5sthe patch passed
+1 💚shadedjars5m 3spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 8shbase-resource-bundle in the patch passed.
+1 💚unit0m 42shbase-http in the patch passed.
-1 ❌unit309m 13s/patch-unit-hbase-server.txthbase-server in the patch failed.
+1 💚unit1m 22shbase-shaded in the patch passed.
+1 💚unit0m 25shbase-assembly in the patch passed.
338m 52s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7622
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0a5e7144c6d5 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d4176f6
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/testReport/
Max. process+thread count3316 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 18sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 23sbranch-2 passed
+1 💚compile2m 6sbranch-2 passed
+1 💚javadoc1m 9sbranch-2 passed
+1 💚shadedjars5m 51sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile2m 3sthe patch passed
+1 💚javac2m 3sthe patch passed
+1 💚javadoc1m 3sthe patch passed
+1 💚shadedjars6m 16spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 11shbase-resource-bundle in the patch passed.
+1 💚unit1m 13shbase-http in the patch passed.
-1 ❌unit310m 42s/patch-unit-hbase-server.txthbase-server in the patch failed.
+1 💚unit0m 46shbase-shaded in the patch passed.
+1 💚unit0m 22shbase-assembly in the patch passed.
343m 57s
SubsystemReport/Notes
DockerClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7622
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 810b674ab87b 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d4176f6
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/testReport/
Max. process+thread count3475 (vs. ulimit of 30000)
modulesC: hbase-resource-bundle hbase-http hbase-server hbase-shaded hbase-assembly U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7622/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

@Apache9 FYI. Another cleanup. Important for updating the dependencies and parent pom.

@stoty

Copy link
Copy Markdown
Contributor

The unit tests are in a bad shape, but that's not related to these changes.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@mnpoonia

mnpoonia commented Jan 15, 2026

Copy link
Copy Markdown
ContributorAuthor

@stoty can you help me get this committed until 2.6

@virajjasanivirajjasani changed the title HBASE-29820 Bump the syntax of velocity template to align with veloci…HBASE-29820 Bump the syntax of velocity template to align with velocity 2.x syntaxJan 16, 2026

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stoty
stoty merged commit 6434e6e into apache:branch-2Jan 19, 2026
1 check failed
stoty pushed a commit that referenced this pull request Jan 19, 2026
…ty 2.x syntax (#7622)
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 6434e6e)
stoty pushed a commit that referenced this pull request Jan 19, 2026
…ty 2.x syntax (#7622)
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 6434e6e)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mnpoonia@Apache-HBase@stoty@virajjasani