Skip to content

HBASE-29141 Calculate default maxQueueLength call queues correctly - #7620

Closed
Umeshkumar9414 wants to merge 5 commits into
apache:branch-2from
Umeshkumar9414:HBASE-29141_branch-2
Closed

HBASE-29141 Calculate default maxQueueLength call queues correctly#7620
Umeshkumar9414 wants to merge 5 commits into
apache:branch-2from
Umeshkumar9414:HBASE-29141_branch-2

Conversation

@Umeshkumar9414

Copy link
Copy Markdown
Contributor

PR for master -#7490

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

I tried all the tests that were failing in the first build and those are working.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 53sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 28sbranch-2 passed
+1 💚compile3m 15sbranch-2 passed
+1 💚checkstyle0m 40sbranch-2 passed
+1 💚spotbugs1m 42sbranch-2 passed
+1 💚spotless0m 52sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 10sthe patch passed
+1 💚compile3m 7sthe patch passed
+1 💚javac3m 7sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 41shbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚spotbugs2m 13sthe patch passed
+1 💚hadoopcheck19m 51sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚spotless1m 13spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
43m 37s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7620
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 24fa31546fac 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 875cbad
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 11sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 35sbranch-2 passed
+1 💚compile0m 43sbranch-2 passed
+1 💚javadoc0m 22sbranch-2 passed
+1 💚shadedjars4m 26sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 8sthe patch passed
+1 💚compile0m 44sthe patch passed
+1 💚javac0m 44sthe patch passed
+1 💚javadoc0m 20sthe patch passed
+1 💚shadedjars4m 23spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit229m 30s/patch-unit-hbase-server.txthbase-server in the patch failed.
249m 22s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7620
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 268e1d8044e6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 875cbad
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/testReport/
Max. process+thread count4010 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 15sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 44sbranch-2 passed
+1 💚compile0m 45sbranch-2 passed
+1 💚javadoc0m 26sbranch-2 passed
+1 💚shadedjars4m 42sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 9sthe patch passed
+1 💚compile0m 37sthe patch passed
+1 💚javac0m 37sthe patch passed
+1 💚javadoc0m 23sthe patch passed
+1 💚shadedjars4m 15spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit232m 3s/patch-unit-hbase-server.txthbase-server in the patch failed.
252m 30s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7620
Optional Testsjavac javadoc unit compile shadedjars
unameLinux f15cca6f9127 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 875cbad
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/testReport/
Max. process+thread count3522 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 25sbranch-2 passed
+1 💚compile0m 52sbranch-2 passed
+1 💚javadoc0m 28sbranch-2 passed
+1 💚shadedjars6m 14sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 4sthe patch passed
+1 💚compile0m 51sthe patch passed
+1 💚javac0m 51sthe patch passed
+1 💚javadoc0m 26sthe patch passed
+1 💚shadedjars6m 14spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit234m 40shbase-server in the patch passed.
262m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7620
Optional Testsjavac javadoc unit compile shadedjars
unameLinux a850fc4027fd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 875cbad
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/testReport/
Max. process+thread count3301 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7620/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

After #7652 this separate PR will not be needed, then commit on master will be a clean cherry-pick

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying over +1 from master version, will merge soon unless objection

@apurtell

Copy link
Copy Markdown
Contributor

After #7652 this separate PR will not be needed, then commit on master will be a clean cherry-pick

@Umeshkumar9414 . #7652 is approved, so you can go ahead and close this.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

Closing this as after #7652, we didn't need separate PR for branch-2. Cherry pick of #7490 will work.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Umeshkumar9414@Apache-HBase@apurtell@d-c-manning