Skip to content

HBASE-29837 Backport HBASE-27355 Separate meta read requests from master and client (#7261) - #7652

Merged
apurtell merged 2 commits into
apache:branch-2from
Umeshkumar9414:HBASE-29837
Jan 26, 2026
Merged

HBASE-29837 Backport HBASE-27355 Separate meta read requests from master and client (#7261)#7652
apurtell merged 2 commits into
apache:branch-2from
Umeshkumar9414:HBASE-29837

Conversation

@Umeshkumar9414

Copy link
Copy Markdown
Contributor

Because, MetaTableAccessor moved to hbase-server in master/branch-3 in HBASE-24609 and HBASE-25758, cherry-pick of HBASE-27355 was not clean.

This is an important improvement and I think needed in 2.x as well.

…e#7261)
Co-authored-by: huiruan <huiruan@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
public static final int HIGH_QOS = 200;
public static final int SYSTEMTABLE_QOS = HIGH_QOS;
// QOS for internal meta read requests
public static final int INTERNAL_READ_QOS = 250;

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought of another approch where we can define INTERNAL_READ_QOS in AnnotationReadingPriorityFunction (hbase-server module) and then let the master pass the priority while requesting to MetaTableAccessor, but that way we would end up doing many changes.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

@frostruan , @Apache9 , @mnpoonia please review.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

Same tests, TestSecureIPC, were passing in the previous build. So I think we can ignore Test failure.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 57sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 55sbranch-2 passed
+1 💚compile5m 59sbranch-2 passed
+1 💚checkstyle1m 25sbranch-2 passed
+1 💚spotbugs3m 36sbranch-2 passed
+1 💚spotless1m 24sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 18sthe patch passed
+1 💚compile5m 33sthe patch passed
+1 💚javac5m 33sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 24sthe patch passed
+1 💚spotbugs4m 48sthe patch passed
+1 💚hadoopcheck23m 15sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.1.
+1 💚spotless1m 4spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
63m 9s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#7652
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux d5b194c33f8e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5ffb430
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 34sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 13sbranch-2 passed
+1 💚compile1m 2sbranch-2 passed
+1 💚javadoc0m 43sbranch-2 passed
+1 💚shadedjars3m 49sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall1m 50sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚javadoc0m 42sthe patch passed
+1 💚shadedjars3m 47spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit1m 45shbase-common in the patch passed.
+1 💚unit7m 30shbase-client in the patch passed.
-1 ❌unit239m 13s/patch-unit-hbase-server.txthbase-server in the patch failed.
270m 12s
SubsystemReport/Notes
DockerClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#7652
Optional Testsjavac javadoc unit compile shadedjars
unameLinux d6083d1b9b21 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5ffb430
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/testReport/
Max. process+thread count3338 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 57sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall3m 48sbranch-2 passed
+1 💚compile1m 53sbranch-2 passed
+1 💚javadoc1m 14sbranch-2 passed
+1 💚shadedjars6m 24sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 11sthe patch passed
+1 💚compile1m 27sthe patch passed
+1 💚javac1m 27sthe patch passed
+1 💚javadoc0m 59sthe patch passed
+1 💚shadedjars6m 1spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 32shbase-common in the patch passed.
+1 💚unit8m 6shbase-client in the patch passed.
+1 💚unit236m 50shbase-server in the patch passed.
279m 52s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#7652
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 18084680cf01 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5ffb430
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/testReport/
Max. process+thread count3278 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 17sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 44sbranch-2 passed
+1 💚compile2m 17sbranch-2 passed
+1 💚javadoc1m 26sbranch-2 passed
+1 💚shadedjars7m 14sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 21sthe patch passed
+1 💚compile2m 15sthe patch passed
+1 💚javac2m 15sthe patch passed
+1 💚javadoc1m 27sthe patch passed
+1 💚shadedjars7m 8spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit3m 14shbase-common in the patch passed.
+1 💚unit8m 3shbase-client in the patch passed.
+1 💚unit246m 17shbase-server in the patch passed.
297m 48s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#7652
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 29325373184e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5ffb430
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/testReport/
Max. process+thread count3104 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7652/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Umeshkumar9414

Copy link
Copy Markdown
ContributorAuthor

@apurtell , @Apache9 can you please review and merge.

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, will merge soon unless objection

@apurtell
apurtell merged commit 5ad076d into apache:branch-2Jan 26, 2026
1 check failed
asf-gitbox-commits pushed a commit that referenced this pull request Jan 26, 2026
…ter and client (#7261) (#7652)
* HBASE-27355 Separate meta read requests from master and client (#7261)
Co-authored-by: huiruan <huiruan@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
* HBASE-29837 spotless apply
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Co-authored-by: Ruanhui <32773751+frostruan@users.noreply.github.com>
Co-authored-by: ukumawat <ukumawat@salesforce.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asf-gitbox-commits pushed a commit that referenced this pull request Jan 26, 2026
…ter and client (#7261) (#7652)
* HBASE-27355 Separate meta read requests from master and client (#7261)
Co-authored-by: huiruan <huiruan@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com>
* HBASE-29837 spotless apply
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Co-authored-by: Ruanhui <32773751+frostruan@users.noreply.github.com>
Co-authored-by: ukumawat <ukumawat@salesforce.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Umeshkumar9414@Apache-HBase@apurtell@mnpoonia@frostruan@d-c-manning